From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB29EC2BBCA for ; Tue, 25 Jun 2024 14:30:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sq3ziUtXthBgCrnV7yelZ2t7IZjbyFWPyuOyteVHxOk=; b=ZQ5kjw4tOQv7BYil8Js8A1xAbu 9M5jITG42vaduc8m9ncDRmbRznXKL5duzoYaJSrUdPYhDloMCe69zMNak37b20CueDpO0AiZIPECG Bvi/LTV9TfLICsdCTrzcydGODsmK5tKp4ox1O17MS/zmBJZ4oiZ/AuucCoYLXJdcRyOBzyRbG+Cdk +nytZ1TTAJFV6z4RU607PU3Aa0j3GDEfqWwHHmzDzVnaj+2ybh4Pt484dnf32C6U2kxj9hd4vpk7Y Kilanul2ZIcS0TbeAy6JQzpyMemjn0VK1lfagbP4m/dLCXYg3Q82VGniflW3JMBY9sKk5kzfDO+4m p2mj84MQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sM7Bs-00000003BX0-2NOy; Tue, 25 Jun 2024 14:30:36 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sM7Bl-00000003BUw-2fdL for linux-arm-kernel@lists.infradead.org; Tue, 25 Jun 2024 14:30:31 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 63E4CCE1ACB; Tue, 25 Jun 2024 14:30:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4841CC32781; Tue, 25 Jun 2024 14:30:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1719325826; bh=9tO7IZgG2Eakun8AumgjuwsmLm6VCVkaQQyUnGM/LJA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RvDVfhnWZ4+6R35mtCpawhGntF5GxG/7AHndEhYp8YGC6IT/2L2zZBo2SIJ03GO06 HviWdrFveIUNGho+BX6Qi57vp1d//KzwQmS6K8aR1LSGeQ+Dba08EUI78j0nOnqraa 5lIf0l518d+SPZaBXGMlOtANAebIjjezbFyr+Xl0= Date: Tue, 25 Jun 2024 16:30:24 +0200 From: Greg Kroah-Hartman To: Markus Elfring Cc: linux-aspeed@lists.ozlabs.org, linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ma Ke , Andrew Jeffery , Joel Stanley , Lee Jones , Julia Lawall , Neal Liu , LKML Subject: Re: [PATCH v4] usb: gadget: aspeed_udc: validate endpoint index for ast udc Message-ID: <2024062532-strep-president-44d7@gregkh> References: <20240625022306.2568122-1-make24@iscas.ac.cn> <2024062556-ladder-canister-1ab1@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240625_073029_875895_DBE6DFF7 X-CRM114-Status: GOOD ( 11.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 25, 2024 at 02:50:25PM +0200, Markus Elfring wrote: > >>> We should verify the bound of the array to assure that host > >>> may not manipulate the index to point past endpoint array. > >> > >> Why did you not choose an imperative wording for your change description? > >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc5#n94 > > > > Markus, please stop reviewing USB patches. This is not helpful at all, > > and causes new developers extra work for no reason at all. > > How does this feedback fit to the linked information source? That is not what I wrote. I wrote, "Please stop reviewing USB patches." Please stop now. greg k-h