From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8205CC3064D for ; Tue, 25 Jun 2024 04:42:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rW483qKXLwGavQbUNzUu21573CDBp6UlxpynVeGn4iI=; b=Dsqt1eTeEUn9kZ+r42/Mo8FCNw q2OLWB7XoYG5CgrRPAd4BMbRwILtH/TDBnW+S6ZlnIBr6o0E4QasqhGwPl2tHHBtbMbRTCclkNxnN 6fPxQS8XuWOR/f/Puq/rBQ4WikeCBU7mzAC159mZRiY1nsF/qhJF4E4TgHl3tX10HLM4mSi863Zvj Oge81ebWYQgTA4VRpGxF5Sos0JDG0LGt1PKoMtpgOFmD3965VsHHYeD1j+Z6Ib4NY+6rJDQsWOmXk 6K/YphFJuxmgqg75ixAFWjfoiJG/oWhTMPD3Na3AHQT4gr/zWiDaWlbe7s0/+QNdB/Rl4bL9kJgZH uoTpQVJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLy0Y-00000001at8-440R; Tue, 25 Jun 2024 04:42:18 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLy0S-00000001asF-1ZX7 for linux-arm-kernel@lists.infradead.org; Tue, 25 Jun 2024 04:42:13 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9E4EF611DB; Tue, 25 Jun 2024 04:42:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0FB6C32782; Tue, 25 Jun 2024 04:42:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1719290531; bh=5Iel3gIemmTqgmdoFgLDuJp3DyqVPqYisMuF5wmmuwY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PG5ERh9CDjtbjgjSLU4sWpSTqrx9siGeKsNo1P1bjON33MURLWvEfGm07b1tL1RBO AmQFvaPNrOAkdoRWbeEf2XHAriMfXIm5vHEpBkFSODYx2h/r+1y9E1KBSkEj2dwBFr jMx+7eRZo45R+4HL3JsgJeveQnelFCUB+EZj5JJQ= Date: Tue, 25 Jun 2024 06:42:08 +0200 From: Greg KH To: Jacky Huang Cc: dan.carpenter@linaro.org, jirislaby@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Jacky Huang Subject: Re: [PATCH v3] tty: serial: ma35d1: Add a NULL check for of_node Message-ID: <2024062539-juicy-movable-0e94@gregkh> References: <20240625032919.73-1-ychuang570808@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240625032919.73-1-ychuang570808@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240624_214212_484277_EF709F5C X-CRM114-Status: UNSURE ( 9.86 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 25, 2024 at 03:29:19AM +0000, Jacky Huang wrote: > From: Jacky Huang > > The pdev->dev.of_node can be NULL if the "serial" node is absent. > Add a NULL check to return an error in such cases. > > v3: > - Added "Reported-by:" line. > v2: > - Added "Fixes" line. As per the kernel documentation, these "v3:" information goes below the --- line. Please fix up and send a v4. thanks, greg k-h