From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A157C2BBCA for ; Tue, 25 Jun 2024 15:25:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yzQtlpf+5sT0QDjl7Whn1WrOm/nXK8JfR6OcrUAchKg=; b=3S2a/wQddBpjlmLubJPxIOuzfo RoXUovEWDlXMTKB01tIIOBJ1RLOLBYQz6liqUUQnZMXBWlVADVDBsbW1jfXu/7Kw9hbYljQbAbYFb vxW2Ir9YytKC8JC93s4XNk5ZtGR/459gylv6XabbtGVRx9OIYEjnLBQafdEqMn7Qb2TUaO7xZP4PI g3Jtv/0IQyh3ufa5V9Wo99lOiyz/n3s1EuLhHCP1LLpbpIbDQj3Tosys8i5uSFhMWhYiBJinQh9xO ZJy1UR/PdkaxX0Z9GPpW0ZNKaZbWUYxzntVrnusUBJI0LADtwNEm46dvmyU7kJdV9XF3FuloDE2kt 4Xp+SuSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sM82o-00000003W5S-1cFf; Tue, 25 Jun 2024 15:25:18 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sM82g-00000003W2w-3n6C for linux-arm-kernel@lists.infradead.org; Tue, 25 Jun 2024 15:25:13 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id DF14CCE1BB0; Tue, 25 Jun 2024 15:25:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8CE1C32781; Tue, 25 Jun 2024 15:25:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1719329108; bh=9ATm6u9GQtzia4cO4CCanYRiBsUIMielL7YcNMryhKs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zPt753lMCbNHYxxzeC9in8PKtzKv63K3kC1fbF7B7j/HbszDzpL/5KT6NYeM7IVTC lVLKj0IQrkeotWxumBO2TKd9FsxsD8Qehd+RLw+NMXtOi0JQCNshB5o63yYqGcEIpL jpTRlc7Vkic5fSTLgrBoX+MXbjIiiBBb9sLGSPLU= Date: Tue, 25 Jun 2024 17:25:05 +0200 From: Greg Kroah-Hartman To: Markus Elfring Cc: linux-aspeed@lists.ozlabs.org, linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ma Ke , Andrew Jeffery , Joel Stanley , Julia Lawall , Neal Liu , LKML Subject: Re: [PATCH v4] usb: gadget: aspeed_udc: validate endpoint index for ast udc Message-ID: <2024062553-koala-granddad-50f1@gregkh> References: <20240625022306.2568122-1-make24@iscas.ac.cn> <2024062556-ladder-canister-1ab1@gregkh> <2024062532-strep-president-44d7@gregkh> <5fa430f5-3e18-4c20-93d4-6733afd6bdcf@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5fa430f5-3e18-4c20-93d4-6733afd6bdcf@web.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240625_082511_261788_F6B715C8 X-CRM114-Status: GOOD ( 16.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 25, 2024 at 05:20:07PM +0200, Markus Elfring wrote: > >>>>> We should verify the bound of the array to assure that host > >>>>> may not manipulate the index to point past endpoint array. > >>>> > >>>> Why did you not choose an imperative wording for your change description? > >>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc5#n94 > >>> > >>> Markus, please stop reviewing USB patches. This is not helpful at all, > >>> and causes new developers extra work for no reason at all. > >> > >> How does this feedback fit to the linked information source? > > > > That is not what I wrote. > > You indicated concerns according to patch review processes, > didn't you? > > See also: > * Patch submission notes > https://elixir.bootlin.com/linux/v6.10-rc5/source/Documentation/process/maintainer-tip.rst#L100 This is not the tip tree. > * Contributor Covenant Code of Conduct > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/code-of-conduct.rst?h=v6.10-rc5#n3 I do not see how this is relevant here. > > I wrote, "Please stop reviewing USB patches." > > > > Please stop now. > > I might be going to influence evolution of this software area in other ways > under other circumstances. Please take some time and find other projects to help out. greg k-h