From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 919EBC30653 for ; Tue, 25 Jun 2024 12:31:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ecJmN1UfKOR6YGOrXomd0K2FGEbGmx4oTYi5UnyXp5U=; b=0kR43HgnJ9+ewqC8J/XdBGDsB4 x27m2Db2Gnq8Z7xXyhhqZ1mb839fXLhvHz7266ML42tByABqVAUNemwLuMKzgkTs6v+LXY3k6Tfho SVgWXB06caF8SKRymVZcUjbCjVp9IomJ3BI8FhTAZHfeZCsOVRyqI4vvRTmBPoMV9TxhvRyqp3wV+ RbE9i+VQZqvQ4wqT3aVTur/7PmB+nr+vgaJ8fgFBaoaIT79Rp5Nfqf9DK2q9LADJtDJMe+VT+EmCV kOUlp8Obj1rJ6VGB3SHacZqcjB3hY50x2aEWbk0hdnDiPhKaKKqXT2ixjHVs9tRGF/FeW1YqAMZO0 2+oUxiGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sM5KC-00000002m2y-3W5T; Tue, 25 Jun 2024 12:31:04 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sM5K6-00000002m28-2sTD for linux-arm-kernel@lists.infradead.org; Tue, 25 Jun 2024 12:31:00 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EB1DD61347; Tue, 25 Jun 2024 12:30:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43ED2C32786; Tue, 25 Jun 2024 12:30:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1719318657; bh=7ZnF264um0Yqg5hHDTg1nc/wQWc+Bl1oj8XVxnLnpOs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cOl+tL7k+e8oLbUP1ARC0d6J0DStfdhpYKH+90kTUAiSlHDBGZCqpn3MAB181VN/X TafwHnPlLZnHqv2Y61YDuT1lc5k7SZfeHDJnlOYIrpanS/sHW3h7irPjWnKiSTayjU de/K91gruCLlE4VpMAopvoU9YWes0yizxw9CzXBE= Date: Tue, 25 Jun 2024 14:30:54 +0200 From: Greg Kroah-Hartman To: Markus Elfring Cc: Ma Ke , linux-aspeed@lists.ozlabs.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Andrew Jeffery , Joel Stanley , Neal Liu , LKML Subject: Re: [PATCH v4] usb: gadget: aspeed_udc: validate endpoint index for ast udc Message-ID: <2024062556-ladder-canister-1ab1@gregkh> References: <20240625022306.2568122-1-make24@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240625_053059_021688_1D15D391 X-CRM114-Status: UNSURE ( 9.67 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 25, 2024 at 02:00:15PM +0200, Markus Elfring wrote: > > We should verify the bound of the array to assure that host > > may not manipulate the index to point past endpoint array. > > Why did you not choose an imperative wording for your change description? > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc5#n94 Markus, please stop reviewing USB patches. This is not helpful at all, and causes new developers extra work for no reason at all. You have been warned many times about this, and many people have talked to you about this. If you continue, you will have to be banned the mailing lists, again. greg k-h