From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4DF77C30653 for ; Wed, 26 Jun 2024 09:00:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=X/2C6GASRfzqQDrURanIFBfd8iFrgYz48mwj2fRwQls=; b=roVcnNlWxOFAari52jwiIjdakq tqtWXQ/EHK33dIUzVIl7fP4KOcL3ShkaVWDGLhnE8k02/aut8u7dWXf8utW+lYAusyVNqq8TPVuDo ZRqIyDZ7RaIdBHI6wrdPEe9ocJPuQRcysm8wCarTEIa6g4dvBeJO1Vve5Q+BisYuabdI1GWI9vSJ4 7kx0IedE416/7ZXfjkBuwdahsBOgA1dxCXihqrx2TjpSB9S9v8vIhynJRrr027bPDQDvH0Rs/gpdD uxmEDJzj4RTBAw/7ljSMhLDt5Y0KrgBJTDJ8cFsCCduTonVkVcgPrTUL6rAe4WfI6b7RpQvP4B2Fx ezDxpp6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMOVa-000000061b3-357Y; Wed, 26 Jun 2024 09:00:06 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMOVR-000000061XE-0p4O for linux-arm-kernel@lists.infradead.org; Wed, 26 Jun 2024 08:59:58 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9E9DC6197E; Wed, 26 Jun 2024 08:59:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F1C5C4AF0C; Wed, 26 Jun 2024 08:59:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719392395; bh=uoef4xR150WG+JCSrIubghaULCeTQM1RRAxszK/UVJk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=amgAXdYh5FFfBrRxTsEkwdn0psPhYCAPkVHe/GyzDzirE8odO+iVIgekTg/VKbpg8 fXUA/k+jGgkPcXU0YOI0nURpYgIOH8aAxHjXkZbUUQdodWixl52L90jI20DeywWqJc SJIFW0RwMCrJ9/ki2GGqvsc07BKhIAxxAGgo1XaZDLarUo0LOZ0Hq4Bok3kge1mhGw M4H/J1RJwpI9KUWKQXKWa/N9KgUghhMHVbWikMkoi+kHYOC+QJ7PsnhpuFVJkfHed4 MQ0AOn/hy8qZLypOrN3FzU9SvSuC4iyhD2Ic1K8mOPuspQ0bGQHGKZh6DpU03DppFb 00TqDq/VpFzbw== Date: Wed, 26 Jun 2024 09:59:50 +0100 From: Conor Dooley To: Manikandan.M@microchip.com Subject: Re: [PATCH v2 4/5] dt-bindings: gpio: convert Atmel GPIO to json-schema Message-ID: <20240626-fondly-batboy-e99846fd6c45@spud> References: <20240625043525.279711-1-manikandan.m@microchip.com> <20240625043525.279711-5-manikandan.m@microchip.com> <20240625-clerical-manicure-ebc8a1d1b16b@spud> <96898000-1ef4-40c7-83de-3759d48c9ace@microchip.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="htBluDkPT/WNhxo8" Content-Disposition: inline In-Reply-To: <96898000-1ef4-40c7-83de-3759d48c9ace@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240626_015957_362635_176C07E4 X-CRM114-Status: GOOD ( 30.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robh@kernel.org, conor+dt@kernel.org, arnd@arndb.de, alexandre.belloni@bootlin.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linus.walleij@linaro.org, claudiu.beznea@tuxon.dev, linux-gpio@vger.kernel.org, Durai.ManickamKR@microchip.com, krzk+dt@kernel.org, brgl@bgdev.pl, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --htBluDkPT/WNhxo8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 26, 2024 at 08:32:41AM +0000, Manikandan.M@microchip.com wrote: > On 25/06/24 10:04 pm, Conor Dooley wrote: > > Re: [PATCH v2 4/5] dt-bindings: gpio: convert Atmel GPIO to json-schema > > From: Conor Dooley > > On Tue, Jun 25, 2024 at 10:05:24AM +0530, Manikandan Muralidharan wrote: > >> Convert the Atmel GPIO controller binding document to DT schema format > >> using json-schema. > >> The compatible string "microchip,sam9x7-gpio" is added as well. > >> > >> Signed-off-by: Manikandan Muralidharan > >> --- > >> changes in v2: > >> - Fix bot errors with 'make dt_binding_check', missed to add > >> "atmel,at91rm9200-gpio" as separate compatible for devices that uses it > >> - Remove label from example > >> - Add default entry for #gpio-lines property > >> - Add new compatible string details in commit message > >> --- > >> .../bindings/gpio/atmel,at91rm9200-gpio.yaml | 81 +++++++++++++++++= ++ > >> .../devicetree/bindings/gpio/gpio_atmel.txt | 31 ------- > >> 2 files changed, 81 insertions(+), 31 deletions(-) > >> create mode 100644 Documentation/devicetree/bindings/gpio/atmel,at91= rm9200-gpio.yaml > >> delete mode 100644 Documentation/devicetree/bindings/gpio/gpio_atmel= =2Etxt > >> > >> diff --git a/Documentation/devicetree/bindings/gpio/atmel,at91rm9200-g= pio.yaml b/Documentation/devicetree/bindings/gpio/atmel,at91rm9200-gpio.yaml > >> new file mode 100644 > >> index 000000000000..3dd70933ed8e > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/gpio/atmel,at91rm9200-gpio.yaml > >> @@ -0,0 +1,81 @@ > >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >> +%YAML 1.2 > >> +--- > >> +$id:http://devicetree.org/schemas/gpio/atmel,at91rm9200-gpio.yaml# > >> +$schema:http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: Microchip GPIO controller (PIO) > >> + > >> +maintainers: > >> + - Manikandan Muralidharan > >> + > >> +properties: > >> + compatible: > >> + oneOf: > >> + - items: > >> + - enum: > >> + - atmel,at91sam9x5-gpio > >> + - microchip,sam9x60-gpio > >> + - const: atmel,at91rm9200-gpio > >> + - items: > >> + - enum: > >> + - microchip,sam9x7-gpio > >> + - const: microchip,sam9x60-gpio > >> + - const: atmel,at91rm9200-gpio > > It's worth pointing out that this is required, because the driver > > implements a different set of ops for the sam9x60. There's not just more > > of them, they're different too. > > Are the sam9x60 and at91rm9200 are actually compatible, or is the > > fallback here some mistake that originated in the dts? > >=20 > The PIO3 pinctrl driver uses the compatible "atmel,at91rm9200-gpio" to=20 > find the number of active GPIO banks and also to differentiate them from= =20 > the pinmux child nodes.The driver probe fails if the at91rm9200 is not=20 > present in the GPIO bank compatible property list. > For sam9x7, "microchip,sam9x60-gpio" is used as the fallback compatible= =20 > and "atmel,at91rm9200-gpio" is added by default to avoid probe issues=20 > and help find the number of GPIO banks by the driver. That's unfortunately not what I asked. Forget about at91_pinctrl_child_count() for a minute and answer the question again: Are the sam9x60 and at91rm9200 actually compatible? Hints: - Do the registers that are in the at91rm9200 have the same behaviour in the sam9x60? - Are the new registers in sam9x60 optional, so that if all sam9x60 code was deleted from the driver, the driver would still work for the subset of features that the at91rm9200 already supports? Thanks, Conor. --htBluDkPT/WNhxo8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZnvYggAKCRB4tDGHoIJi 0stIAP4r0BMt/ii9XgqDScUCMAthAqWPZlVmFwNfU1gg0oFwHgD8DKPjQ7phDIf7 miwlRN09TaMiKBRnmHP7IcinUtkNhAw= =qyjk -----END PGP SIGNATURE----- --htBluDkPT/WNhxo8--