From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE088C27C4F for ; Wed, 26 Jun 2024 14:06:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TCJWO8pYy1pCV+fI3h1hz9BtW0SdkaQWYmwWRyrttJs=; b=L/TSH46ZDfHTcSnfvvlCTWIsDz UQECfmG9qxrT1SO43N8tXCil6PPUT8c5QM8MuLqP5xcAWI1Ajm3elz0lbdt1I0hLV/g1AhbKCZK3A O20LHRZgxTZt68WZTWNpx6uSFZSKQHecyIlrN6LYuW5YYy6Qj+DIjh9d0nblCd8iUj0WXuNMSuDMA VH+QiWtvYOtTwFPH3pd2RS4zpk9S9+P3orHbxEdWvLQ9jJ6n2f307cyZFLqvWZhRZZfr/FWZ2/c3k VYdqab8yqgiON22zNxWK7Ms/iQWoS+120+nKx1yargJu0xu5w4usodEa3Ii+7WBLCU2glOFn/icSa 9a91oezA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMTIE-000000076I3-096Z; Wed, 26 Jun 2024 14:06:38 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMTI5-000000076G8-2zcb for linux-arm-kernel@lists.infradead.org; Wed, 26 Jun 2024 14:06:31 +0000 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-42122ac2f38so4408615e9.1 for ; Wed, 26 Jun 2024 07:06:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719410787; x=1720015587; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TCJWO8pYy1pCV+fI3h1hz9BtW0SdkaQWYmwWRyrttJs=; b=acUjKKjvQ93Ici4AuHj+mcjwuR9RV+3a7+c1Ra7T7zr0nfYWwIdUSCtTO2xCI9U45f RL/4/Q2AzVBYNEPxrqMX4zTuCSPVr7dixNMa8jLFs54u/U/+ELlTG/NJPHnGDr+/a6BF 0DU3WTFD/nx1Rf+z1KUbsiJpNo2tAdg68XoSxCWWPz+jVIDLZmcXthnT2YXdMp6DD3Gh qDQoBmLuBwMR2BDVC23sYeBLAyxxnVbtSOJPtUNap/AcnyObOA2nGDp1kwz1uLO1pChc Kcyc3v8iOtBdxte92nhPYwHEYNFvcnv6X6Lf9j1sG/FKfM1a2F728o1++kkXtZ5Ko51o JnjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719410787; x=1720015587; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TCJWO8pYy1pCV+fI3h1hz9BtW0SdkaQWYmwWRyrttJs=; b=hdOncICety6uVbiwuyGTrV1KFbXMVtgUNMq42R922slhkyrrKCD8tPBai7MJyRRECk F2YCrSMUbXX/pSXXQUeIx+KEMmmAXM/TRI7VzQb6Jhd0l3cMtyMjnnfHgpB7MHVUfGNg YtuIEkYWjuMcn0WmS7Olfg1Cl7zuMnWOsniBIgFm6E/wQ3djnUQf5ba02RASOLmgdlrF tZZ3akdbM8hmb0jHQhkbrh9UG0L4v5vcTVmBzZo0Fv8DIBoyk405P8kXWe3bI44ajk+k Njdbm72N89d4/jnEo4mtsTwoZg+q/A0yQTN8ef6Yo+f5t/YdvBhmRdwMv7vp3a1E1nxk SC7A== X-Forwarded-Encrypted: i=1; AJvYcCUo2BpB4p5KxaMelRvXf13tDZelvpf8n/ZyKcNOlkuTVhz01nBEzNOFVbwTGhgqb1A/+Ui071rGtDSwkvCRkI/CVCREYR4eHaeKrtNL7RKV3EBJdGY= X-Gm-Message-State: AOJu0YxdGlKCXDhXz6zUyD/5ujO2VAODZrG9hItc2PspCUl7O/KuEbu1 LurXSvlsKWCplt59P9mE25443lsJyjljcTvYn1t2z1SdQBpBswS2 X-Google-Smtp-Source: AGHT+IF3ry4rO2+gkoziIvVV6PiJ5Arx0ZGpxYJD3SVWw7rDf/IM1AqIgI7RKDFMBugpghsAwV+89Q== X-Received: by 2002:a05:600c:3583:b0:424:ade3:c6b7 with SMTP id 5b1f17b1804b1-424ade3c894mr19285775e9.2.1719410786647; Wed, 26 Jun 2024 07:06:26 -0700 (PDT) Received: from skbuf ([79.115.210.53]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-424c82519bdsm27908795e9.13.2024.06.26.07.06.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jun 2024 07:06:26 -0700 (PDT) Date: Wed, 26 Jun 2024 17:06:23 +0300 From: Vladimir Oltean To: Breno Leitao Cc: kernel test robot , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, kuba@kernel.org, horms@kernel.org, Roy.Pledge@nxp.com, open list Subject: Re: [PATCH 1/4] soc: fsl: qbman: FSL_DPAA depends on COMPILE_TEST Message-ID: <20240626140623.7ebsspddqwc24ne4@skbuf> References: <20240624162128.1665620-1-leitao@debian.org> <202406261920.l5pzM1rj-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202406261920.l5pzM1rj-lkp@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240626_070629_880759_83D16F78 X-CRM114-Status: GOOD ( 23.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 26, 2024 at 08:09:53PM +0800, kernel test robot wrote: > Hi Breno, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on herbert-cryptodev-2.6/master] > [also build test WARNING on soc/for-next linus/master v6.10-rc5 next-20240625] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Breno-Leitao/crypto-caam-Depend-on-COMPILE_TEST-also/20240625-223834 > base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master > patch link: https://lore.kernel.org/r/20240624162128.1665620-1-leitao%40debian.org > patch subject: [PATCH 1/4] soc: fsl: qbman: FSL_DPAA depends on COMPILE_TEST > config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240626/202406261920.l5pzM1rj-lkp@intel.com/config) > compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240626/202406261920.l5pzM1rj-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202406261920.l5pzM1rj-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > >> drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:3280:12: warning: stack frame size (16664) exceeds limit (2048) in 'dpaa_eth_probe' [-Wframe-larger-than] > 3280 | static int dpaa_eth_probe(struct platform_device *pdev) > | ^ > 1 warning generated. > -- > >> drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c:454:12: warning: stack frame size (8264) exceeds limit (2048) in 'dpaa_set_coalesce' [-Wframe-larger-than] > 454 | static int dpaa_set_coalesce(struct net_device *dev, > | ^ > 1 warning generated. Arrays of NR_CPUS elements are what it probably doesn't like? In the attached Kconfig, CONFIG_NR_CPUS is 8192, which is clearly excessive compared to the SoCs that the driver is written for and expects to run on (1-24 cores). static int dpaa_set_coalesce(struct net_device *dev, struct ethtool_coalesce *c, struct kernel_ethtool_coalesce *kernel_coal, struct netlink_ext_ack *extack) { const cpumask_t *cpus = qman_affine_cpus(); bool needs_revert[NR_CPUS] = {false}; ... } static void dpaa_fq_setup(struct dpaa_priv *priv, const struct dpaa_fq_cbs *fq_cbs, struct fman_port *tx_port) { int egress_cnt = 0, conf_cnt = 0, num_portals = 0, portal_cnt = 0, cpu; const cpumask_t *affine_cpus = qman_affine_cpus(); u16 channels[NR_CPUS]; ... } While 'needs_revert' can probably easily be converted to a bitmask which consumes 8 times less space, I don't know what to say about the "channels" array. It could probably be rewritten to use dynamic allocation for the array. I don't have any better idea...