From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBF7DC3064D for ; Thu, 27 Jun 2024 10:08:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bPmKE6m3iuC80im7sGG384cxxyCIT6F54zcU6iUxo2g=; b=eqCiupNTp3TQq1aNRBGglfTzSK oVlIUxEl4m3czyYqu6McDfylNd/mecy1F/ZLW7ksSvjkFTNZFZnK6Hb4pF8/3HsXH4SkKEATYwdwt VP4BoQPB4uEp22gJwVDND2i8/Wlt5j8vcHq9HIax2d5FvyohG97J/rlbTApYm6hpLTUiCPRnAnxu+ 9kjsgvFSLt6j59BVVDBOEkwrFdrav3NqKUP+bm3v0lrm8xkCPla3743CLVS/Q0jDheWRxouNI9mVH 85ppgcqJpX1NeidgaQnrcOcxHq4IA8AwGme5QZX/3h7xwq8mBEKMWoWg0YQmW/ke1eMDdZ5E35TLj wGeGPOQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMm2g-00000009sZD-3xfE; Thu, 27 Jun 2024 10:07:50 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMm2a-00000009sXT-1li2 for linux-arm-kernel@bombadil.infradead.org; Thu, 27 Jun 2024 10:07:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:CC:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=bPmKE6m3iuC80im7sGG384cxxyCIT6F54zcU6iUxo2g=; b=ZgEgB5kJIPfh1Cs2ZBPMB6E8DU q6df1o+fnhhEeh/7OPpyBB7NnH2u9nz/2JdBcdfNjx3yyOv4AGlxKXsLgjaed2KWIUbONZtQgf3Ql 7xankgoauTqw6aM7PvjpN1O3yiLbxSBUC8iVI3fXnKU+oJ4Xv0OLocWi2q1kjMWHApgyBA4dkf3Go 1Dg1NgxBRWSU4Z9l2dycAkB1Q4PMCWe4qaEFe0GijWUYZq1rDfWV8jGUr74OZh1573d2bwQ3pyWws 8ls/gWSzWV7CcsrdD9zhI4XI4efCiXOCDxjc0QysbkOXBdXq2fcKvJA1GmfZ4lrTXk94DZzZFwfEz TfbUnb6A==; Received: from esa.microchip.iphmx.com ([68.232.154.123]) by casper.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMlkg-0000000DPCB-1oBX for linux-arm-kernel@lists.infradead.org; Thu, 27 Jun 2024 09:49:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1719481754; x=1751017754; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=pN6Re2YMPpgDHIrU8wMqUUX+Nho2aAX2ZPo1klf9HU8=; b=vRT/ZgMRt+ddc8P/MlaLYsCxxpaa4mjJFYTOxoYiuMw/ixvlcbob4B1n 6SfzJuQBdq1YI7n+D3oBzqNomYFu98yQWDCAFMgwDMIn0Lkxi0Ret6rBa /4jfxoXO1DUKfe+ASZ7+2NWiSr5N5admn6ShKrjqY+yrebTPpnjk64CQ+ +ogwOVwpxG0wsy5M1IE0WrhD2Wjgr2+V2Z9/IbFPIs+3fGW7EMgwAAekI Lw1odGWf+MmwtGcMk+ddF24uj8n0TVYCjRUBTmlHgOLUoarNzdXj6lqsk GkAVV8wsyS/6Wd6OtUqmRDWvFyuyn6SKk6k1iJTwe7J0SB0N8nM0O6R6M g==; X-CSE-ConnectionGUID: NBd6lt7fQhy2ONg/2E6sVw== X-CSE-MsgGUID: Bv/NKQg2Rf+WO9W5JVD94w== X-IronPort-AV: E=Sophos;i="6.08,269,1712646000"; d="asc'?scan'208";a="28542469" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa4.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Jun 2024 02:48:39 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 27 Jun 2024 02:47:56 -0700 Received: from wendy (10.10.85.11) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 27 Jun 2024 02:47:53 -0700 Date: Thu, 27 Jun 2024 10:47:36 +0100 From: Conor Dooley To: AngeloGioacchino Del Regno CC: Lorenzo Bianconi , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 1/4] dt-bindings: clock: airoha: Add reset support to EN7581 clock binding Message-ID: <20240627-vending-lisp-4e1cf45e552c@wendy> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="viUMoJ5rJMO/GO7n" Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240627_104914_844885_12F228C7 X-CRM114-Status: GOOD ( 16.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --viUMoJ5rJMO/GO7n Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 27, 2024 at 11:33:47AM +0200, AngeloGioacchino Del Regno wrote: > Il 13/06/24 14:47, Lorenzo Bianconi ha scritto: > > Introduce reset capability to EN7581 device-tree clock binding > > documentation. > >=20 > > Signed-off-by: Lorenzo Bianconi > > --- > > .../bindings/clock/airoha,en7523-scu.yaml | 25 ++++++- > > .../dt-bindings/reset/airoha,en7581-reset.h | 66 +++++++++++++++++++ > > 2 files changed, 90 insertions(+), 1 deletion(-) > > create mode 100644 include/dt-bindings/reset/airoha,en7581-reset.h > >=20 > > diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.= yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml > > index 3f4266637733..84353fd09428 100644 > > --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml > > +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml > > @@ -35,7 +35,7 @@ properties: > > reg: > > minItems: 2 > > - maxItems: 3 > > + maxItems: 4 > > "#clock-cells": > > description: > > @@ -43,6 +43,10 @@ properties: > > clocks. > > const: 1 > > + '#reset-cells': > > + description: ID of the controller reset line > > + const: 1 > > + > > required: > > - compatible > > - reg > > @@ -60,6 +64,8 @@ allOf: > > - description: scu base address > > - description: misc scu base address > > + '#reset-cells': false > > + > > - if: > > properties: > > compatible: > > @@ -70,6 +76,7 @@ allOf: > > items: > > - description: scu base address > > - description: misc scu base address > > + - description: reset base address >=20 > Are you sure that the indentation is correct? :-) >=20 > After fixing the indentation, >=20 > Reviewed-by: AngeloGioacchino Del Regno >=20 > > - description: pb scu base address The indentation actually looks okay when I apply this locally, but how is it backwards compatible to add this register in the middle of the list?? --viUMoJ5rJMO/GO7n Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZn01OAAKCRB4tDGHoIJi 0vcdAQCBipoQf2eE2rN/hzS8JbT/6QvauBj5IJM9wOfgfJSwMgD/TJA3+UBXnUsQ veYPLRUTwCkZ/3p+b+nwKpEjKhEFrQw= =M+Wq -----END PGP SIGNATURE----- --viUMoJ5rJMO/GO7n--