From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0609AC3064D for ; Thu, 27 Jun 2024 14:24:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1NTwj4Vi6/WKtkqrB7jJjgZ1myz89lNZSkyOV7oLQG8=; b=WF2VL1BZxoq9oeChApS6OhqvJ/ b1xU7bcEmxta1vJ7JV5yvdpHd3wntlDmnLnxi3BjM4YWNPzZ+nTHsDZsVt9Z10meAizJGVpD8YojJ UjAbTI6+ORCKMX/McrWPBxiS6xXHvsQWc0v3kpRXE1sDsAQMtxWFSj/TpJwlV0a+1EZuCkHFBeCr5 ZJCnIE9464ZQip636rda5/w4Pg17/8H6x5Pj7ol4ei5wa260PtsRtLZeYcul4jcQiR0VQV+GmtPXU Ne+sq1fZdf4Al3VHlsjC2oxqqV044/ic22YgV5UR+Mv6S3aZz1ut47tUwaIHw5UCSXNcMiwFTS0fd s8D6q8bg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMq2h-0000000AdM2-1x1n; Thu, 27 Jun 2024 14:24:07 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMq2R-0000000AdHd-2k4g for linux-arm-kernel@lists.infradead.org; Thu, 27 Jun 2024 14:23:55 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5E659CE2C2A; Thu, 27 Jun 2024 14:23:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29D21C2BBFC; Thu, 27 Jun 2024 14:23:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1719498228; bh=hNSjLU6Q2DOaKZ/pmqxycisVgItFODKa0ss4BjbT01o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CUNNgeqmeuVOreC17XDwpSSbnAZhMQ92J1wR0SRfTHaW2EavuMNdkzZNoEGC0gE+x xcEnlUC5fd5/rNuGehohsM5P2T2fxaI6sgj+CdVrCA2z6e2bBAdaoNfgY5q0dd+kE1 VBglty5ojzj8HMzbkDwKYdj/vMEOW0/b9z/FK6c4= Date: Thu, 27 Jun 2024 16:23:45 +0200 From: Greg Kroah-Hartman To: Dmitry Baryshkov Cc: Heikki Krogerus , Maxime Coquelin , Alexandre Torgue , Nikita Travkin , Neil Armstrong , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 0/7] usb: typec: ucsi: rework glue driver interface Message-ID: <2024062723-unwed-sleeve-47b7@gregkh> References: <20240625-ucsi-rework-interface-v3-0-7a6c8e17be3a@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240625-ucsi-rework-interface-v3-0-7a6c8e17be3a@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240627_072353_554461_1694581D X-CRM114-Status: GOOD ( 17.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 25, 2024 at 05:54:25PM +0300, Dmitry Baryshkov wrote: > The interface between UCSI and the glue driver is very low-level. It > allows reading the UCSI data from any offset (but in reality the UCSI > driver reads only VERSION, CCI an MESSAGE_IN data). All event handling > is to be done by the glue driver (which already resulted in several > similar-but-slightly different implementations). It leaves no place to > optimize the write-read-read sequence for the command execution (which > might be beneficial for some of the drivers), etc. > > The patchseries attempts to restructure the UCSI glue driver interface > in order to provide sensible operations instead of a low-level read / > write calls. > > If this approach is found to be acceptable, I plan to further rework the > command interface, moving reading CCI and MESSAGE_IN to the common > control code, which should simplify driver's implementation and remove > necessity to split quirks between sync_control and read_message_in e.g. > as implemented in the ucsi_ccg.c. > > Note, the series was tested only on the ucsi_glink platforms. Further > testing is appreciated. > > Depends: [1], [2] > > [1] https://lore.kernel.org/linux-usb/20240612124656.2305603-1-fabrice.gasnier@foss.st.com/ > > [2] https://lore.kernel.org/linux-usb/20240621-ucsi-yoga-ec-driver-v8-1-e03f3536b8c6@linaro.org/ > > Signed-off-by: Dmitry Baryshkov This doesn't apply to my tree at all, can you rebase and add Heikki's review and resend? thanks, greg k-h