From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0A12C2BBCA for ; Fri, 28 Jun 2024 09:10:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Wv1IgGBKB93isDFqnS1OCk0yXTXsEciaoCZHIJhgY28=; b=nodx+OQLUzqbefMvbGufRurYWz 8E3DIi4J1803cyvo4BQmZSO/ZrII0iUEy4feef52zeDzv8UvD/CM9WMirICVRVP7BEbjjP5xFie6h Ado7d8E+ct1Xr+mCwP8q5ebLiUAF3IcJ7m288OBI14z5vP6Lq3TLyNOZ/RBrKu0Uw/jvbBRTkRIx0 cKKguUf5BKOpW9M0ZIv0q/jmaHO1BeUNDJRQHIjgLhEn1f6OSgJ31T0DX2mWZnBOA3Jd4iO5QNVwn VtGVPwbuTC5sBzIO3NOO2bVCvqq6kAEn1Vmaj7UfP7RcDU/VXalkKCzzlxqI38e9H6yGyH20KI72V 0hFWulVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sN7cv-0000000DDT2-2vTI; Fri, 28 Jun 2024 09:10:41 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sN7cn-0000000DDOo-1IeM for linux-arm-kernel@lists.infradead.org; Fri, 28 Jun 2024 09:10:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1719565833; x=1751101833; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=18XyDU6KxQP0I3pISmWb4VOCYmhixglX1iyFMD05Xhk=; b=OvR1imfMqNibHuIMs021o716WDxer4uhZeZtHXADrvd5PG1wg+EsPSKu RBfgU0tMstTXiETXbj9OlkGu3R2c83XVprrXoyld5BPUFJkK5dm7QJrcT AjlEUugCt146xHll+6H31Rw76GuQdwHukytCv5Adcgn0qzCgEry2VMtQH zRB3+Z3XSJhMkY1oa3CywegJX9lW8wiOyDvJ8vf60U1DpVdq4O+qgnyyS j6br0CkJH/v+8Jf48kw/fCGal90pfsh8to9YaPPfgGttrnmEowpwniYf+ Nko/g/DnFdjmkCDZVH0T7dtf6b48lS4t5xWdsFRxdNVqk93Kp4txFrzkn A==; X-CSE-ConnectionGUID: emjLZb+xQLGEIhpt6YhZ7A== X-CSE-MsgGUID: 6cb5ts00QnykAsc7VOYgvA== X-IronPort-AV: E=Sophos;i="6.09,168,1716274800"; d="asc'?scan'208";a="196014344" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 28 Jun 2024 02:10:22 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 28 Jun 2024 02:09:49 -0700 Received: from wendy (10.10.85.11) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 28 Jun 2024 02:09:46 -0700 Date: Fri, 28 Jun 2024 10:09:29 +0100 From: Conor Dooley To: Andrei Simion Subject: Re: [PATCH v3 3/3] dt-bindings: eeprom: at24: Add Microchip 24AA025E48/24AA025E64 Message-ID: <20240628-plunder-wackiness-72b0acf3624b@wendy> References: <20240628080146.49545-1-andrei.simion@microchip.com> <20240628080146.49545-4-andrei.simion@microchip.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Lv+YdYS0y6vWVfZO" Content-Disposition: inline In-Reply-To: <20240628080146.49545-4-andrei.simion@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240628_021033_449900_FCCA0FDD X-CRM114-Status: GOOD ( 18.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, robh@kernel.org, conor+dt@kernel.org, arnd@arndb.de, devicetree@vger.kernel.org, gregkh@linuxfoundation.org, brgl@bgdev.pl, alexandre.belloni@bootlin.com, linux-i2c@vger.kernel.org, claudiu.beznea@tuxon.dev, krzk+dt@kernel.org, linux-kernel@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --Lv+YdYS0y6vWVfZO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hey, On Fri, Jun 28, 2024 at 11:01:46AM +0300, Andrei Simion wrote: > Add compatible for Microchip 24AA025E48/24AA025E64 EEPROMs. >=20 > Reviewed-by: Connor Dooley ^^ ^ There's no way that I provided a tag with my name spelt incorrectly given I use a macro to insert them. Please copy-paste tags or use b4 to pick them up, rather than type them out yourself. > Signed-off-by: Andrei Simion > --- > v2 -> v3: > - commit subject changed to reference Microchip 24AA025E48/24AA025E64 > - drop the pattern: mac02e4$ and mac02e6$ and a-z from regex > - add these two devices down at the bottom > - added Reviewed-by >=20 > v1 -> v2: > - change pattern into "^atmel,(24(c|cs|mac)[a-z0-9]+|spd)$" to keep simpl= er > --- > Documentation/devicetree/bindings/eeprom/at24.yaml | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documen= tation/devicetree/bindings/eeprom/at24.yaml > index 3c36cd0510de..699c2bbc16f5 100644 > --- a/Documentation/devicetree/bindings/eeprom/at24.yaml > +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml > @@ -132,6 +132,10 @@ properties: > - renesas,r1ex24128 > - samsung,s524ad0xd1 > - const: atmel,24c128 > + - items: > + - const: microchip,24aa025e48 > + - items: > + - const: microchip,24aa025e64 I don't think this patch works, the schema has a select in it that only matches ^atmel,(24(c|cs|mac)[0-9]+|spd)$. You either need to have these fall back to an existing compatible (iff actually compatible) or else do something like: diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documenta= tion/devicetree/bindings/eeprom/at24.yaml index 699c2bbc16f5..4d46b8c5439d 100644 --- a/Documentation/devicetree/bindings/eeprom/at24.yaml +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml @@ -18,7 +18,9 @@ select: properties: compatible: contains: - pattern: "^atmel,(24(c|cs|mac)[0-9]+|spd)$" + anyOf: + - pattern: "^atmel,(24(c|cs|mac)[0-9]+|spd)$" + - enum: ["microchip,24aa025e48", "microchip,24aa025e64"] Thanks, Conor. > - pattern: '^atmel,24c(32|64)d-wl$' # Actual vendor is st > =20 > label: > --=20 > 2.34.1 >=20 --Lv+YdYS0y6vWVfZO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZn59yQAKCRB4tDGHoIJi 0pbWAP9lw36XATcOJnKRPW3/m90qj11xA11z1cjkMvJSaLhYswD+J0qymDWKbMDe 6CYdmhIP5LTEvRfu8+ZdsTtp5Q1ckgY= =2QcV -----END PGP SIGNATURE----- --Lv+YdYS0y6vWVfZO--