From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Haojian Zhuang <haojian.zhuang@gmail.com>,
Daniel Mack <daniel@zonque.org>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Arnd Bergmann <arnd@arndb.de>,
Linus Walleij <linus.walleij@linaro.org>,
soc@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH 09/10] ARM: spitz: Use software nodes to describe LED GPIOs
Date: Fri, 28 Jun 2024 11:08:49 -0700 [thread overview]
Message-ID: <20240628180852.1738922-10-dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20240628180852.1738922-1-dmitry.torokhov@gmail.com>
Convert Spitz to use software nodes for specifying GPIOs for the LEDs.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
arch/arm/mach-pxa/spitz.c | 71 +++++++++++++++++++++++++++------------
1 file changed, 50 insertions(+), 21 deletions(-)
diff --git a/arch/arm/mach-pxa/spitz.c b/arch/arm/mach-pxa/spitz.c
index 4720a40587f1..b19d4ed35192 100644
--- a/arch/arm/mach-pxa/spitz.c
+++ b/arch/arm/mach-pxa/spitz.c
@@ -467,35 +467,64 @@ static inline void spitz_keys_init(void) {}
* LEDs
******************************************************************************/
#if defined(CONFIG_LEDS_GPIO) || defined(CONFIG_LEDS_GPIO_MODULE)
-static struct gpio_led spitz_gpio_leds[] = {
- {
- .name = "spitz:amber:charge",
- .default_trigger = "sharpsl-charge",
- .gpio = SPITZ_GPIO_LED_ORANGE,
- },
- {
- .name = "spitz:green:hddactivity",
- .default_trigger = "disk-activity",
- .gpio = SPITZ_GPIO_LED_GREEN,
- },
+static const struct software_node spitz_gpio_leds_node = {
+ .name = "spitz-leds",
};
-static struct gpio_led_platform_data spitz_gpio_leds_info = {
- .leds = spitz_gpio_leds,
- .num_leds = ARRAY_SIZE(spitz_gpio_leds),
+static const struct property_entry spitz_orange_led_props[] = {
+ PROPERTY_ENTRY_STRING("linux,default-trigger", "sharpsl-charge"),
+ PROPERTY_ENTRY_GPIO("gpios",
+ &spitz_scoop_1_gpiochip_node, 6, GPIO_ACTIVE_HIGH),
+ { }
};
-static struct platform_device spitz_led_device = {
- .name = "leds-gpio",
- .id = -1,
- .dev = {
- .platform_data = &spitz_gpio_leds_info,
- },
+static const struct software_node spitz_orange_led_node = {
+ .name = "spitz:amber:charge",
+ .parent = &spitz_gpio_leds_node,
+ .properties = spitz_orange_led_props,
+};
+
+static const struct property_entry spitz_green_led_props[] = {
+ PROPERTY_ENTRY_STRING("linux,default-trigger", "disk-activity"),
+ PROPERTY_ENTRY_GPIO("gpios",
+ &spitz_scoop_1_gpiochip_node, 0, GPIO_ACTIVE_HIGH),
+ { }
+};
+
+static const struct software_node spitz_green_led_node = {
+ .name = "spitz:green:hddactivity",
+ .parent = &spitz_gpio_leds_node,
+ .properties = spitz_green_led_props,
+};
+
+static const struct software_node *spitz_gpio_leds_swnodes[] = {
+ &spitz_gpio_leds_node,
+ &spitz_orange_led_node,
+ &spitz_green_led_node,
+ NULL
};
static void __init spitz_leds_init(void)
{
- platform_device_register(&spitz_led_device);
+ struct platform_device_info led_info = {
+ .name = "leds-gpio",
+ .id = PLATFORM_DEVID_NONE,
+ };
+ struct platform_device *led_dev;
+ int err;
+
+ err = software_node_register_node_group(spitz_gpio_leds_swnodes);
+ if (err) {
+ pr_err("failed to register LED software nodes: %d\n", err);
+ return;
+ }
+
+ led_info.fwnode = software_node_fwnode(&spitz_gpio_leds_node);
+
+ led_dev = platform_device_register_full(&led_info);
+ err = PTR_ERR_OR_ZERO(led_dev);
+ if (err)
+ pr_err("failed to create LED device: %d\n", err);
}
#else
static inline void spitz_leds_init(void) {}
--
2.45.2.803.g4e1b14247a-goog
next prev parent reply other threads:[~2024-06-28 18:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 18:08 [PATCH 00/10] ARM: pxa: use software nodes/properties for GPIOs Dmitry Torokhov
2024-06-28 18:08 ` [PATCH 01/10] ARM: spitz: fix GPIO assignment for backlight Dmitry Torokhov
2024-06-28 18:08 ` [PATCH 02/10] ARM: pxa: consolidate GPIO chip platform data Dmitry Torokhov
2024-06-28 18:08 ` [PATCH 03/10] ARM: pxa/gumstix: convert vbus gpio to use software nodes Dmitry Torokhov
2024-08-06 7:19 ` Arnd Bergmann
2024-08-06 16:58 ` Dmitry Torokhov
2024-08-06 20:36 ` Arnd Bergmann
2024-06-28 18:08 ` [PATCH 04/10] ARM: spitz: Simplify instantiating SPI controller Dmitry Torokhov
2024-06-28 18:08 ` [PATCH 05/10] ARM: spitz: Use software nodes to describe SPI CS lines Dmitry Torokhov
2024-06-28 18:08 ` [PATCH 06/10] ARM: spitz: Use software nodes to describe audio GPIOs Dmitry Torokhov
2024-06-28 18:08 ` [PATCH 07/10] ARM: spitz: Use software nodes to describe LCD GPIOs Dmitry Torokhov
2024-06-28 18:08 ` [PATCH 08/10] ARM: spitz: Use software nodes to describe MMC GPIOs Dmitry Torokhov
2024-06-28 18:08 ` Dmitry Torokhov [this message]
2024-06-28 18:08 ` [PATCH 10/10] ARM: spitz: Use software nodes for the ADS7846 touchscreen Dmitry Torokhov
2024-06-28 20:59 ` [PATCH 00/10] ARM: pxa: use software nodes/properties for GPIOs Arnd Bergmann
2024-06-28 21:08 ` Arnd Bergmann
2024-06-28 21:44 ` Dmitry Torokhov
2024-06-29 7:34 ` Arnd Bergmann
2024-06-30 8:07 ` Linus Walleij
2024-06-30 8:41 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240628180852.1738922-10-dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=arnd@arndb.de \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).