From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27A92C2BD09 for ; Fri, 28 Jun 2024 14:24:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8AZYUh/bH2pEs6r9pikO5qYYhnqHwYl81o+ZMEdyINk=; b=ApeQPCEWg62LJtkVbln+qdmD0e thGvdF0A5X/Q1paUUfjrNQrkHAoL8TqP6eOrgZaEdjMOcTrrccGYwrvqzb2EPoh94UsX6zRoxdyIL XjearKgfM0NV8whotCQfBUZ8b4pj9WXvAWA5/NGd5YIiQr+Ra4h1sOBzUOM5/NiFu8uClkTwbcZ4x 8/9iqPlcucx4webQuAtHHEtrwt6CCbqF5OuVehfWgheFNCWWnRNVg25yR92kECTjm5uuQjWogAhJJ /PWdqqZRXjbayS20wVciIJRcoTZIBlX/BdfB5lLF8U/nmact4wJ2fFD7/SOZjyOIQB7oWUtu0FPzU rwn6LUIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNCWd-0000000DzaS-12E8; Fri, 28 Jun 2024 14:24:31 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNCWS-0000000DzZh-46Ig for linux-arm-kernel@lists.infradead.org; Fri, 28 Jun 2024 14:24:22 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A616D6218E; Fri, 28 Jun 2024 14:24:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5925C116B1; Fri, 28 Jun 2024 14:24:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1719584659; bh=JAPwgChZN6CJo7VckcEiHT25iuUEOe0hF8TE18RBwTM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UI9boTjU+ZfPf/k4cPKLZzogtXABLgtB/P5hxo1i8NO7q+EwSk3Abk8c8iG+MGhYQ VqRGIwdZ5M5BO8buV84vBDUJ3A9dI2KyY3W1hhyS/upFhqu02X74rrxHt1wMxeA+rG 5asqB4U6iowhP39z9FCDBz6V8q/M7ocenyMJXgt0= Date: Fri, 28 Jun 2024 16:24:16 +0200 From: Greg Kroah-Hartman To: Dmitry Baryshkov Cc: Heikki Krogerus , Maxime Coquelin , Alexandre Torgue , Nikita Travkin , Neil Armstrong , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 0/7] usb: typec: ucsi: rework glue driver interface Message-ID: <2024062825-balancing-resigned-e383@gregkh> References: <20240627-ucsi-rework-interface-v4-0-289ddc6874c7@linaro.org> <2024062717-foster-document-eb2f@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240628_072421_223923_C47CD5EF X-CRM114-Status: GOOD ( 26.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 27, 2024 at 06:08:07PM +0300, Dmitry Baryshkov wrote: > On Thu, 27 Jun 2024 at 17:57, Dmitry Baryshkov > wrote: > > > > On Thu, 27 Jun 2024 at 17:54, Greg Kroah-Hartman > > wrote: > > > > > > On Thu, Jun 27, 2024 at 05:44:39PM +0300, Dmitry Baryshkov wrote: > > > > The interface between UCSI and the glue driver is very low-level. It > > > > allows reading the UCSI data from any offset (but in reality the UCSI > > > > driver reads only VERSION, CCI an MESSAGE_IN data). All event handling > > > > is to be done by the glue driver (which already resulted in several > > > > similar-but-slightly different implementations). It leaves no place to > > > > optimize the write-read-read sequence for the command execution (which > > > > might be beneficial for some of the drivers), etc. > > > > > > > > The patchseries attempts to restructure the UCSI glue driver interface > > > > in order to provide sensible operations instead of a low-level read / > > > > write calls. > > > > > > > > If this approach is found to be acceptable, I plan to further rework the > > > > command interface, moving reading CCI and MESSAGE_IN to the common > > > > control code, which should simplify driver's implementation and remove > > > > necessity to split quirks between sync_control and read_message_in e.g. > > > > as implemented in the ucsi_ccg.c. > > > > > > > > Note, the series was tested only on the ucsi_glink platforms. Further > > > > testing is appreciated. > > > > > > > > Depends: [1], [2] > > > > > > > > [1] https://lore.kernel.org/linux-usb/20240612124656.2305603-1-fabrice.gasnier@foss.st.com/ > > > > > > > > [2] https://lore.kernel.org/linux-usb/20240621-ucsi-yoga-ec-driver-v8-1-e03f3536b8c6@linaro.org/ > > > > > > > > Signed-off-by: Dmitry Baryshkov > > > > --- > > > > Changes in v4: > > > > - Rebased on top of Greg's tree to resolve conflicts. > > > > > > Nope, still got conflicts, are you sure you updated properly? Patch 1 > > > applied, but #2 did not. > > > > I feel stupid enough now. I rebased on top of usb-next instead of > > usb-testing. Let me spam it once again > > Hmm, I see what happened. I had a next+usb-next. Simple usb-next > doesn't contain changes from 9e3caa9dd51b ("usb: typec: ucsi_acpi: Add > LG Gram quirk") which this patch also modifies. I can rebase it on top > of your tree, but then we will have build issues once usb-linus and > usb-next get merged together. Ah, you need/want stuff from both branches, right? Then just wait until next week when my -linus branch will be in Linus's tree and then I will merge that into the -next branch. thanks, greg k-h