From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8DB5FC27C4F for ; Sat, 29 Jun 2024 04:57:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:To:From:Subject :References:Mime-Version:Message-Id:In-Reply-To:Date:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tYlBTwPn3+TIMd7izcUiVni6qR00lCI2TQ4vp279eEY=; b=WWE6qRt6lvBZNRRWqTnr4XCSd9 072warqHd6jrOTgGe0+wnA9EumWHhoWPJYIQ2V+t6asO3hDQIL/rwDLNTv9bSC6QrhxrRE9qa3BRb qVYmy5yik2S93hej3PqQUW6ofGwjpcG+O+/m2wHOiwFCI5/IcDyaN/IfGZBDaS65JzpOjJ1svz4+N BWpFel2HdPHNRewlQthFYqjpaWGWi5bOMKoEuwCVAIuYRTnWaGhZ0mtL87f05T+n3cFurdmL4n8ZH U56B6mAj3ehujE2uMenPmS0iQWtoEol5v6Sn8BR3lGyLcbQwLDjaxcXw2FwYMmMpqaQ/lp7HFNojZ QRTzHyRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNQ8x-0000000FsOw-11n7; Sat, 29 Jun 2024 04:56:59 +0000 Received: from mail-yb1-xb4a.google.com ([2607:f8b0:4864:20::b4a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNQ6p-0000000FrIv-28hF for linux-arm-kernel@lists.infradead.org; Sat, 29 Jun 2024 04:54:49 +0000 Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-df771b5e942so2192092276.2 for ; Fri, 28 Jun 2024 21:54:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719636886; x=1720241686; darn=lists.infradead.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=tYlBTwPn3+TIMd7izcUiVni6qR00lCI2TQ4vp279eEY=; b=pym4s30AOkNnWZPoAypWyRxOG1QVqJYyU55CQ2zRVEGuomXsgbNeR0aYBorHYPbTFX VnFFwM0GnxOe2c0wiGFklf3/0lfTEB/kMvxY11cfgT5DwEw7SXXRX4gKGqKoAItEgx5U 9OnyCO0COtCxpjbPv/DscMhZTGEB/XJyu+PMqhUEK5E/3DbjJavfpYB/7rVVDr5lCaWc HXXJEoZosUUcSx5iysmwAlOvqh316bs5WSH4b8J47l45XI69GBcHDATr/POuRrKGUB/O 55MvXNFiPyBQMpXe9oiGOvjpxhiEln4+kJ6ksU7Osj9HdyrcebtyciRtvetw3i8hKpXO J1ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719636886; x=1720241686; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tYlBTwPn3+TIMd7izcUiVni6qR00lCI2TQ4vp279eEY=; b=py8CXYmE56WBEkdTHSX8JP6DFWywrNhcmHQS102qaopyEni9mV0PyHuO8nkmzHgbNi 1lu6F4z41iWKH7PsUBfF4JqDtOl7ZSzMUeqU2Qnpl9d4e6i+lpRQFLqlCfkTWfAKJrP4 hVzR9VxOVAOihMGwxqSBj+AEEk3qVZioe5glPNVWPB89wOkCZhXmPZE0dY4WM5euVKDh OQCNduV11Af1fngCkTymnm+z3Vbuh5cblxCBzQQ0p8aQI/DB9+HhfpMzIAFZztW120tN lMAmPAG3FfqySaD/ZmOTAXcM9twc9IguknSYeyg4Ui4K3l1aekEXQBti2QPzL1nPa7G8 M0jw== X-Forwarded-Encrypted: i=1; AJvYcCW3fDpFlktlOV8ol823ZLXUCgxYf2z5JClw9q9z06tw1giEXkk5Ltkli6ajXeK7guhB6LYqh7v/9FKtdDReh7djjA0zKj4KBB/k+UPAOcmtUGEcNGE= X-Gm-Message-State: AOJu0YyCetWnV4ehRce8syHWOEdW5ztWFrT7CLQYuuuaZv/jQQqqNGMS riNPHDvWouCCRWs87pK5SYxecW4usJRVgWtWK23YwsrwbkCZ0zcDysCzsAdl3v7gZ1LsjBJau2G SzWB+TQ== X-Google-Smtp-Source: AGHT+IHlQ3lGTncxadGi4dpG3dzFKLZlZ5PNCPROQuxBGCgOp2Nj4DS8VTLWK+y0KutvPgqptznFewhLK3SB X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:f9fe:7acd:496e:4edb]) (user=irogers job=sendgmr) by 2002:a05:6902:1244:b0:e03:2bfe:40c9 with SMTP id 3f1490d57ef6-e036eadbdb8mr577276.3.1719636886110; Fri, 28 Jun 2024 21:54:46 -0700 (PDT) Date: Fri, 28 Jun 2024 21:53:39 -0700 In-Reply-To: <20240629045350.285243-1-irogers@google.com> Message-Id: <20240629045350.285243-18-irogers@google.com> Mime-Version: 1.0 References: <20240629045350.285243-1-irogers@google.com> X-Mailer: git-send-email 2.45.2.803.g4e1b14247a-goog Subject: [PATCH v3 17/28] perf stat: Use perf_tool__init From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Suzuki K Poulose , Yicong Yang , Jonathan Cameron , Nick Terrell , Nick Desaulniers , Oliver Upton , Anshuman Khandual , Song Liu , Ilkka Koskinen , Athira Rajeev , Huacai Chen , Yanteng Si , Sun Haiyong , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240628_215447_770484_09B72C2B X-CRM114-Status: GOOD ( 12.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use perf_tool__init so that more uses of struct perf_tool can be const and not relying on perf_tool__fill_defaults. Signed-off-by: Ian Rogers --- tools/perf/builtin-stat.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index d460c46f15fd..a3d77a55d17f 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -2271,15 +2271,6 @@ static const char * const stat_report_usage[] = { }; static struct perf_stat perf_stat = { - .tool = { - .attr = perf_event__process_attr, - .event_update = perf_event__process_event_update, - .thread_map = process_thread_map_event, - .cpu_map = process_cpu_map_event, - .stat_config = process_stat_config_event, - .stat = perf_event__process_stat_event, - .stat_round = process_stat_round_event, - }, .aggr_mode = AGGR_UNSET, .aggr_level = 0, }; @@ -2322,6 +2313,15 @@ static int __cmd_report(int argc, const char **argv) perf_stat.data.path = input_name; perf_stat.data.mode = PERF_DATA_MODE_READ; + perf_tool__init(&perf_stat.tool, /*ordered_events=*/false); + perf_stat.tool.attr = perf_event__process_attr; + perf_stat.tool.event_update = perf_event__process_event_update; + perf_stat.tool.thread_map = process_thread_map_event; + perf_stat.tool.cpu_map = process_cpu_map_event; + perf_stat.tool.stat_config = process_stat_config_event; + perf_stat.tool.stat = perf_event__process_stat_event; + perf_stat.tool.stat_round = process_stat_round_event; + session = perf_session__new(&perf_stat.data, &perf_stat.tool); if (IS_ERR(session)) return PTR_ERR(session); -- 2.45.2.803.g4e1b14247a-goog