From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4E4DC30659 for ; Sat, 29 Jun 2024 12:23:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hd/fN6JrXuuparzKe/1dgdm1z2pqZRQTyP5PJ9H207I=; b=tOcDLHmczZePva8ZpBdKnh5XHp wHx0VIp5+ydBvpQ15pWoq+H1AlOwFfYWwl9f1gzPL+lafnAxsdFVRqLZSG1y0gmhgYD2RZacbLa0h Xiwz9Dnm2BhcczAfqITHvsUoZ3Z+jZqR1GTiCgD2hu6+raDi8OZr2/wZSDwBkbX10JnvA45/PcWWj 2C+ofFIeKm9usZpLs4LivQzpMW+MnubQTGKTVnXh4CqNjHAmpORxOjFxi0zBn6MRQ0vKYr90GCIZM wxzwsIUkt8Q/iu/eCZUtS9FEKRvnPe6P1llN0ZVP5UrNZGriasIipykODFcEhNda7niDPSPApojty nvVcvgtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNX6u-0000000GNjz-0BNd; Sat, 29 Jun 2024 12:23:20 +0000 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNX6k-0000000GNis-08zO for linux-arm-kernel@lists.infradead.org; Sat, 29 Jun 2024 12:23:11 +0000 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-7082dd9bbf8so1196871b3a.1 for ; Sat, 29 Jun 2024 05:23:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719663789; x=1720268589; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=hd/fN6JrXuuparzKe/1dgdm1z2pqZRQTyP5PJ9H207I=; b=uuW73MStrHEE78FBOiVxCoMmIAREJni9lKll0WJqdhxcOda7wIAOp76DEsF4I7ugL8 SnHfOW2K3N5M/EbxdcyoDg6Lsj4wn3692912cVPIjpfxOSFKEXqKIXCz5q3Mhqh94TUm ZuC8T4yKvyFurdotEFwdG4691qFT4+4fb1Zo+f3yFSPBJJe/aq9T73tN//08laNRSSga ByWyuigpchVPYV6pV109X16vxUliPOMOkMDY222FsbOBhBz6DW4eO26rArn7B/JD+8j4 biNIlxmrxgwXImuQJTLuIQsCdfW/YQ5C3s2vzNBw61kbRHg2IVdY3IKojfl7sT6ygwMG ZVXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719663789; x=1720268589; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hd/fN6JrXuuparzKe/1dgdm1z2pqZRQTyP5PJ9H207I=; b=G4EYMFQ7FCqEopVdGAx7wnLdpZlaEIQfTetxJKP0sGE5Tgb2Nxuj2oZgjX2Eu+R2s0 KmUjJaePxQ3t+20S/SgwHm6ppMLk3cYX2IwFWDr2xqxPWAZFgPAYOukQM2YZrrBC8b8Z bLvxj7El62a1fkDiCm8zVaugR3LYcAqiphZNYHlkrSVVZ49UOqx7ck0eKNHOzBfzUWKn btCe39IJoVGvwFj3lCu+++vDzWRU9TAsudvAYrN9FJh9f7yMm3tc0yQ58gSkA3xJAuIR MYsitkasKre4LNPA7BzKfXKDfT3gSZ44QyNHgc7EFe6cR0tTYOibb+doQWmUrM5o6wyJ z0RQ== X-Forwarded-Encrypted: i=1; AJvYcCUobNG0uh+t7k0QqKy9Z8Q4rJZ3XrNYPzOdf73fRTo9voiuzmZQifBVOhMRvxa8UCwhheZONqxGn/hfB07hHD5TW9io58sGZ4r5QL8p2RpGmVr6I5k= X-Gm-Message-State: AOJu0Yzb3Xd33uZpNXIdi/3btC5/8d3nfS3HPmzwuvNi65fnCugH6RrZ M7nhWvVNiLsELaPZGE4l3enOVo5mXKdUwO0+7o2VX/bif0ExsROH4nY94VGjXQ== X-Google-Smtp-Source: AGHT+IEW0u5OjNVhFbntAWf/v7zidI2Sjsqla8PVFtRXPmZZ7xJh0N+dgrcQ2vSjwdtKDdMLAlmuaw== X-Received: by 2002:a05:6a00:2e18:b0:706:8066:5cd6 with SMTP id d2e1a72fcca58-70aaaf31a15mr736491b3a.32.1719663788507; Sat, 29 Jun 2024 05:23:08 -0700 (PDT) Received: from thinkpad ([220.158.156.249]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70803ecf70asm3179116b3a.102.2024.06.29.05.23.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jun 2024 05:23:08 -0700 (PDT) Date: Sat, 29 Jun 2024 17:53:01 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Liam Girdwood , Mark Brown , Krzysztof Kozlowski , Conor Dooley , linux-pci@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 01/10] PCI: imx6: Fix establish link failure in EP mode for iMX8MM and iMX8MP Message-ID: <20240629122301.GB5608@thinkpad> References: <20240617-pci2_upstream-v6-0-e0821238f997@nxp.com> <20240617-pci2_upstream-v6-1-e0821238f997@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240617-pci2_upstream-v6-1-e0821238f997@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240629_052310_257402_74AEC8B0 X-CRM114-Status: GOOD ( 18.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 17, 2024 at 04:16:37PM -0400, Frank Li wrote: > From: Richard Zhu > > Add IMX6_PCIE_FLAG_HAS_APP_RESET flag to IMX8MM_EP and IMX8MP_EP drvdata. > This flag was overlooked during code restructuring. It is crucial to > release the app-reset from the System Reset Controller before initiating > LTSSM to rectify the issue > > Fixes: 0c9651c21f2a ("PCI: imx6: Simplify reset handling by using *_FLAG_HAS_*_RESET") > Signed-off-by: Richard Zhu > Signed-off-by: Frank Li Reviewed-by: Manivannan Sadhasivam - Mani > --- > drivers/pci/controller/dwc/pci-imx6.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index 917c69edee1d5..9a71b8aa09b3c 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -1578,7 +1578,8 @@ static const struct imx6_pcie_drvdata drvdata[] = { > }, > [IMX8MM_EP] = { > .variant = IMX8MM_EP, > - .flags = IMX6_PCIE_FLAG_HAS_PHYDRV, > + .flags = IMX6_PCIE_FLAG_HAS_APP_RESET | > + IMX6_PCIE_FLAG_HAS_PHYDRV, > .mode = DW_PCIE_EP_TYPE, > .gpr = "fsl,imx8mm-iomuxc-gpr", > .clk_names = imx8mm_clks, > @@ -1589,7 +1590,8 @@ static const struct imx6_pcie_drvdata drvdata[] = { > }, > [IMX8MP_EP] = { > .variant = IMX8MP_EP, > - .flags = IMX6_PCIE_FLAG_HAS_PHYDRV, > + .flags = IMX6_PCIE_FLAG_HAS_APP_RESET | > + IMX6_PCIE_FLAG_HAS_PHYDRV, > .mode = DW_PCIE_EP_TYPE, > .gpr = "fsl,imx8mp-iomuxc-gpr", > .clk_names = imx8mm_clks, > > -- > 2.34.1 > -- மணிவண்ணன் சதாசிவம்