From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92BFCC3064D for ; Sun, 30 Jun 2024 16:13:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fhYNd6YI+Z5WjMzKTVCzzYrVGlFpZjqEpL+94ljYX4w=; b=Dwgo/CaJjBS25HLerDD7bfyktF X/8FpV12sEzqzkM7EIJPjAL9qr5LjclIwH2AkUo7L1ZJ04sZSii8gYfg5IFm/3aYree+8ic93fxkY 7d9NpS//g2Zg1Rfhyd4+LWUoAyf/flJEG1SvuSsuYP9hNFs15CalU5G715kdMK7JcGtLKngXjtWqw 5dJ5FfAK453Iygj9VJTC5+SGv6K1mcy+ahuS5/fgg7gWrdqxKvJwXesKGDFTSTz/BDFqj/vw4ldyf pwuNL9pbhZxuPVy37krC1EyGhDcLktOXhyGe4C7nTiuGkJegWl7QL7AkH3ftW+c4c4jclxr5/8GXW Bq16SL9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNxBQ-00000000gEp-2HeK; Sun, 30 Jun 2024 16:13:44 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNxBG-00000000gDa-1fcT for linux-arm-kernel@lists.infradead.org; Sun, 30 Jun 2024 16:13:35 +0000 Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-706b539fcaeso2236224b3a.0 for ; Sun, 30 Jun 2024 09:13:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719764013; x=1720368813; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=fhYNd6YI+Z5WjMzKTVCzzYrVGlFpZjqEpL+94ljYX4w=; b=EuZVVOcwj5gvCHRbM6CfxxHTFiMnhr03R6aHTs/tGBj3nJD743gX9y36EQF5QR97+w l0UA2jnc1QEcLLs0101tJC3fCVO7qqNUZ6bIcJQ1d3l92oXy+3PCkH05xCTQq85N6iIe WuxwvnwVXRR3xMKCiW0jrXMdYetvOl93E5JmJs1P8ZlbYBQdnoNn3pI8npO+ueeb4CXd pojf487YoAlW8TSOE24VCYpi0CPOtyVRgLH4SN9MRgLlD/evZXjulDvU6wDSMCD1Y15/ Vr2I6KAtZG12N8sqLlDrVeFKsw9Bz95TuHBG7JSdGcOsrRDcjYOSfA2To72/XNSrhxut 2Qlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719764013; x=1720368813; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fhYNd6YI+Z5WjMzKTVCzzYrVGlFpZjqEpL+94ljYX4w=; b=kA1qthEILSY/mD7GhXMN+dL+i2eyr8ukjh7teiisdx0uSmKnvX7acXIlT2vq5Z4nGT 7h5PgxCFtIYRuZXpurijUzscOUU5srxakDrF3HhWxdJ81opjvhfNWUKU5eItUG4cSC8O Es/R3ww2iAGKivhuPAucEZX2lmR1ay6nVwLKhivIoYk9QGv5RpH9xKpWBdy8W6LtL1qU rjSQ5zrcaQs/eKfizIJ/if8HNDi/pDd2SrCQt+zwmTBnziy+mNYZDGYqfB/I1pZi34J2 GOa3rab8SNyg9/gndoiflP2Ir8uGyBvxtTwLRyd0BQuWNs8t7c5Xcrvvsoyi8zEdT0wY RMPQ== X-Forwarded-Encrypted: i=1; AJvYcCV9rPXFRmhkYgR3jfVLoHIiseIW0pIOdzHVaKBJLyZ2Q2ZQg1XSgmxYSteVRLK9tirdRvakRaovbWPK3cyuC6mZi2LzqCrg4MHUzqIVLoo0FOs+tJA= X-Gm-Message-State: AOJu0Yy98RzE2BqmY703wSPAtDNz0ZjvK/pPhpXnlIuYbIK0thVs/gpw L3qL9Z/4k21p59d0w4ap3ekHkdWrrGruDDAQKU90KxlHp9pHbWS1hp6dDiCXIQ== X-Google-Smtp-Source: AGHT+IFBjjMwaBXy0t3lI3KWMbWd86l8kT3eRQj1Z0/ea7k0vDsO6nYMvezqFZjKxlo1m8VkwrYDxA== X-Received: by 2002:a05:6a20:daa1:b0:1be:6390:33ee with SMTP id adf61e73a8af0-1bef5fcb66cmr5933847637.0.1719764013349; Sun, 30 Jun 2024 09:13:33 -0700 (PDT) Received: from thinkpad ([220.158.156.215]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-708048935c0sm4839644b3a.186.2024.06.30.09.13.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Jun 2024 09:13:32 -0700 (PDT) Date: Sun, 30 Jun 2024 21:43:25 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Liam Girdwood , Mark Brown , Krzysztof Kozlowski , Conor Dooley , linux-pci@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 06/10] PCI: imx6: Improve comment for workaround ERR010728 Message-ID: <20240630161325.GC5264@thinkpad> References: <20240617-pci2_upstream-v6-0-e0821238f997@nxp.com> <20240617-pci2_upstream-v6-6-e0821238f997@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240617-pci2_upstream-v6-6-e0821238f997@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240630_091334_472699_E20F87E0 X-CRM114-Status: GOOD ( 15.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 17, 2024 at 04:16:42PM -0400, Frank Li wrote: > Improve comment about workaround ERR010727 by using official errata > document content. > It is useful to provide a link to the errata document in the commit message. > Signed-off-by: Frank Li > --- > drivers/pci/controller/dwc/pci-imx6.c | 22 +++++++++++++++++++--- > 1 file changed, 19 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index 6f68bee111029..6e3ac3fc33745 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -715,9 +715,25 @@ static int imx7d_pcie_core_reset(struct imx_pcie *imx_pcie, bool assert) > return 0; > > /* > - * Workaround for ERR010728, failure of PCI-e PLL VCO to > - * oscillate, especially when cold. This turns off "Duty-cycle > - * Corrector" and other mysterious undocumented things. > + * Workaround for ERR010728 (IMX7DS_2N09P, Rev. 1.1, 4/2023): > + * > + * PCIe: PLL may fail to lock under corner conditions Initial VCO Missing full stop after 'conditions'? - Mani -- மணிவண்ணன் சதாசிவம்