From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7652FC2BD09 for ; Mon, 1 Jul 2024 14:47:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fqZKaa7knZJXNP6mJOXDbyi3HWGzJLxACProsCsB+Hw=; b=jPsr7KmhnqPpL1H+e9i3o1w9yX FIjYOFCNv3Z9j+twxNqBjaAVydzauAwolpB40Q5L+dCxqf7Nt7vXB6TeWbcEGQIvx0lBP+AM4/ajx RxY0aUWXkfoerdj8lwi0/Z7aJOjtI7LlB2ix+6Co3FnlfX7X9SXs/bV7T/5K/4IEzqsu7AeSa+Pfw 9ZrgiLq/VQaUrMvEFgeElG+n3pNU+N24q0Ayf76tSrgPLAuCwxlddV98eMFQb8cK70FTTYK5lWgH+ LnzKq6+W55cbLOj5Rjrr/QgZKVPUsMea2tIEwneuGA8QkpMRp2d/HktuathBtZVaqkbRhgbttZ8OM sFJr+nzw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOIJU-00000003mHI-3VQ1; Mon, 01 Jul 2024 14:47:28 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOIJK-00000003mE2-0uoI for linux-arm-kernel@lists.infradead.org; Mon, 01 Jul 2024 14:47:19 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 54DB06146C; Mon, 1 Jul 2024 14:47:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19279C116B1; Mon, 1 Jul 2024 14:47:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719845237; bh=j8XiGvWJ8XtpnCWRcFn+uOZrSEgcHJ4ERD16wxYfS5o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FVQ2Xn9kH+d78Fm5CfMWf8q3qpIv2BGjxHUtI+unfUGoNgi5oahhz2O+ZLNwpsm3y 7MpTgmNZBmUlogjGIBphXcbZmQB2ZSJjhRTYLQxfMMAy+oHPUtkZpL7iwOhdFfzmbK n1bCvfSRhwTMAPVusGkJ/8/kX5SjCMeUA3meUEjLau5rkkUNt30OwQ36dKpL3SYV3h 26cwDjCIGZeEs6cV+8cTYJjnm4GL/LFvr0rYbiG0ncgxrfa5gok8llXvBIpXudV5dJ XVbYfrHZLx7RKIY5EHKx4ndZpCwMVfV/I1IV3z3yh0L0wkYT43a8oQMELa6i6doLuf pFngdlhYfuAtQ== Date: Mon, 1 Jul 2024 15:47:12 +0100 From: Conor Dooley To: Andrei.Simion@microchip.com Subject: Re: [PATCH v3 3/3] dt-bindings: eeprom: at24: Add Microchip 24AA025E48/24AA025E64 Message-ID: <20240701-majorette-briskness-696746f3fde1@spud> References: <20240628080146.49545-1-andrei.simion@microchip.com> <20240628080146.49545-4-andrei.simion@microchip.com> <20240628-plunder-wackiness-72b0acf3624b@wendy> <04278bf9-fb5f-4592-8edd-a45332fed24a@microchip.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="woyu5TzAIRUeYkBV" Content-Disposition: inline In-Reply-To: <04278bf9-fb5f-4592-8edd-a45332fed24a@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240701_074718_459253_3711B856 X-CRM114-Status: GOOD ( 26.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, robh@kernel.org, conor+dt@kernel.org, arnd@arndb.de, alexandre.belloni@bootlin.com, devicetree@vger.kernel.org, gregkh@linuxfoundation.org, brgl@bgdev.pl, claudiu.beznea@tuxon.dev, Conor.Dooley@microchip.com, linux-i2c@vger.kernel.org, krzk+dt@kernel.org, linux-kernel@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --woyu5TzAIRUeYkBV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 01, 2024 at 02:37:57PM +0000, Andrei.Simion@microchip.com wrote: > On 28.06.2024 12:09, Conor Dooley wrote: > > Hey, > >=20 > > On Fri, Jun 28, 2024 at 11:01:46AM +0300, Andrei Simion wrote: > >> Add compatible for Microchip 24AA025E48/24AA025E64 EEPROMs. > >> > >> Reviewed-by: Connor Dooley > > ^^ ^ > > There's no way that I provided a tag with my name spelt incorrectly > > given I use a macro to insert them. Please copy-paste tags or use b4 > > to pick them up, rather than type them out yourself. > >=20 > >> Signed-off-by: Andrei Simion > >> --- > >> v2 -> v3: > >> - commit subject changed to reference Microchip 24AA025E48/24AA025E64 > >> - drop the pattern: mac02e4$ and mac02e6$ and a-z from regex > >> - add these two devices down at the bottom > >> - added Reviewed-by > >> > >> v1 -> v2: > >> - change pattern into "^atmel,(24(c|cs|mac)[a-z0-9]+|spd)$" to keep si= mpler > >> --- > >> Documentation/devicetree/bindings/eeprom/at24.yaml | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Docu= mentation/devicetree/bindings/eeprom/at24.yaml > >> index 3c36cd0510de..699c2bbc16f5 100644 > >> --- a/Documentation/devicetree/bindings/eeprom/at24.yaml > >> +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml > >> @@ -132,6 +132,10 @@ properties: > >> - renesas,r1ex24128 > >> - samsung,s524ad0xd1 > >> - const: atmel,24c128 > >> + - items: > >> + - const: microchip,24aa025e48 > >> + - items: > >> + - const: microchip,24aa025e64 > >=20 > > I don't think this patch works, the schema has a select in it that only > > matches ^atmel,(24(c|cs|mac)[0-9]+|spd)$. You either need to have these > > fall back to an existing compatible (iff actually compatible) or else do > > something like: > > diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Docum= entation/devicetree/bindings/eeprom/at24.yaml > > index 699c2bbc16f5..4d46b8c5439d 100644 > > --- a/Documentation/devicetree/bindings/eeprom/at24.yaml > > +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml > > @@ -18,7 +18,9 @@ select: > > properties: > > compatible: > > contains: > > - pattern: "^atmel,(24(c|cs|mac)[0-9]+|spd)$" > > + anyOf: > > + - pattern: "^atmel,(24(c|cs|mac)[0-9]+|spd)$" > > + - enum: ["microchip,24aa025e48", "microchip,24aa025e64"] >=20 > If I use your solution (and drop both items: const) -> it is selected the= compatible but does not match anything. My intention was that you added my diff to your existing patch. Thanks, Conor. --woyu5TzAIRUeYkBV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZoLBbwAKCRB4tDGHoIJi 0iuxAQD3nivIzehKWwsPswITcQpTaCzYeOEfQArdjN9Yfifw5AEArpZaFKJXjqW+ 8ceF7VlRJqpYqfhZKKfZxBwFc+fQcAQ= =A15X -----END PGP SIGNATURE----- --woyu5TzAIRUeYkBV--