From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC070C3065A for ; Mon, 1 Jul 2024 07:47:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xSzCTTdVM/tcdktgKnj2I7uwAMajiojP6tk7tkVB+GU=; b=bXNFWwUaXAxk2hCPDoEZRIxUgP w4eBADfJmPbrtxOgQtFj8cIdqwz6Akks1Upttydv8THXJpHK9jjUvy8+4rxVe/JJ6T33pk2CpCQ8j Tm9Qnxv9Hp0hgo6ItKw4aXs8AnBCcTzLkAsEU6/yubB+nSWJleW0Y7yseIoa5K4V6UoznhnyHyOhn Qe+zqftYJPXZkv4AY0q1yaNKE5HyHaPRFMgwRzr5DxdTYAibeFdvS8ubBbGVykwICK7YK8izxHDbo cSvZ9BN6htvgOwD8oYsBiVYimre/IEpakE3iAvatMRhiV0Ws9GLxNftz7onPXrzKKUXAJpW7YHBtS VNBIAewQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOBlD-000000027Qd-2PD1; Mon, 01 Jul 2024 07:47:39 +0000 Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOBl2-000000027No-2HyE for linux-arm-kernel@lists.infradead.org; Mon, 01 Jul 2024 07:47:30 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id BDF99C0009; Mon, 1 Jul 2024 07:47:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1719820043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xSzCTTdVM/tcdktgKnj2I7uwAMajiojP6tk7tkVB+GU=; b=nOwrn1G/VVmjuD7GQhpAhtIOYD4Tk851VLzUI1ZTims5TqG4tZlpA7uSctgxtqbkI2K0Xj Nt7nlclZz9+hXabDud4SgSZrf1t0kwzdWf+0Of1xY8LXrf7cx4G4A3+uzneL3wK2ZwZS/z G6fOkCA5hspB4XuvatPoJSSf6RUlWv7PbcrhNxpDANZ2+l4lbXcGIPOkOiBOypxLqIANp+ cR4r9RisDQab29H9k/zdkGFuwjlX9I6h4JU2gyDKM4IEyogbotiWf9VaNa0YGXMfuxBkSa zlt0sXdai9zB1+kvOGYnBomUFCe57yzDpOCXQ2X0hYLWj6dslwC+Nj9kHyH5pg== Date: Mon, 1 Jul 2024 09:47:19 +0200 From: Herve Codina To: Herve Codina , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Qiang Zhao , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Jaroslav Kysela , Takashi Iwai , Christophe Leroy Cc: alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thomas Petazzoni Subject: Re: [PATCH 10/10] ASoC: fsl: fsl_qmc_audio: Add support for non-interleaved mode. Message-ID: <20240701094719.14f2eda3@bootlin.com> In-Reply-To: <20240620084300.397853-11-herve.codina@bootlin.com> References: <20240620084300.397853-1-herve.codina@bootlin.com> <20240620084300.397853-11-herve.codina@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240701_004728_745003_D90CAEDD X-CRM114-Status: UNSURE ( 9.90 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Thu, 20 Jun 2024 10:42:57 +0200 Herve Codina wrote: ... > +static bool qmc_audio_access_is_interleaved(snd_pcm_access_t access) > +{ > + switch (access) { > + case SNDRV_PCM_ACCESS_MMAP_INTERLEAVED: > + case SNDRV_PCM_ACCESS_RW_INTERLEAVED: > + return true; > + default: > + return false; > + } > +}; > + The ';' at the end of the function should not be here and will be removed in the next iteration. Also, this function will be changed to --- 8< --- static bool qmc_audio_access_is_interleaved(snd_pcm_access_t access) { switch (access) { case SNDRV_PCM_ACCESS_MMAP_INTERLEAVED: case SNDRV_PCM_ACCESS_RW_INTERLEAVED: return true; default: break; } return false; } --- 8< --- Hervé