From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28856C2BD09 for ; Mon, 1 Jul 2024 10:27:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9c+PJ9qplCm9e71aGNj46Xv63qyZzWb3k6nVOLS8TaI=; b=rHZMLwg48C5hoRnuObJRbrI0Y8 PeuU7N1Nx/ecsAI+QoFwHCwERghsmRiczpG1ERBNTfqWq7TqpzcSLic+Wi9QKgxGb9VTBsfmcI7I4 uVockLtm9JYHfKGU/lfizzey8FQvL+H+MaArg2ell3EDnXoFpxGOXn1QIhZiH/uFqIo4KIiPLfScx rycewj2O3lXh+y2W9+G8Edttt426BjIUxz2NqkmvA8P9VW5KM75JgqPOgE5xT8995cc8VtMOSQwhJ gZPxL0RG7OwutU0q32o9r8QsxwR11crbpguXtnm483ZjKM9SA/iQrVKl6WbKhNw8Ln7yXKxyt5YRd duT+CaTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOEFW-00000002fRq-3f9H; Mon, 01 Jul 2024 10:27:06 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOEFO-00000002fPn-0QV3 for linux-arm-kernel@bombadil.infradead.org; Mon, 01 Jul 2024 10:26:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9c+PJ9qplCm9e71aGNj46Xv63qyZzWb3k6nVOLS8TaI=; b=qkH4nFpE/dI8n+JWCA7Fo5j8FJ jRvlopf2P+DW8DDyAXEeSzskDa9j9Qg8SY9qtBVV9GF7xrUE2lFUNHClTST6qXRFV1XUupHU40uKC T5b7fqy5JpIUiDz6yALapXj82qHS+1TUBgcFd9+ZTJbQ9pGYxRdXmBobO6b0SMi4nJZJlsVI46KKM R9IgSdvaTtkaOCbYPgWJWaSYj6PS9RmK+tDlyvLDQR4+FneoIDA2+7lLaBQrBlIusp/Jjke05T+Nl cP7vt7lx6N1s9lASCOk9v9W+lVpeMMty2ES0+JV5dLbeEFyfU040ecc1agZKovqblwSgR6ygbZ3UY jsd/UG7A==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOEFD-00000009dXr-1eTt; Mon, 01 Jul 2024 10:26:48 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 60C70300694; Mon, 1 Jul 2024 12:26:44 +0200 (CEST) Date: Mon, 1 Jul 2024 12:26:44 +0200 From: Peter Zijlstra To: Adrian Hunter Cc: Ingo Molnar , Mark Rutland , Alexander Shishkin , Heiko Carstens , Thomas Richter , Hendrik Brueckner , Suzuki K Poulose , Mike Leach , James Clark , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, Yicong Yang , Jonathan Cameron , Will Deacon , Arnaldo Carvalho de Melo , Jiri Olsa , Namhyung Kim , Ian Rogers , Andi Kleen , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH V8 01/12] perf/core: Add aux_pause, aux_resume, aux_start_paused Message-ID: <20240701102644.GA20127@noisy.programming.kicks-ass.net> References: <20240628065111.59718-1-adrian.hunter@intel.com> <20240628065111.59718-2-adrian.hunter@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240628065111.59718-2-adrian.hunter@intel.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 28, 2024 at 09:51:00AM +0300, Adrian Hunter wrote: > Add aux_paused to struct perf_event for AUX area events to keep track of > the "paused" state. aux_paused is initialized to aux_start_paused. > @@ -798,6 +810,9 @@ struct perf_event { > /* for aux_output events */ > struct perf_event *aux_event; > > + /* for AUX area events */ > + unsigned int aux_paused; > + > void (*destroy)(struct perf_event *); > struct rcu_head rcu_head; > Should this not be part of struct hw_perf_event for whatever hw event implements this AUX stuff? In fact, I would expect PERF_HES_PAUSED or something to go in perf_event::hw::state.