From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8CD11C2BD09 for ; Mon, 1 Jul 2024 19:17:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kl9ft2uX8PhOwtiNciyQ6cQ/gcAfrKUue9rrhmLdiMw=; b=bVgtTiLtvlWGB2qI5ZCkrh+vfK gFcLJbIHPYGacqEhAmPfLfRrpclJDxS5NF1KFGDmPsNcMz1XvRetRJe7Y6+UnPsHlNPivLI/ErF40 CiqECdyTSb+ifZR3fVrpbndpTODMJf8jkVW6NY4e7lXQ7m3QIOA9auFcKSbgzFZQCfl1n4miGoJZX jmH5CwL/+sfdnMAdnR0JYMPQI/R1+a+mEajwoLjfU3AWl4PMN6WAZWdWqyekJSJvNVL2TKw4rqFn3 zQDoxczJebDR+ar1FmB1MpNItVBtFhsoMXO4Jqor25zUaJBymeYDPteq6dyECItTCfm3vAUmTKoCm Pf+t/25g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOMWf-00000004bpO-4Axz; Mon, 01 Jul 2024 19:17:22 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOMWV-00000004bnn-2AvZ for linux-arm-kernel@lists.infradead.org; Mon, 01 Jul 2024 19:17:12 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 06BB261701; Mon, 1 Jul 2024 19:17:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2C46C116B1; Mon, 1 Jul 2024 19:17:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719861430; bh=AoIVWqz91vGUZX9FKk7V1op2U0B1NwvcnbHXWJ2o/hA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pqIrUluPT1UWvLnTu/ofCqje3KgpSshEKH9YTxfcWjGsQ+FoRqrgxOrRpxSLzMP5J L4khWZbRPjZ+FeAKj0pECCvq31wUkU8i2ehljZ4Iy9hhd6+XD3Nq8f6oe6I0xHU6SK UcoeABhitIIdh3of4qz2O51iy19/bAkRVvigTjJu9G1zKXiBkDlliZnhjdTm/PxINC iCzTOhIuStvjPuteabc7pKksDQV+rCsesd5nzuBcNngH0frRhqhxzHAKHE7Mp51LGe Jjr3vH0v9RnDqSu4n1Ah+neOubmPEHxt/u/KSICVB2jUcto9xe3iDsW4tzEGtpPg3h l2ZtoN69K6nkQ== Date: Mon, 1 Jul 2024 12:17:10 -0700 From: Kees Cook To: Linux regressions mailing list Cc: Yanjun Yang , linux-arm-kernel@lists.infradead.org, Mark Brown , rmk+kernel@armlinux.org.uk, Ard Biesheuvel , akpm@linux-foundation.org, ben@decadent.org.uk, Wang Kefeng Subject: Re: [PATCH] ARM: Remove address checking for MMUless devices Message-ID: <202407011216.E1DCF4BF@keescook> References: <20240611100947.32241-1-yangyj.ee@gmail.com> <6767f6e1-f7b7-4b3e-8173-32f1472f56d6@leemhuis.info> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6767f6e1-f7b7-4b3e-8173-32f1472f56d6@leemhuis.info> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240701_121711_619118_BF7332DF X-CRM114-Status: GOOD ( 15.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 01, 2024 at 01:54:21PM +0200, Linux regression tracking (Thorsten Leemhuis) wrote: > On 12.06.24 03:25, Yanjun Yang wrote: > > Apologies for not CCing the relevant maintainers in my previous email. > > > > On Tue, Jun 11, 2024 at 6:09 PM Yanjun Yang wrote: > >> > >> Commit 169f9102f9198b ("ARM: 9350/1: fault: > >> Implement copy_from_kernel_nofault_allowed()") added the function to check > >> address before use. However, for devices without MMU, addr > TASK_SIZE > >> will always fail. This patch move this function after the #ifdef > >> CONFIG_MMU statement. > > What happened to this fix regression for a 6.9 regression? From here it > looks like it fell through the cracks, but I might be missing something. This patch can be sent through rmk's ARM patch tracker, but if it's urgent, I could take it via my tree? It has Ard's Ack. -- Kees Cook