From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4DD0C3065A for ; Mon, 1 Jul 2024 18:05:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XOlbe3cjIs5VfqoTevxb/lyiB5oysEcwOTb18oKCk9E=; b=EGqMx7GmL2hZ6hxAIsFc3jmIVp BS7VkLnZ5Ms9jUz30VchciSYtIQSWAfiHnGarfhRynDuW5dVd+wlm2CvCvtO7SmZmtdU/HE2KT5xl hX3cBx1KiaVg7s6Nsl9KxTwgjSmdx/EvwK2j/BCS6d+Q06AIW0b3jZ5OXHOEPUs7YaWjfuCsK10od qpXdDwLctN68TqO2/ZJyNuclHRP5v3Yjv6KyyBbnKcbUsDJfayFCWZ2G+inBBcrZKtzEEADCyE/+8 k3IHlxOAf1xkV3xX8ZmxOqoL2lsDCUKcrqn+9sqmOGqQzx407geqBA4a/slaokG/TzGANQhdvY8CC 3L6UIRXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOLPN-00000004ON9-2jTT; Mon, 01 Jul 2024 18:05:45 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOLPC-00000004OLK-0Kk6 for linux-arm-kernel@lists.infradead.org; Mon, 01 Jul 2024 18:05:36 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5B47FCE169C; Mon, 1 Jul 2024 18:05:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84726C116B1; Mon, 1 Jul 2024 18:05:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719857131; bh=iDKcXdBsS0vt/IYVHXKzFucwalNTCdXiNqGYDXCF2EE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LwUo8O7I2p+o8H5bGeA2nYxR8MBNh6pCtsk9imynvRE1mdJdqYDZmiPNIsZ70+WBW KZoKPSGaL5Jq34Cx56Fo5A33UZ2YTwGsbF8bj/izaYn2v00xCSbqAbqVsa55tJEgaU Hl53X302C8z+mqXPF4eIW7oNdP7bZI72rjfIbNs69AtyVs2kk/11Go1AZEzcJSlkyx iVvz3wB+3Ieg0kIIqnk0iiFhqKLKCQUPAaOjGdmgAS43PYj1NhJLeb5eG4OyrP5Jh7 5IkuoLTxRp96xdJPkNH5/+HuSCLR2C/MfVaEP2aQ01BL8py1NWtH5LOcZTfNrzYObO c3/7GyKz5vltQ== Date: Mon, 1 Jul 2024 12:05:30 -0600 From: Rob Herring To: Andrew Lunn Cc: Zoltan HERPAI , gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, krzk+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/3] ARM: dts: marvell: add support for D-Link DNS-320L Message-ID: <20240701180530.GA176622-robh@kernel.org> References: <20240629113450.127561-1-wigyori@uid0.hu> <20240629113450.127561-3-wigyori@uid0.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240701_110534_322799_9765E84F X-CRM114-Status: GOOD ( 16.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jun 29, 2024 at 04:34:25PM +0200, Andrew Lunn wrote: > It has been a long time since i reviewed a kirkwood DT > description. Also, best practices have changed, so the example you > copied is probably doing things which today would be classed as wrong. > > > +// SPDX-License-Identifier: GPL-2.0-or-later > > It is typical to use a dual license now: > > // SPDX-License-Identifier: (GPL-2.0+ OR MIT) Yes, but more importantly, they should be consistent... GPL-2.0+ in favor of GPL-2.0-or-later > > However, if this is mostly Sunke Schluters work, you probably cannot > change the license without his agreement. > > > +/* > > + * Device Tree file for D-Link DNS-320L > > + * > > + * Copyright (C) 2024, Zoltan HERPAI > > + * Copyright (C) 2015, Sunke Schluters > > + * > > + * This file is based on the works of: > > + * - Sunke Schluters > > + * - https://github.com/scus1/dns320l/blob/master/kernel/dts/kirkwood-dns320l.dts > > + * - Andreas Bohler : > > + * - http://www.aboehler.at/doku/doku.php/projects:dns320l > > + * - http://www.aboehler.at/hg/linux-dns320l/file/ba7a60ad7687/linux-3.12/kirkwood-dns320l.dts > > + */ > > + > > +/dts-v1/; > > + > > +#include "kirkwood.dtsi" > > +#include "kirkwood-6281.dtsi" And these are GPL-2.0-only, so this one should match. Rob