From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64D51C3065A for ; Mon, 1 Jul 2024 19:49:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=z31e35+hwRIGrqqwM2htxL+R9Pjm+VucVQVl2mXo8lo=; b=y2IWCcqvUzwFxb Ie8ZCchPI69Z5sxYY3/cc4cDXlNLtd1l7GfA8UNNNXRRHF6XH2XTorLgDinrNHqAJCBzJNpjUIrqR NQlqerGLwb9iyVazsCCk7YR4cJDoiPy85ujdgvhZi0dAsyiJa5lAyUdy58y/C2i3vfsMsHoA0w4+R PVltWQXmtihfyV71HJaIEq5qxHHhq8BqRNBDZfEn/32/hhp1bO55X5deAxzehcl2raFnTyMOpY85h qbu7B6/rDiiCYd+AqjKDojZ9T5a4tIJFgP+Oob1bZtcHLkm0u3yQVRkjyDDPQUmPBOgqm07iHlYym nsSLxDd/on6X4XP2Inow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sON1Z-00000004gpg-3GKJ; Mon, 01 Jul 2024 19:49:17 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sON1N-00000004glM-2XJ9; Mon, 01 Jul 2024 19:49:06 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 03F2F61799; Mon, 1 Jul 2024 19:49:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3894AC32786; Mon, 1 Jul 2024 19:49:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719863344; bh=zQLlNeL1vEPNYFTUeDSkHfau4N62hdB+0K+910LcGDQ=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=izRjTP7fn/CmHJ8zsepzQCFxuspZHpEY4VgfgjR53mrr5p9EY3+7ZTr7GLzd/cGYl 9VX0nxhj/ukhlI9kVaENGku38ir6u57ZepHtP6ULabOv74DjOgqEwrunVluJwd2onf 0y1xbLaXMEoYrdfRPP+60R/uiRgpWINoYZsRk1hxd+QcK/Oi+gUnhNilUC1P/PuoSd 6MuBcKlQOF2xg6AsKEZY/omYk/fKKM+vhvxJV3OA82OQSahRsqEr77CqshDbrbqx+g cyWApNcp+SBy2Yuspcct1eEy7XFvW4Z+ca2KLWMzcshKpGcHbY4Udb2c1Gv2qfa+3t fhqsetWXDtS+Q== Date: Mon, 1 Jul 2024 14:49:02 -0500 From: Bjorn Helgaas To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, Florian Fainelli , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v1 2/8] PCI: brcmstb: Use "clk_out" error path label Message-ID: <20240701194902.GA14422@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240628205430.24775-3-james.quinlan@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240701_124905_703099_E5BEE45A X-CRM114-Status: UNSURE ( 6.44 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 28, 2024 at 04:54:21PM -0400, Jim Quinlan wrote: > Instead of invoking "clk_disable_unprepare(pcie->clk)" in > a number of error paths. It's nice if the commit log is readable by itself, without reading the subject line as the first line of the commit log. Same way a title is not directly part of an article/essay/book itself.