From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B603CC3064D for ; Tue, 2 Jul 2024 07:18:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+z62KHHlRo81lc/GzMxOBVeFJJ1sDDAwxEhWEQ2FcLM=; b=bFjOeSHBysTi6/7zF/nnhl1v8R +EhGDo5geEwQkdAeg4kbo/fdV5QL8H6J6BfPOucdRQGD61atB1csAmKPRHa/ApBqTRGypOFLZB74s x95kZ52uby9yTRZ+QDwRt40b8xmhdrKwFhtKtodMGyWV4vDvpatLJHrgcw6h7aiShiPvraBaPcs3r gY5SgiN3z2JbI/25WMlFGh6zPwSIpfnjpfSAG4E0OAETDpcfq89KV7fS3fH+1zDFHBzyRmx1/4Dgd iLIkUj8lragvPrEJ4MWCUvaYz374DA8/oPD5fUurfUInIiU0Atw1LoOROa4RLLpuElMHElWuSWP7Q mKD10L7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOXm3-00000005qCo-1GNa; Tue, 02 Jul 2024 07:17:59 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOXls-00000005qAI-1dDj for linux-arm-kernel@lists.infradead.org; Tue, 02 Jul 2024 07:17:49 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 561B9CE069A; Tue, 2 Jul 2024 07:17:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 662F4C116B1; Tue, 2 Jul 2024 07:17:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719904665; bh=+ajUOihIy3DbqQQu8hvDT/sgpxHbxvCFzk5+TeNikrw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vJSZf6exkhCWicKbl/kX3AwxGqEYrAXUOvp7T+6rCc8jICWjWzyTzQuCmcncO1IdN ViBEHaNrDIwxLx9ZbztKsvJrr3eKpcJFTcqMrHAD3fv8DAykFrkMUchICFN96brT8Q SHVZnQrbvKKHSQ89UwUdSeWfgoSNQlYB8UD9hVsXNhUZzspTsBTQLW4A8PPdo7+Iqk NEiPQRGSGMcPQ24FBr5yuNuxgDC/cV7+jNt22PpXDvTwvzLonK3m4x45uI8VQORcUL 4lhQWWwWSPc+xhmgPh3JbRx1As0KPAPGjBvAiyKVPflfjXL6LSvdtYhiTdDRyWSBi0 GYaz5ZZITQ7LA== Date: Tue, 2 Jul 2024 08:17:39 +0100 From: Simon Horman To: Lorenzo Bianconi Cc: netdev@vger.kernel.org, nbd@nbd.name, lorenzo.bianconi83@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, conor@kernel.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, upstream@airoha.com, angelogioacchino.delregno@collabora.com, benjamin.larsson@genexis.eu, rkannoth@marvell.com, sgoutham@marvell.com, andrew@lunn.ch, arnd@arndb.de Subject: Re: [PATCH v4 2/2] net: airoha: Introduce ethernet support for EN7581 SoC Message-ID: <20240702071739.GA606788@kernel.org> References: <56f57f37b80796e9706555503e5b4cf194f69479.1719672695.git.lorenzo@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56f57f37b80796e9706555503e5b4cf194f69479.1719672695.git.lorenzo@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240702_001748_638031_84601F17 X-CRM114-Status: UNSURE ( 9.23 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jun 29, 2024 at 05:01:38PM +0200, Lorenzo Bianconi wrote: ... > diff --git a/drivers/net/ethernet/mediatek/airoha_eth.c b/drivers/net/ethernet/mediatek/airoha_eth.c ... > +#define INT_IDX4_MASK \ > + (TX8_COHERENT_INT_MASK | TX9_COHERENT_INT_MASK | \ > + TX10_COHERENT_INT_MASK | TX11_COHERENT_INT_MASK | \ > + TX12_COHERENT_INT_MASK | TX13_COHERENT_INT_MASK | \ > + TX14_COHERENT_INT_MASK | TX15_COHERENT_INT_MASK | \ > + TX16_COHERENT_INT_MASK | TX17_COHERENT_INT_MASK | \ > + TX18_COHERENT_INT_MASK | TX19_COHERENT_INT_MASK | \ > + TX20_COHERENT_INT_MASK | TX21_COHERENT_INT_MASK | \ > + TX20_COHERENT_INT_MASK | TX21_COHERENT_INT_MASK | \ Hi Lorenzo, One more thing that I forgot to note yesterday: the two lines above appear to be duplicates of each other. Flagged by Coccinelle. > + TX22_COHERENT_INT_MASK | TX23_COHERENT_INT_MASK | \ > + TX24_COHERENT_INT_MASK | TX25_COHERENT_INT_MASK | \ > + TX26_COHERENT_INT_MASK | TX27_COHERENT_INT_MASK | \ > + TX28_COHERENT_INT_MASK | TX29_COHERENT_INT_MASK | \ > + TX30_COHERENT_INT_MASK | TX31_COHERENT_INT_MASK) ...