From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A70BC3064D for ; Tue, 2 Jul 2024 10:54:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FFKtnI2q1ra5byYWBYSkEjGKg3iTXTwdCmTbKWtB15E=; b=2zQyVhrbHySlzudNYqqAdyC/od Epe8fZjh4c2bvyvMCRcYo5foG6NRVWGcXixLG9egxvoxHgYRE+8cbQUNLU90rz9SetDwKYEaTCq79 1yIuUraY7KOL6KLYefsP2GyfyqgPXqNSBn3PbrTrXNFss2Ghh9qJRNcrZZI5a5ER5isyNhx5XUzZw fgjjlnrXpH0GMJ0cRBQY2Jn2WK1DOynxlDG14gE9plQ1EC+5EstTDapeWYkhoUaomckIAFpP7teGA IuQuwHd+BeFEOG1UBkJX0bvJtaf/HKcA+YLmsSDyMVPJPM7WtrHo1ugC5Cj7+BlqbTCCYDR7Y9PWj +mGRcoow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOb9f-00000006PRd-21LT; Tue, 02 Jul 2024 10:54:35 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOb9Q-00000006PNd-2cXR for linux-arm-kernel@lists.infradead.org; Tue, 02 Jul 2024 10:54:25 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id E9E20CE1DC8; Tue, 2 Jul 2024 10:54:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6AF43C116B1; Tue, 2 Jul 2024 10:54:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719917658; bh=Nu8B5T3JPPoNTLLDtfwHrdmFJU39KKRK+9B2K65Fz/A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EEwIsnTs270z1fMt+nZIvziWDZ3zar11CzHZq7+xfW+jN1p+6jbjSzgBSqEDYI3i8 dJzVDuUmuatTpHfgjIdwJvxW243AbmSohCvJNvU265Mn8SdO5zAyYXSxv+CfiJGARQ yFGxeWQZ/XWUnwqkzsgOM2RSQox9FWPQTw9bbexW9sXkDikVWO+o7S0bGdQaEzg/CZ 942RQgxRaufFkXtcKpihct9H9psd63kaatKJ9dN15hu8nfSO/ZrG4R6RNy7NDkLlzB dTY8Xxqm3Lj3bW9g0KdTnGrPO12yMH+6yBCmzJxf4oVaZby14PbIewL9ke25JZW+zc s/4cMFWisQkLw== Date: Tue, 2 Jul 2024 11:54:11 +0100 From: Simon Horman To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?utf-8?B?S8O2cnk=?= Maincent , Jesse Brandeburg , Marek =?utf-8?B?QmVow7pu?= , Piergiorgio Beruto , Oleksij Rempel , =?utf-8?Q?Nicol=C3=B2?= Veronese , mwojtas@chromium.org, Nathan Chancellor , Antoine Tenart , Marc Kleine-Budde Subject: Re: [PATCH net-next v14 12/13] net: ethtool: strset: Allow querying phy stats by index Message-ID: <20240702105411.GF598357@kernel.org> References: <20240701131801.1227740-1-maxime.chevallier@bootlin.com> <20240701131801.1227740-13-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240701131801.1227740-13-maxime.chevallier@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240702_035424_289773_9411EAF4 X-CRM114-Status: GOOD ( 14.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 01, 2024 at 03:17:58PM +0200, Maxime Chevallier wrote: > The ETH_SS_PHY_STATS command gets PHY statistics. Use the phydev pointer > from the ethnl request to allow query phy stats from each PHY on the > link. > > Signed-off-by: Maxime Chevallier > --- > net/ethtool/strset.c | 24 +++++++++++++++++------- > 1 file changed, 17 insertions(+), 7 deletions(-) > > diff --git a/net/ethtool/strset.c b/net/ethtool/strset.c ... > @@ -279,6 +280,8 @@ static int strset_prepare_data(const struct ethnl_req_info *req_base, > const struct strset_req_info *req_info = STRSET_REQINFO(req_base); > struct strset_reply_data *data = STRSET_REPDATA(reply_base); > struct net_device *dev = reply_base->dev; > + struct nlattr **tb = info->attrs; Hi Maxime, Elsewhere in this function it is assumed that info may be NULL. But here it is dereferenced unconditionally. Flagged by Smatch. > + struct phy_device *phydev; > unsigned int i; > int ret; > ...