From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F178BC30658 for ; Tue, 2 Jul 2024 20:59:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AYFNePNTY1gRHLd4xPTSfRZ+SOnOlolwZfT2fITUeYA=; b=P2uav8tG97PFiJiZzzZkgRPwhJ jux2IThprKcEgF1ffT/VpuMKSLDi3ttSzQ2XFqrUP+M3mwkVh5Oy+QjZpburSMUVv/3S08m0Wer7U 11ucofS8QKxp2tDfQEgBGoF6dfZp4RmSydMEdqXQeUsgs2UX7U9LmaWV35JqrdgQf5ihg8q4t5hux acHq6V97yPimsQrsqg/IKMEBIhJlLqSHqXTJRyQTys/HCahE/9G18dfYotmH9LmSf2O7dvhAHrYV1 dk+dGmZZJ9RCEYQYtSicl0RYX2hwaPb6L9bcNXwVKgCqXQNFN3fmTfVuEf0md1CUsFE1dOk2Pu1DD Rg9dcmPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOkav-00000007xRH-0tmQ; Tue, 02 Jul 2024 20:59:21 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOkai-00000007xNT-1NRs for linux-arm-kernel@lists.infradead.org; Tue, 02 Jul 2024 20:59:09 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 716EACE0EA0; Tue, 2 Jul 2024 20:59:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B24E9C116B1; Tue, 2 Jul 2024 20:59:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719953945; bh=M5dTMNNKFSZPNRLeXlD7QixMEqci7PRpRdcKKTHwXT0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e7pEACpep47fM5EzPqXSGjiuTLxe7K5mNh9DdqI5hx0vTSI1SZ/cGPgnfIxMbfOVZ CD+P+li0lCXZeMWlM/V6yLPoD0AKn9ZchhmERR8zjSkciPX9O5Of++hxCIPkPGq+4E 17NMFeNi3ankZnfSFjiPdDeXGtQCux1FlEIeseNFfXImBEk5i4fbxDDg5h7kRBnLdm Ldyh3mz1LPgXJS7a4xH0iBySYDO8AqTnE20Q/6QWd4dc68EhTG+VudSTH1dMiuTQwR OcUff5j4/kzbhrKGJsuk2mH/kJLYebuC8kn2pv/a8q5YUx38EnDd40KeCjxfGSe8Fj fNZoKd7lGTpEQ== Date: Tue, 2 Jul 2024 13:59:05 -0700 From: Kees Cook To: Jinjie Ruan Cc: catalin.marinas@arm.com, will@kernel.org, oleg@redhat.com, tglx@linutronix.de, peterz@infradead.org, luto@kernel.org, wad@chromium.org, rostedt@goodmis.org, arnd@arndb.de, ardb@kernel.org, broonie@kernel.org, mark.rutland@arm.com, rick.p.edgecombe@intel.com, leobras@redhat.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 0/3] arm64: entry: Convert to generic entry Message-ID: <202407021358.D259DF0BCA@keescook> References: <20240629085601.470241-1-ruanjinjie@huawei.com> <202407010839.125126F@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240702_135908_573446_4E0DC7FB X-CRM114-Status: GOOD ( 15.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 02, 2024 at 09:01:42AM +0800, Jinjie Ruan wrote: > > > On 2024/7/1 23:40, Kees Cook wrote: > > On Sat, Jun 29, 2024 at 04:55:58PM +0800, Jinjie Ruan wrote: > >> Changes in v3: > >> - Test the MTE test cases. > >> - Handle forget_syscall() in arch_post_report_syscall_entry() > >> - Make the arch funcs not use __weak as Thomas suggested, so move > >> the arch funcs to entry-common.h, and make arch_forget_syscall() folded > >> in arch_post_report_syscall_entry() as suggested. > >> - Move report_single_step() to thread_info.h for arm64 > >> - Change __always_inline() to inline, add inline for the other arch funcs. > >> - Remove unused signal.h for entry-common.h. > >> - Add Suggested-by. > >> - Update the commit message. > > > > I didn't see the mentioned feedback from tglx in any of the threads. Is > > lore busted or is there discussion on this series happening somewhere > > else? > > It Seems Thomas only sent it to me without a public email. Ah ha! Okay, thanks. I thought I was missing some discussion somewhere. :) -- Kees Cook