From: Xu Yang <xu.yang_2@nxp.com>
To: acme@redhat.com, frank.li@nxp.com, will@kernel.org,
mark.rutland@arm.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com,
john.g.garry@oracle.com, jolsa@kernel.org, namhyung@kernel.org,
irogers@google.com
Cc: mike.leach@linaro.org, peterz@infradead.org, mingo@redhat.com,
acme@kernel.org, alexander.shishkin@linux.intel.com,
adrian.hunter@intel.com, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH v12 7/8] perf vendor events arm64:: Add i.MX93 DDR Performance Monitor metrics
Date: Wed, 3 Jul 2024 15:44:08 +0800 [thread overview]
Message-ID: <20240703074408.gbsabrdy7fvxfpuc@hippo> (raw)
In-Reply-To: <20240529080358.703784-7-xu.yang_2@nxp.com>
+Arnaldo
Hi Arnaldo,
On Wed, May 29, 2024 at 04:03:57PM +0800, Xu Yang wrote:
> Add JSON metrics for i.MX93 DDR Performance Monitor.
>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
Could you please apply patch 7/8 and 8/8 to tools/perf? They have already
been reviewed.
Many thanks in advance!
Thanks,
Xu Yang
>
> ---
> Changes in v7:
> - new patch
> Changes in v8:
> - no changes
> Changes in v9:
> - add Rb tag
> Changes in v10:
> - no changes
> Changes in v11:
> - no changes
> Changes in v12:
> - no changes
> ---
> .../arch/arm64/freescale/imx93/sys/ddrc.json | 9 +++++++
> .../arm64/freescale/imx93/sys/metrics.json | 26 +++++++++++++++++++
> 2 files changed, 35 insertions(+)
> create mode 100644 tools/perf/pmu-events/arch/arm64/freescale/imx93/sys/ddrc.json
> create mode 100644 tools/perf/pmu-events/arch/arm64/freescale/imx93/sys/metrics.json
>
> diff --git a/tools/perf/pmu-events/arch/arm64/freescale/imx93/sys/ddrc.json b/tools/perf/pmu-events/arch/arm64/freescale/imx93/sys/ddrc.json
> new file mode 100644
> index 000000000000..eeeae4d49fce
> --- /dev/null
> +++ b/tools/perf/pmu-events/arch/arm64/freescale/imx93/sys/ddrc.json
> @@ -0,0 +1,9 @@
> +[
> + {
> + "BriefDescription": "ddr cycles event",
> + "EventCode": "0x00",
> + "EventName": "imx93_ddr.cycles",
> + "Unit": "imx9_ddr",
> + "Compat": "imx93"
> + }
> +]
> diff --git a/tools/perf/pmu-events/arch/arm64/freescale/imx93/sys/metrics.json b/tools/perf/pmu-events/arch/arm64/freescale/imx93/sys/metrics.json
> new file mode 100644
> index 000000000000..4d2454ca1259
> --- /dev/null
> +++ b/tools/perf/pmu-events/arch/arm64/freescale/imx93/sys/metrics.json
> @@ -0,0 +1,26 @@
> +[
> + {
> + "BriefDescription": "bandwidth usage for lpddr4x evk board",
> + "MetricName": "imx93_bandwidth_usage.lpddr4x",
> + "MetricExpr": "(((( imx9_ddr0@ddrc_pm_0@ ) * 2 * 8 ) + (( imx9_ddr0@ddrc_pm_3@ + imx9_ddr0@ddrc_pm_5@ + imx9_ddr0@ddrc_pm_7@ + imx9_ddr0@ddrc_pm_9@ - imx9_ddr0@ddrc_pm_2@ - imx9_ddr0@ddrc_pm_4@ - imx9_ddr0@ddrc_pm_6@ - imx9_ddr0@ddrc_pm_8@ ) * 32 )) / duration_time) / (3733 * 1000000 * 2)",
> + "ScaleUnit": "1e2%",
> + "Unit": "imx9_ddr",
> + "Compat": "imx93"
> + },
> + {
> + "BriefDescription": "bytes all masters read from ddr",
> + "MetricName": "imx93_ddr_read.all",
> + "MetricExpr": "( imx9_ddr0@ddrc_pm_0@ ) * 2 * 8",
> + "ScaleUnit": "9.765625e-4KB",
> + "Unit": "imx9_ddr",
> + "Compat": "imx93"
> + },
> + {
> + "BriefDescription": "bytes all masters write to ddr",
> + "MetricName": "imx93_ddr_write.all",
> + "MetricExpr": "( imx9_ddr0@ddrc_pm_3@ + imx9_ddr0@ddrc_pm_5@ + imx9_ddr0@ddrc_pm_7@ + imx9_ddr0@ddrc_pm_9@ - imx9_ddr0@ddrc_pm_2@ - imx9_ddr0@ddrc_pm_4@ - imx9_ddr0@ddrc_pm_6@ - imx9_ddr0@ddrc_pm_8@ ) * 32",
> + "ScaleUnit": "9.765625e-4KB",
> + "Unit": "imx9_ddr",
> + "Compat": "imx93"
> + }
> +]
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-07-03 8:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 8:03 [PATCH v12 1/8] dt-bindings: perf: fsl-imx-ddr: Add i.MX95 compatible Xu Yang
2024-05-29 8:03 ` [PATCH v12 2/8] perf: imx_perf: add macro definitions for parsing config attr Xu Yang
2024-05-29 8:03 ` [PATCH v12 3/8] perf: imx_perf: let the driver manage the counter usage rather the user Xu Yang
2024-05-29 8:03 ` [PATCH v12 4/8] perf: imx_perf: refactor driver for imx93 Xu Yang
2024-05-29 8:03 ` [PATCH v12 5/8] perf: imx_perf: fix counter start and config sequence Xu Yang
2024-05-29 8:03 ` [PATCH v12 6/8] perf: imx_perf: add support for i.MX95 platform Xu Yang
2024-05-29 8:03 ` [PATCH v12 7/8] perf vendor events arm64:: Add i.MX93 DDR Performance Monitor metrics Xu Yang
2024-07-03 7:44 ` Xu Yang [this message]
2024-05-29 8:03 ` [PATCH v12 8/8] perf vendor events arm64:: Add i.MX95 " Xu Yang
2024-06-24 6:23 ` [PATCH v12 1/8] dt-bindings: perf: fsl-imx-ddr: Add i.MX95 compatible Xu Yang
2024-07-01 15:35 ` Will Deacon
2024-07-04 20:00 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240703074408.gbsabrdy7fvxfpuc@hippo \
--to=xu.yang_2@nxp.com \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frank.li@nxp.com \
--cc=imx@lists.linux.dev \
--cc=irogers@google.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox