From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5ADDC41513 for ; Wed, 3 Jul 2024 15:15:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Srongl+wDtublTtQo2JuRKHs5cp5es+WndMKW8e5FYk=; b=hLtHdlkldhn1BouEKE4iLZD89L F3XoJDDwOwffXGEKTLKptlpe55rdk0KNYbcBpwL4CWkT8FaY5Glw4IIb6Cl3bYORcnicgQeUUr2a+ U+iNDJHjrlLdsHYOYW0gQNRIt7t1M14KsHadjmRyRr0evBEXUdwjC5VYrl5+G6rzuzOqf2nwjUzmA nlSHVejaYjK7fvjdv63pGWh+RnXkwMM1BH9KUu9GEnQjbySSJvB+9sUOT6Vv4+skAUKZkfwEkDDCq u55ADg0cEdmCAtWuNylFEmCu/0oeiznjvh3q60F4V8RHYAIGW/u/EUsILDbCoQqG8ZCihMNRnhJgA 9YPseQbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sP1i1-0000000Ae6R-24ZA; Wed, 03 Jul 2024 15:15:49 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sP0bz-0000000AOsF-29f8 for linux-arm-kernel@lists.infradead.org; Wed, 03 Jul 2024 14:05:33 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 018CB62243; Wed, 3 Jul 2024 14:05:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CD7AC2BD10; Wed, 3 Jul 2024 14:05:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1720015529; bh=SBuiLlAm8KdKJg4F9Y0YoQ0A1QaiAy6w/Qr73jLhApo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sps+pOmGOcLZTVV9gSreDYf32GXk4Sa3XE8agNk7MvVkVWlhHYVJAkc5E0yJnbttA 9NCCGPfPfIFZXp3rBmgBxXEjVim7Ke4nDtWYF8gz7DidP8S03BIpuILdH9e8p8QH5P h6Eb7Cs6LoF/il5mumcvp/t9iqQ52jxIrxJa1AfU= Date: Wed, 3 Jul 2024 16:05:19 +0200 From: Greg Kroah-Hartman To: Dmitry Baryshkov Cc: Heikki Krogerus , Maxime Coquelin , Alexandre Torgue , Nikita Travkin , Neil Armstrong , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 0/7] usb: typec: ucsi: rework glue driver interface Message-ID: <2024070310-iodine-synopsis-4fd9@gregkh> References: <20240627-ucsi-rework-interface-v4-0-289ddc6874c7@linaro.org> <2024062717-foster-document-eb2f@gregkh> <2024062825-balancing-resigned-e383@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240703_070531_764366_07D47014 X-CRM114-Status: GOOD ( 30.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 28, 2024 at 05:25:17PM +0300, Dmitry Baryshkov wrote: > On Fri, 28 Jun 2024 at 17:24, Greg Kroah-Hartman > wrote: > > > > On Thu, Jun 27, 2024 at 06:08:07PM +0300, Dmitry Baryshkov wrote: > > > On Thu, 27 Jun 2024 at 17:57, Dmitry Baryshkov > > > wrote: > > > > > > > > On Thu, 27 Jun 2024 at 17:54, Greg Kroah-Hartman > > > > wrote: > > > > > > > > > > On Thu, Jun 27, 2024 at 05:44:39PM +0300, Dmitry Baryshkov wrote: > > > > > > The interface between UCSI and the glue driver is very low-level. It > > > > > > allows reading the UCSI data from any offset (but in reality the UCSI > > > > > > driver reads only VERSION, CCI an MESSAGE_IN data). All event handling > > > > > > is to be done by the glue driver (which already resulted in several > > > > > > similar-but-slightly different implementations). It leaves no place to > > > > > > optimize the write-read-read sequence for the command execution (which > > > > > > might be beneficial for some of the drivers), etc. > > > > > > > > > > > > The patchseries attempts to restructure the UCSI glue driver interface > > > > > > in order to provide sensible operations instead of a low-level read / > > > > > > write calls. > > > > > > > > > > > > If this approach is found to be acceptable, I plan to further rework the > > > > > > command interface, moving reading CCI and MESSAGE_IN to the common > > > > > > control code, which should simplify driver's implementation and remove > > > > > > necessity to split quirks between sync_control and read_message_in e.g. > > > > > > as implemented in the ucsi_ccg.c. > > > > > > > > > > > > Note, the series was tested only on the ucsi_glink platforms. Further > > > > > > testing is appreciated. > > > > > > > > > > > > Depends: [1], [2] > > > > > > > > > > > > [1] https://lore.kernel.org/linux-usb/20240612124656.2305603-1-fabrice.gasnier@foss.st.com/ > > > > > > > > > > > > [2] https://lore.kernel.org/linux-usb/20240621-ucsi-yoga-ec-driver-v8-1-e03f3536b8c6@linaro.org/ > > > > > > > > > > > > Signed-off-by: Dmitry Baryshkov > > > > > > --- > > > > > > Changes in v4: > > > > > > - Rebased on top of Greg's tree to resolve conflicts. > > > > > > > > > > Nope, still got conflicts, are you sure you updated properly? Patch 1 > > > > > applied, but #2 did not. > > > > > > > > I feel stupid enough now. I rebased on top of usb-next instead of > > > > usb-testing. Let me spam it once again > > > > > > Hmm, I see what happened. I had a next+usb-next. Simple usb-next > > > doesn't contain changes from 9e3caa9dd51b ("usb: typec: ucsi_acpi: Add > > > LG Gram quirk") which this patch also modifies. I can rebase it on top > > > of your tree, but then we will have build issues once usb-linus and > > > usb-next get merged together. > > > > Ah, you need/want stuff from both branches, right? Then just wait until > > next week when my -linus branch will be in Linus's tree and then I will > > merge that into the -next branch. > > Ack. Maybe I'll post another iteration based on the discussion on the > mailing list. Now queued up, thanks. greg k-h