From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E44F4C2BD09 for ; Wed, 3 Jul 2024 14:39:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FfGcNFYpX9vOz9WPwturJrJMOEYNHWpo6EBUGXtSIl8=; b=SBB73vCT9mme6J0vlMWEg45RR3 fEe/DmRGJylVUxNd9PymAdQRnJJtKCH8l15vDQQIojgkqtwpTmkIlueh9iRp6EkFZJErNnHQVkKAL k7L24wHp99/G/bAT+iq5fojcfL3TTV9BsaX1UOrw+5tGeXPMWg7L2peiySlxOCUvNsCiBxv4SvinR 3L0II8snRqPfpInIBLeK29HZFB3VSti9ZRk1FScxztZnQj3Yw+ZbuSXJzZaChQ0L9H81cXtu9y6fG rSibwy2FJAbt1QoxjR7RywdKruEVbUahLYfG1OgtVOvpFx5oA8u9vXGyNwP1XYhhxDevkyTX0mmbi qanwq/GA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sP18X-0000000AVQR-2WW8; Wed, 03 Jul 2024 14:39:09 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sP180-0000000AVCe-1oXm for linux-arm-kernel@lists.infradead.org; Wed, 03 Jul 2024 14:38:37 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 040BF1688; Wed, 3 Jul 2024 07:39:01 -0700 (PDT) Received: from thinkcentre-m93p.cambridge.arm.com (thinkcentre-m93p.cambridge.arm.com [10.1.197.43]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 245DB3F766; Wed, 3 Jul 2024 07:38:35 -0700 (PDT) From: Luke Parkin To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org Cc: sudeep.holla@arm.com, cristian.marussi@arm.com, Luke Parkin Subject: [PATCH v2 4/4] firmware: arm_scmi: Create debugfs files for statistics Date: Wed, 3 Jul 2024 15:37:38 +0100 Message-Id: <20240703143738.2007457-5-luke.parkin@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240703143738.2007457-1-luke.parkin@arm.com> References: <20240703143738.2007457-1-luke.parkin@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240703_073836_590335_33C2DAB1 X-CRM114-Status: UNSURE ( 9.51 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Create debugfs files for the statistics in the scmi_debug_stats struct Signed-off-by: Luke Parkin v1->v2 Only create stats pointer if stats are enabled Move stats debugfs creation into a seperate helper function --- drivers/firmware/arm_scmi/driver.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index 937546397cf2..10cd9a319ffb 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -2858,6 +2858,24 @@ static int scmi_device_request_notifier(struct notifier_block *nb, return NOTIFY_OK; } +static void scmi_debugfs_stats_setup(struct scmi_info *info, + struct dentry *trans) +{ + struct dentry *stats; + + stats = debugfs_create_dir("stats", trans); + debugfs_create_atomic_t("response_ok", 0400, stats, + &info->stats.response_ok); + debugfs_create_atomic_t("dlyd_response_ok", 0400, stats, + &info->stats.dlyd_response_ok); + debugfs_create_atomic_t("sent_ok", 0400, stats, + &info->stats.sent_ok); + debugfs_create_atomic_t("sent_fail", 0400, stats, + &info->stats.sent_fail); + debugfs_create_atomic_t("xfers_response_timeout", 0400, stats, + &info->stats.xfers_response_timeout); +} + static void scmi_debugfs_common_cleanup(void *d) { struct scmi_debug_info *dbg = d; @@ -2924,6 +2942,9 @@ static struct scmi_debug_info *scmi_debugfs_common_setup(struct scmi_info *info) debugfs_create_u32("rx_max_msg", 0400, trans, (u32 *)&info->rx_minfo.max_msg); + if (IS_ENABLED(CONFIG_ARM_SCMI_DEBUG_STATISTICS)) + scmi_debugfs_stats_setup(info, trans); + dbg->top_dentry = top_dentry; if (devm_add_action_or_reset(info->dev, -- 2.34.1