* [PATCH] KVM: arm64: nv: Truely enable nXS TLBI operations
@ 2024-07-03 15:47 Marc Zyngier
2024-07-03 23:25 ` Oliver Upton
0 siblings, 1 reply; 2+ messages in thread
From: Marc Zyngier @ 2024-07-03 15:47 UTC (permalink / raw)
To: kvmarm, linux-arm-kernel, kvm
Cc: James Morse, Suzuki K Poulose, Oliver Upton, Zenghui Yu
Although we now have support for nXS-flavoured TLBI instructions,
we still don't expose the feature to the guest thanks to a mixture
of misleading comment and use of a bunch of magic values.
Fix the comment and correctly express the masking of LS64, which
is enough to expose nXS to the world. Not that anyone cares...
Signed-off-by: Marc Zyngier <maz@kernel.org>
---
arch/arm64/kvm/nested.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/kvm/nested.c b/arch/arm64/kvm/nested.c
index 81e0374a4a45b..b3c8d8e04a547 100644
--- a/arch/arm64/kvm/nested.c
+++ b/arch/arm64/kvm/nested.c
@@ -810,8 +810,8 @@ static u64 limit_nv_id_reg(u32 id, u64 val)
break;
case SYS_ID_AA64ISAR1_EL1:
- /* Support everything but Spec Invalidation */
- val &= ~(GENMASK_ULL(63, 56) |
+ /* Support everything but Spec Invalidation and LS64 */
+ val &= ~(NV_FTR(ISAR1, LS64) |
NV_FTR(ISAR1, SPECRES));
break;
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: arm64: nv: Truely enable nXS TLBI operations
2024-07-03 15:47 [PATCH] KVM: arm64: nv: Truely enable nXS TLBI operations Marc Zyngier
@ 2024-07-03 23:25 ` Oliver Upton
0 siblings, 0 replies; 2+ messages in thread
From: Oliver Upton @ 2024-07-03 23:25 UTC (permalink / raw)
To: kvm, linux-arm-kernel, kvmarm, Marc Zyngier
Cc: Oliver Upton, Suzuki K Poulose, James Morse, Zenghui Yu
On Wed, 3 Jul 2024 16:47:43 +0100, Marc Zyngier wrote:
> Although we now have support for nXS-flavoured TLBI instructions,
> we still don't expose the feature to the guest thanks to a mixture
> of misleading comment and use of a bunch of magic values.
>
> Fix the comment and correctly express the masking of LS64, which
> is enough to expose nXS to the world. Not that anyone cares...
>
> [...]
Applied to kvmarm/next, thanks!
[1/1] KVM: arm64: nv: Truely enable nXS TLBI operations
https://git.kernel.org/kvmarm/kvmarm/c/3cfde36df7ab
--
Best,
Oliver
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-03 23:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-03 15:47 [PATCH] KVM: arm64: nv: Truely enable nXS TLBI operations Marc Zyngier
2024-07-03 23:25 ` Oliver Upton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).