From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9B2DC2BD09 for ; Wed, 3 Jul 2024 23:48:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yLllhCchoOYYFOs3o1AMSqnWSEzPVdqQsQux8UVA6qQ=; b=40LaSqlIXIVWmltslGcgka+zFg qlMvSdNbC0ITgsnlMOOQ+P6p7xS7qyGNxuSfLRBZ74GSfnGFnBp03RamId9N5QhyhHsTt7rGPBW1J abHj1mBfVp1QVhAtXxdXsTf1MJRFoG7NCNcoXrUdYbzUeQlZGJD0h2JEgFqWgSQS86bO6aAFyi//q gzXoC/NNTC6J9ZAGf229cPaYc0rS0/5HuuGC51NhZ+7uQwhQ+CW46FmdhF9e02u9V8p5vH3C5grf7 MIu2VedubDqWFcDn6Tv6pitFxnuQPPqcNi5z+0oZ9yOoUXvkYu6q5wZogBfq7J31oluCKjZ7kTTJt Hx3xNEow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sP9iG-0000000Bl8Q-2HP6; Wed, 03 Jul 2024 23:48:36 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sP9i3-0000000Bl65-1Qm0; Wed, 03 Jul 2024 23:48:24 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 8995ACE1693; Wed, 3 Jul 2024 23:48:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6678AC2BD10; Wed, 3 Jul 2024 23:48:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720050499; bh=3EAKouPpI6FP3niYbt2D0U7O15uPOgW9c4Vzms3YCG8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hvBGQEPyXQxi5gzRvHcmoT3Ohm634kdj2IMUgLn9Th5jV4RnjPvxLmaqYllM8IIKt ZambVVFgH3Vld0yFsjRo5T5Pxy+v7BItlvVytW4gH49/vOmu0N3lqOVCrAVnleDnZE uHSFkfdECysIUt5395FkoMS3Aksf9Lbn/mls0bQDYPmYgMDT1PfKEwa8lWD8BB6qPF vPpNB7x/xA63Bv6f/8b/rq6hq916mtKbkZgPwV/ih+5Dds1Ic6KHi5QAl40kQiYtgW UDUjtXFoRaRAHrftiAliGdVSWp/knD1ANy57cFOzfeMBcfIJBmpId8VFH1QkKFwExg BL8mBSyHq5K3w== Date: Wed, 3 Jul 2024 16:48:18 -0700 From: Jakub Kicinski To: Shengyu Qu Cc: nbd@nbd.name, sean.wang@mediatek.com, Mark-MC.Lee@mediatek.com, lorenzo@kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, pablo@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, stable@vger.kernel.org, Elad Yifee Subject: Re: [PATCH v2] net: ethernet: mtk_ppe: Change PPE entries number to 16K Message-ID: <20240703164818.13e1d33c@kernel.org> In-Reply-To: References: <20240702110224.74abfcea@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240703_164823_588678_D5910D24 X-CRM114-Status: UNSURE ( 8.31 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 4 Jul 2024 01:38:50 +0800 Shengyu Qu wrote: > BT download and PCDN would create tons of connections, and might be > easily to reach the 8192 limit, one of my friend sees 50000+ links when > hosting PCDN. I don't know what PCDN is, but what we care about in Linux is whether the change under Fixes introduced a regression. Optimizations, and improvements no matter how trivial in terms of code are not fixes. So did ba37b7caf1ed ("net: ethernet: mtk_eth_soc: add support for initializing the PPE") make things worse. And if you're saying there are 50k "links" in real world why is 16k a major win? it's 1/3rd of the total.