From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18F96C30653 for ; Thu, 4 Jul 2024 16:27:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qTgqZTSYnAVOi/PCiWbuaELYwQdBtK3t7OMclccsGFM=; b=jbJFwCTcnAZQFgXT/uktojWmpb E4NJcTGU77bnLB73YyxOvumObEjeu/bX8W2iWa5BvUVH4RCeQmoT/puN8li6oyTItcCvO/9+fZagQ Vf7fRGYnnxAL5sOwGDD6FF5qHDIstlVxqHNAljGs12NQBAX/ohhB72M9ER6pFo2WX4RDqyeIHNPR2 tx2Ev1y080OHYFKGYnHb/68dxFm1tZy0xSjbywnekkQdXYPQyvQ1KjahbdOYsMLpaY19kU5Lgsz8a l2sBjVzlOhdXXGfbwZ19N9qiaOICXURB23+p6AEsLTyfNVpTsI4j2JFPfreHf6AKaWy4lW+X0X3SP L6vcePJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPPIj-0000000Dq4A-3DdJ; Thu, 04 Jul 2024 16:27:17 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPPIW-0000000DpzS-2KGa; Thu, 04 Jul 2024 16:27:06 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 6B382CE38AB; Thu, 4 Jul 2024 16:27:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6CDFDC3277B; Thu, 4 Jul 2024 16:26:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720110421; bh=OJmz8+6ALNKIZuZiA3L7XZYVfl4eHNDpzxBW8RqwYCw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OrDUa8n+RnwzJxAa0YTpcTYvjdnrMog/75aNlJNG5oj0fBL9j91MXxE1+Q1mRDAb6 Yj8LuH/zQXwKEh3njCx7Q1x9MSPQDOGz68fSYbliJTtpC8RBC63uzqy+URgqkNaDgJ 8bgq+SeoubL1oGEb1DLUb1fttr8/CwKzK613L/q3R1SvZL0Fw/RCqmkGVfxD4aR2qp 8lXGA203OPoOdIvWqpGuiHFUtjvAOx1BbcUscY/IpQ9wB63AO+FMkFGDrD7qdzOGyo Ys4HNl26qcwvstAg2XaOUhkUF+fqt+bjTIQz5UD/TqerHeehIO2Mn88M7V4F7zv1eP IGeLbBQg4Xxkg== Date: Thu, 4 Jul 2024 17:26:56 +0100 From: Conor Dooley To: Julien Stephan Cc: Laurent Pinchart , Andy Hsieh , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Louis Kuo , Phi-Bang Nguyen Subject: Re: [PATCH v5 1/5] dt-bindings: media: add mediatek ISP3.0 sensor interface Message-ID: <20240704-catcall-stubbly-9258b056e42e@spud> References: <20240704-add-mtk-isp-3-0-support-v5-0-bfccccc5ec21@baylibre.com> <20240704-add-mtk-isp-3-0-support-v5-1-bfccccc5ec21@baylibre.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="voVV9R7vNjAajsoC" Content-Disposition: inline In-Reply-To: <20240704-add-mtk-isp-3-0-support-v5-1-bfccccc5ec21@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240704_092704_960294_D6BF48DE X-CRM114-Status: GOOD ( 22.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --voVV9R7vNjAajsoC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 04, 2024 at 03:36:40PM +0200, Julien Stephan wrote: > From: Louis Kuo >=20 > This adds the bindings, for the mediatek ISP3.0 SENINF module embedded in > some Mediatek SoC, such as the mt8365 >=20 > Signed-off-by: Louis Kuo > Signed-off-by: Phi-Bang Nguyen > Link: https://lore.kernel.org/r/20230807094940.329165-2-jstephan@baylibre= =2Ecom > Signed-off-by: Laurent Pinchart > Reviewed-by: Laurent Pinchart > Signed-off-by: Julien Stephan I'm really confused by the link tag here. At first glance this looked like you were sending out something that had been applied by Laurent, given the Link, Rb and SoB from him. Why does he have a SoB on this patch? What did Phi-Bang Nguyen do with this patch, and should they have a Co-developed-by tag? > --- > .../bindings/media/mediatek,mt8365-seninf.yaml | 275 +++++++++++++++= ++++++ > MAINTAINERS | 7 + > 2 files changed, 282 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8365-seni= nf.yaml b/Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.ya= ml > new file mode 100644 > index 000000000000..aeabea9f956a > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml > @@ -0,0 +1,275 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (c) 2023 MediaTek, BayLibre > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/mediatek,mt8365-seninf.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek Sensor Interface 3.0 > + > +maintainers: > + - Laurent Pinchart > + - Julien Stephan > + - Andy Hsieh > + > +description: > + The ISP3.0 SENINF is the CSI-2 and parallel camera sensor interface fo= und in > + multiple MediaTek SoCs. It can support up to three physical CSI-2 inpu= t ports, > + configured in DPHY (2 or 4 data lanes) or CPHY depending on the SoC. > + On the output side, SENINF can be connected either to CAMSV instance or > + to the internal ISP. CAMSV is used to bypass the internal ISP processi= ng > + in order to connect either an external ISP, or a sensor (RAW, YUV). > + > +properties: > + compatible: > + const: mediatek,mt8365-seninf > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + clocks: > + items: > + - description: Seninf camsys clock > + - description: Seninf top mux clock > + > + clock-names: > + items: > + - const: camsys > + - const: top_mux > + > + phys: true > + > + phy-names: true > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: CSI0 or CSI0A port > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + clock-lanes: > + maxItems: 1 > + data-lanes: > + minItems: 1 > + maxItems: 4 > + > + port@1: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: CSI1 port > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + clock-lanes: > + maxItems: 1 > + data-lanes: > + minItems: 1 > + maxItems: 4 > + > + port@2: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: CSI2 port > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + clock-lanes: > + maxItems: 1 > + data-lanes: > + minItems: 1 > + maxItems: 4 > + > + port@3: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: CSI0B port > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + clock-lanes: > + maxItems: 1 > + data-lanes: > + minItems: 1 > + maxItems: 2 > + > + port@4: > + $ref: /schemas/graph.yaml#/properties/port > + description: connection point for cam0 > + > + port@5: > + $ref: /schemas/graph.yaml#/properties/port > + description: connection point for cam1 > + > + port@6: > + $ref: /schemas/graph.yaml#/properties/port > + description: connection point for camsv0 > + > + port@7: > + $ref: /schemas/graph.yaml#/properties/port > + description: connection point for camsv1 > + > + port@8: > + $ref: /schemas/graph.yaml#/properties/port > + description: connection point for camsv2 > + > + port@9: > + $ref: /schemas/graph.yaml#/properties/port > + description: connection point for camsv3 > + > + required: > + - port@0 > + - port@1 > + - port@2 > + - port@3 > + - port@4 > + - port@5 > + - port@6 > + - port@7 > + - port@8 > + - port@9 > + > +required: > + - compatible > + - interrupts > + - clocks > + - clock-names > + - power-domains > + - ports > + > +additionalProperties: false > + > +if: > + properties: > + compatible: > + contains: > + const: mediatek,mt8365-seninf The binding supports only a single compatible, why is this complexity required? I don't see other devices being added in this series. Cheers, Conor. > +then: > + properties: > + phys: > + minItems: 2 > + maxItems: 2 > + description: > + phandle to the PHYs connected to CSI0/A, CSI1, CSI0B > + > + phy-names: > + description: > + list of PHYs names > + minItems: 2 > + maxItems: 2 > + items: > + type: string > + enum: > + - csi0 > + - csi1 > + - csi0b > + uniqueItems: true --voVV9R7vNjAajsoC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZobNUAAKCRB4tDGHoIJi 0pbHAP9oyb3VVfiOce+y/RlLWtTgU60hGLandmi6ztVG/wGCjgEA7nzUqczM/a/v 53cqRK4JMbZsvZhR3V+fZ+JdSynKGgI= =vYDF -----END PGP SIGNATURE----- --voVV9R7vNjAajsoC--