From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D400C30653 for ; Thu, 4 Jul 2024 08:05:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=B2Dd+Vi+ygaeHfugpUqHHdz5n+PugnuRjKyRb3baBns=; b=dUncVl/nYKt5i++IqtSuGE9FZI YO7nPDqOcCFqUyZvxK5Cx86EfX8IBT3m47unRX4wa4bC5rAdIcS0MvOCU4c4cv8qL/TEFzyjfCUmG i5iYsxGb5T2T797LB061y/KRqUAxofAkJuTLfwMXLHIg+sVWImZs/iTboNj3GfATp5kUV/dBTZSYW np12RNRt81WzsP4SZE5skHF6QD42DUdUUAX2ZvbXr6wVYwyRQHny8nmEiJ/x6ufSI7y9xjR/MFJlR PD52VZqurjDJttxnHPI2AajOdbB8UNitOl9r/MsXlx48cnSkKgqjFdkl7cG067/TKXXP3dAaH0A1i XlhTRORA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPHSp-0000000CXX9-2vde; Thu, 04 Jul 2024 08:05:11 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPHSc-0000000CXUd-2V4B for linux-arm-kernel@lists.infradead.org; Thu, 04 Jul 2024 08:05:00 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 711C0E0007; Thu, 4 Jul 2024 08:04:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1720080295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B2Dd+Vi+ygaeHfugpUqHHdz5n+PugnuRjKyRb3baBns=; b=XPmoLHHN0tJQLVIPOtg1MytcKIp5T1fpADEqDfSZOLEYa2kQzbEgevd0sIF/0YMKjlV+0r BpygXMaRmo063x+xCd4j5VKWWoxQA4HPf3LVMnDx4AcXaz1heMAPXe2/+NqENHQWkjxstm Olwb1Od51q7UKZ+0p9H+60E/LzDhgee1MquerNPBO7D1JE5f6Eivl6R9kP4mQCgt2lWX0E wKWpgI4s7ZhVnfQkLw/R0ISsHHuLOP9xxZMPsNwsieuqUZawwe5ZsopgxGpZFP+X1t01tv mAZw7Is6oIhclSZ5FCza5xuwKRAeRcQi0sqMlUn5YZK8sVq8Edzhd9cmrXom4Q== Date: Thu, 4 Jul 2024 10:04:50 +0200 From: Maxime Chevallier To: "Russell King (Oracle)" Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?B?S8O2cnk=?= Maincent , Jesse Brandeburg , Marek =?UTF-8?B?QmVow7pu?= , Piergiorgio Beruto , Oleksij Rempel , =?UTF-8?B?Tmljb2zDsg==?= Veronese , Simon Horman , mwojtas@chromium.org, Nathan Chancellor , Antoine Tenart , Marc Kleine-Budde , Dan Carpenter Subject: Re: [PATCH net-next v15 04/14] net: sfp: Add helper to return the SFP bus name Message-ID: <20240704100450.67182233@fedora-2.home> In-Reply-To: References: <20240703140806.271938-1-maxime.chevallier@bootlin.com> <20240703140806.271938-5-maxime.chevallier@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-Sasl: maxime.chevallier@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240704_010458_802972_741C6F59 X-CRM114-Status: GOOD ( 16.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Russell, On Wed, 3 Jul 2024 16:36:20 +0100 "Russell King (Oracle)" wrote: > On Wed, Jul 03, 2024 at 04:07:54PM +0200, Maxime Chevallier wrote: > > Knowing the bus name is helpful when we want to expose the link topology > > to userspace, add a helper to return the SFP bus name. > > I think it's worth mentioning about the use case in this patch as well, > something like: > > "This call will always be made while holding the RTNL which ensures > that the SFP driver won't unbind from the device. The returned pointer > to the bus name will only be used while RTNL is held." I'll add that in both the commit log and the documentation for the function. [...] > > +EXPORT_SYMBOL_GPL(sfp_get_name); > > Please move this to just below sfp_bus_del_upstream() since the > functions in this file are organised as: > > - internal functions > - upstream callable functions > - downstream (sfp driver) callable functions. > > Note also that the upstream callable functions are all documented with > kerneldoc, and sfp_get_name() is clearly a function called from the > upstream side. No problem, I'll move it and a some proper documentation. Thanks for the review, Maxime