From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19255C30658 for ; Fri, 5 Jul 2024 10:52:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fd+l/XM7OxJg3jANVOyqzSbnRUFIEyKJZKYsgM5E4dg=; b=iSRUfsPudPMWqPun2lYIViU7LI sigIRMro1a0KlZv89Rml4qo/aLc5OdyZHtVuFq9jRwd04TCb6a4f8u13B7EUMD+JMyf3dHvHQXaMt HA29fX1Zzt0VX7ElK5fV9rTSLmoOmASmRdVGw7cWZ9nr4dPG1FfvvyfRXRj207K89rJmTBOMmZoS3 vzhHGUUcWp67XB9BcGX7h6aEImJKdsGNc8dQjI+FMDXz03uQcaSBdMXoXk40AUnGf7qgv1iQs+prs JRytIwgkhCUMSwzq1/gn1eY0bRPieIY/tPa8cjkwVTykIxSAaGMcyebdDxIKsC/Xsq+3fgY87s36b it7vWqtg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPgYE-0000000FhfE-37aS; Fri, 05 Jul 2024 10:52:26 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPgY0-0000000FhaW-3kVy for linux-arm-kernel@lists.infradead.org; Fri, 05 Jul 2024 10:52:14 +0000 Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4WFqzQ5Yg1z6K96m; Fri, 5 Jul 2024 18:50:10 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 5AF76140B33; Fri, 5 Jul 2024 18:52:06 +0800 (CST) Received: from localhost (10.203.174.77) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 5 Jul 2024 11:52:06 +0100 Date: Fri, 5 Jul 2024 11:52:05 +0100 From: Jonathan Cameron To: Kousik Sanagavarapu CC: Julia Lawall , Nishanth Menon , Santosh Shilimkar , Nathan Chancellor , Shuah Khan , "Javier Carrasco" , , Subject: Re: [PATCH v2 2/3] soc: ti: knav_qmss_queue: do device_node auto cleanup Message-ID: <20240705115205.00006363@Huawei.com> In-Reply-To: <20240703065710.13786-3-five231003@gmail.com> References: <20240703065710.13786-1-five231003@gmail.com> <20240703065710.13786-3-five231003@gmail.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.174.77] X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240705_035213_107592_29A6648D X-CRM114-Status: GOOD ( 14.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 3 Jul 2024 12:25:27 +0530 Kousik Sanagavarapu wrote: > Use scope based cleanup, instead of manual of_node_put() calls, which > automatically free()s "struct device_node". > > While at it, refactor the code from knav_queue_probe() into the seperate > functions to make auto cleanup look more neat. > > Doing the cleanup this way has the advantage of reducing the chance of > memory leaks in case we need to read from new OF nodes in the future > when we probe. > > Suggested-by: Julia Lawall > Signed-off-by: Kousik Sanagavarapu One trivial thing inline Reviewed-by: Jonathan Cameron > @@ -1668,6 +1686,25 @@ static int knav_queue_start_pdsps(struct knav_device *kdev) > return 0; > } > > +static int knav_queue_setup_pdsps(struct knav_device *kdev, > + struct device_node *node) > +{ > + struct device_node *pdsps __free(device_node) = > + of_get_child_by_name(node, "pdsps"); > + > + if (pdsps) { > + int ret; > + > + ret = knav_queue_init_pdsps(kdev, pdsps); > + if (ret) > + return ret; As per original style, readability slightly helped by a blank line here. > + ret = knav_queue_start_pdsps(kdev); > + if (ret) > + return ret; > + } > + return 0; > +}