From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A9F2C3271E for ; Fri, 5 Jul 2024 13:30:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=au751q6uXgdNnQ+9HA8qxp8WnsnVyZHIPDFw4WURLBk=; b=COL1szJWo49LZd69b0td0+iq44 ptyaSavfTc3ByBbshBkXaCBn7UqsV7KusdZmCAMMqo8udhUJmiJ1Rm3MTiVh7Q3xfSP8tuHcwiwyl 3cESP2IrTA89on7z+sX1P5sz5nsibSxl1jV0r3xrbR1X/OffL8o8anH7orm07hs3T8pRwmLh3sGn5 NhCGT2Pw5HmtH63oCFO2fgX/sALu/KVpBcH5Q+pboURGHiPeTENdNDyIEPIyW3bR9BwSQ0+DXjG7C uBTR/2EFNA5OJHy79og50J3OaoBkH6HfHNRmeZlaR8Ooaa16vrraZ7tJIazbzhhBGoUBat94nhsEk 0G3U8wrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPj0k-0000000G3Ft-0p6f; Fri, 05 Jul 2024 13:30:02 +0000 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPiyH-0000000G28S-0Wjm for linux-arm-kernel@lists.infradead.org; Fri, 05 Jul 2024 13:27:30 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 3A7DB1C0005; Fri, 5 Jul 2024 13:27:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1720186047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=au751q6uXgdNnQ+9HA8qxp8WnsnVyZHIPDFw4WURLBk=; b=e+vN7FVHI/wvzu78RuLiTO9ZHuaggDzVM9D46l43fo4yyYL5GnR6Yjm9uWEjFVw6qlcREu MLEhrchzpoaaHGwK3tS8VOM1xSkhTeR+AIv58i3GFzrpin+Ttd2VnX+LQ4TdF5wIUm6UAn P1DLxklrCG/eZpwAeW9Vs8iKsvg3xcuy0Kr4NGDQyID/EPxQ0Q0v9JZtfbyO+yG45Hp6ub S6O/6/AUVIta9wgMJc64zP8zgJ1IaWKKg1rzJTaxjBeVFIm7sbBQIfl7b/pbe9rru2GMmb RR2ZvQy79loao/WUX8k8b+E18cu4cIRQrkcfXamezZh6uQWUMEK8uAvtAa4l1A== From: Maxime Chevallier To: davem@davemloft.net Cc: Maxime Chevallier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?q?K=C3=B6ry=20Maincent?= , Jesse Brandeburg , =?UTF-8?q?Marek=20Beh=C3=BAn?= , Piergiorgio Beruto , Oleksij Rempel , =?UTF-8?q?Nicol=C3=B2=20Veronese?= , Simon Horman , mwojtas@chromium.org, Nathan Chancellor , Antoine Tenart , Marc Kleine-Budde , Dan Carpenter , Romain Gantois , kernel test robot Subject: [PATCH net-next v16 12/14] net: ethtool: strset: Remove unnecessary check on genl_info Date: Fri, 5 Jul 2024 15:27:03 +0200 Message-ID: <20240705132706.13588-13-maxime.chevallier@bootlin.com> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240705132706.13588-1-maxime.chevallier@bootlin.com> References: <20240705132706.13588-1-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-GND-Sasl: maxime.chevallier@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240705_062729_318057_D8CB0E18 X-CRM114-Status: GOOD ( 13.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org All call paths coming from genetlink initialize the genl_info structure, so that command handlers may use them. Remove an un-needed check for NULL when crafting error messages in the strset command. This prevents smatch from assuming this pointer may be NULL, and therefore warn if it's being used without a NULL check. Signed-off-by: Maxime Chevallier Reported-by: Simon Horman Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202407030529.aOYGI0u2-lkp@intel.com/ --- net/ethtool/strset.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ethtool/strset.c b/net/ethtool/strset.c index c678b484a079..56b99606f00b 100644 --- a/net/ethtool/strset.c +++ b/net/ethtool/strset.c @@ -289,8 +289,7 @@ static int strset_prepare_data(const struct ethnl_req_info *req_base, for (i = 0; i < ETH_SS_COUNT; i++) { if ((req_info->req_ids & (1U << i)) && data->sets[i].per_dev) { - if (info) - GENL_SET_ERR_MSG(info, "requested per device strings without dev"); + GENL_SET_ERR_MSG(info, "requested per device strings without dev"); return -EINVAL; } } -- 2.45.1