From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76B5EC30658 for ; Fri, 5 Jul 2024 11:32:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZsViN59W6qMf/mS+MNMH3PMMvUGwpG61clKEaWdUd48=; b=OK8+iWAeQdeA60DjIHb903g9NZ ATbx2/uDxbsrvYi2Pebjb6//pDhY4UFEktD+gc2Olig7NCY71pdwE+oODJbMD7mL4SAGtgKXzk098 An1PfZZNDlaOZkRkhPW5KVuxEgOJV6UAhZObcuDUfz6srKhM021TzzPDmtT2D+1Xf+CKFnUDCb6vd Gsr+7I9KHpOj6HkEWmgJOYz+Jas/OU6ME/OKY4SHNwYFq77tu6rrEdWS0jHDf0OA/+Dh9LO2p4tZ4 QpJlLQZ9hd2sE39w7+OuPgxFt+uMNmecLeny2Uu/ew/f75hx5I3cy2PjBC2CSHGR/v+z7hFbQokcJ MV84ph7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPhAs-0000000Fo0M-1D1T; Fri, 05 Jul 2024 11:32:22 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPhAd-0000000FnxP-3xpS; Fri, 05 Jul 2024 11:32:09 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 8C2832000C; Fri, 5 Jul 2024 11:32:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1720179123; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZsViN59W6qMf/mS+MNMH3PMMvUGwpG61clKEaWdUd48=; b=cOBxOY8+JvnXcaqpYardXjxv6JGoZAAHi9BSk1DJMLh6OtxUT0QiBTMYviE8ISc3OA+TTt KHR4DmAeL0da+lyIAqpKcaLX15mbFKCA31+avHflmhs9KzOiRhhnDwzuyFbbsyI1dJK7uO wxj3/0Ubx4/U11lKDTqddlIXJqttq7BEzdrm5KWB0BdAM8JnPgGlJVU01prpy6XJCnac+F aOM9uMdr6Y1j+gr9OwZDCvnt++THPMJZlPIjZDjmfLvq35h4CP4g31qU2KTXAqk1yebEz9 AP58NYmPCFsOCMykZU2rWvo9/1MrDX7/DtpvBNWy/q1j0sFnqLvMDsMlNa6y7g== Date: Fri, 5 Jul 2024 13:32:01 +0200 From: Miquel Raynal To: Piotr Wojtaszczyk Cc: dan.carpenter@linaro.org, Richard Weinberger , Vignesh Raghavendra , Vladimir Zapolskiy , Arnd Bergmann , Yangtao Li , Li Zetao , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: rawnand: lpx32xx: Fix dma_request_chan() error checks Message-ID: <20240705133201.023cf3c7@xps-13> In-Reply-To: <20240705093851.18107-1-piotr.wojtaszczyk@timesys.com> References: <20240705093851.18107-1-piotr.wojtaszczyk@timesys.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240705_043208_137358_3FDBB7F7 X-CRM114-Status: UNSURE ( 6.85 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Piotr, piotr.wojtaszczyk@timesys.com wrote on Fri, 5 Jul 2024 11:38:47 +0200: > The dma_request_chan() returns error pointer in case of error, while > dma_request_channel() returns NULL in case of error therefore different > error checks are needed for the two. >=20 > Fixes: 7326d3fb1ee3 ("mtd: rawnand: lpx32xx: Request DMA channels > using DT entries") Pleae don't split the commit title over two lines. Missing: Cc: stable. > Signed-off-by: Piotr Wojtaszczyk Thanks, Miqu=C3=A8l