From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55F73C3271E for ; Fri, 5 Jul 2024 19:07:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=g6AJVIOtRk0hC3xkG4BfQLATSbXs6FhUqBh15NKA/ys=; b=AbYEgCaKj8Orjf0ozYyy4WLQe+ n7/W6tcNv75iqZS2LagUp+Uc33iRJNLgk1KKN+wckzGcRieJdlUcUt3xWjpjM4/kop4QOP7bI/uUH z8uChMWEU1W9gJPQcZH+EectnoBaWK3y16VkXfhXRNt2s1GeLqOnwZSKE9lLCFDJ7ZGQTZL+nJxhu LiGha9drkuURY+EGt48aDuGPVMquNxdcpOxxX4u6OvPOWL5bY14QnA6qvNu4a7jzn2V9cLZLrULwg /DmYccnIykQJ+vZIrOKvIgIri/NFXyYovR2115897BfQFdbJF5NCNJVM9i7XDo1EwQsYGLWVPMFDf MbNch+4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPoH0-0000000Gge8-1Avm; Fri, 05 Jul 2024 19:07:10 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPoGm-0000000Ggbz-1DxA for linux-arm-kernel@lists.infradead.org; Fri, 05 Jul 2024 19:06:58 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id AD414CE10F6; Fri, 5 Jul 2024 19:06:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD784C116B1; Fri, 5 Jul 2024 19:06:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720206411; bh=j4MuF92z2EKiY/5L3DApQW0zmVLPdA45D4u81qgwpWQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KDvWHpRw/lmPxOGy4hO9IQckVgCvC+okPPJwvp9vG2ReHcDE4a6tQ8GYV/gNaAofE K1dHeJwjGPjtLtdKwJOfKVzv7NHqtPsPVPxUzZysovrpz5iY8q+rRhWBIg8XpCtAig FTo0qy+gNIUHTNZSAv9LGVH7xCadznpA8LtHsicoDtO37GaLIwhC8ZQV7rboD11r2r tZwBe48M0fMYDVLAqbcISE4qKtZoZ6MFfP7bJA9beaPa4NxULuZ7YuRUiWsL7WwRF6 ZuZ2NREAg3Xtn8RK/BwvdwBbn6ZtyscQvTjRo7oLwVBKYY6/nJwah/opr8KkFmjcIq 1W3fV+n3QdgBw== Date: Fri, 5 Jul 2024 20:06:44 +0100 From: Simon Horman To: Lorenzo Bianconi Cc: netdev@vger.kernel.org, nbd@nbd.name, lorenzo.bianconi83@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, conor@kernel.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, upstream@airoha.com, angelogioacchino.delregno@collabora.com, benjamin.larsson@genexis.eu, rkannoth@marvell.com, sgoutham@marvell.com, andrew@lunn.ch, arnd@arndb.de Subject: Re: [PATCH v5 net-next 2/2] net: airoha: Introduce ethernet support for EN7581 SoC Message-ID: <20240705190644.GB1480790@kernel.org> References: <18e837f0f9377b68302d42ec9174473046a4a30a.1720079772.git.lorenzo@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18e837f0f9377b68302d42ec9174473046a4a30a.1720079772.git.lorenzo@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240705_120656_708785_63394501 X-CRM114-Status: GOOD ( 14.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 04, 2024 at 10:08:11AM +0200, Lorenzo Bianconi wrote: > Add airoha_eth driver in order to introduce ethernet support for > Airoha EN7581 SoC available on EN7581 development board (en7581-evb). > en7581-evb networking architecture is composed by airoha_eth as mac > controller (cpu port) and a mt7530 dsa based switch. > EN7581 mac controller is mainly composed by Frame Engine (FE) and > QoS-DMA (QDMA) modules. FE is used for traffic offloading (just basic > functionalities are supported now) while QDMA is used for DMA operation > and QOS functionalities between mac layer and the dsa switch (hw QoS is > not available yet and it will be added in the future). > Currently only hw lan features are available, hw wan will be added with > subsequent patches. > > Tested-by: Benjamin Larsson > Signed-off-by: Lorenzo Bianconi ... > +static const char * const airoha_ethtool_stats_name[] = { > + "tx_eth_pkt_cnt", > + "tx_eth_byte_cnt", > + "tx_ok_pkt_cnt", > + "tx_ok_byte_cnt", > + "tx_eth_drop_cnt", > + "tx_eth_bc_cnt", > + "tx_eth_mc_cnt", > + "tx_eth_lt64_cnt", > + "tx_eth_eq64_cnt", > + "tx_eth_65_127_cnt", > + "tx_eth_128_255_cnt", > + "tx_eth_256_511_cnt", > + "tx_eth_512_1023_cnt", > + "tx_eth_1024_1518_cnt", > + "tx_eth_gt1518_cnt", > + "rx_eth_pkt_cnt", > + "rx_eth_byte_cnt", > + "rx_ok_pkt_cnt", > + "rx_ok_byte_cnt", > + "rx_eth_drop_cnt", > + "rx_eth_bc_cnt", > + "rx_eth_mc_cnt", > + "rx_eth_crc_drop_cnt", > + "rx_eth_frag_cnt", > + "rx_eth_jabber_cnt", > + "rx_eth_lt64_cnt", > + "rx_eth_eq64_cnt", > + "rx_eth_65_127_cnt", > + "rx_eth_128_255_cnt", > + "rx_eth_256_511_cnt", > + "rx_eth_512_1023_cnt", > + "rx_eth_1024_1518_cnt", > + "rx_eth_gt1518_cnt", > +}; Hi Lorenzo, Sorry for not noticing this earlier. It seems to me that some of the stats above could use standard stats, which is preferred. Basically, my understanding is that one should: 1. Implement .ndo_get_stats64 (that seems relevant here) 2. As appropriate implement ethtool_stats non-extended stats operations (perhaps not relevant here) 3. Then implement get_ethtool_stats for what is left over ...