From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED013C3271E for ; Mon, 8 Jul 2024 20:05:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2Nmrr/ydyOne/bfaoLK5IyMhcA2+ffJcvdeBjNKpVVI=; b=Y4PrCp49U0ysd5k4G6blLrTQ5j CoL/A0pdDPrPwAo6tTX9rRz/v0DVgfVY65uqlW0fUSGEywSKyJ/wAtvzkgU8l/+1zjgjZ9lbUZ/gE V7aeHmN+sfoTzptjeyvW7Vx+cbbbUavVGeoVrGTgRgzeBZhzRdjdTxQhhu2LvKwbivT+3wQZzzA8w zuc3RPmFgEyV2RdSTjLKc9302f2hF2gr+zXmXKujQi3ErDOROQYYDVhwz6hBkUxeUjJapCpfAl1vz l8Aj6pcKkNHGtDuBO5W/AbDDqzAsQ+sTJEYs5YRCNkHY9m2BzyfWrU5zzeBPoHkS437IDRRtLnBq7 BDyNQ9/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sQubS-00000004uoZ-2FiM; Mon, 08 Jul 2024 20:04:50 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sQubD-00000004ujH-2Dnu for linux-arm-kernel@lists.infradead.org; Mon, 08 Jul 2024 20:04:36 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id F204461070; Mon, 8 Jul 2024 20:04:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74967C116B1; Mon, 8 Jul 2024 20:04:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720469072; bh=+LGYnoamoS4zfZqMrzKzYDviwFlUv6xLADZa36LTO0A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S3PWHRlJ0VCjKO1lj50fEwf/58isiHjCmzm7NgA9+k3pMwfnIopSOatyfxItxA4st Rnft84KW6cOJ3zTX2writ+/UVW1fs/hqOqmNiCrIpTIGQA0Lr9EnJVk7dhEHKVU/aY LGvP6aGWDFLnFyX9uqpf6hPRdx7IAAhydYmOF7CXvA7DP5Z1rJHFVD8lrkTp+i0t7o ZOoa75Ju8biYaHc2XvmaoeQoR3pzMTzomvqGPSII2E+bcdc2FwvhixjGxcUvu/BuV8 v2bVClheX+wE9OOOn55kW2Wq8PdUvmc6TJSDDvYQiVbEGpcwZaWivSw5SmL27cGG1x 1wnkCCu8XVFGg== Date: Mon, 8 Jul 2024 14:04:31 -0600 From: Rob Herring To: Liu Ying Cc: Krzysztof Kozlowski , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, tglx@linutronix.de Subject: Re: [PATCH 01/10] dt-bindings: display: imx: Add some i.MX8qxp Display Controller processing units Message-ID: <20240708200431.GA3492466-robh@kernel.org> References: <20240705090932.1880496-1-victor.liu@nxp.com> <20240705090932.1880496-2-victor.liu@nxp.com> <9a911f88-7fbf-4484-997c-98b6c3ec045b@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9a911f88-7fbf-4484-997c-98b6c3ec045b@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240708_130435_654048_701F5E0F X-CRM114-Status: GOOD ( 13.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 08, 2024 at 02:30:37PM +0800, Liu Ying wrote: > On 07/07/2024, Krzysztof Kozlowski wrote: > > On 05/07/2024 11:09, Liu Ying wrote: > >> Freescale i.MX8qxp Display Controller is implemented as construction set of > >> building blocks with unified concept and standardized interfaces. > >> > >> Document some processing units to support two display outputs. > > > > > >> +maintainers: > >> + - Liu Ying > >> + > >> +properties: > >> + compatible: > >> + const: fsl,imx8qxp-dc-tcon > >> + > >> + reg: > >> + maxItems: 1 > >> + > >> + fsl,dc-tc-id: > >> + description: Timing Controller unit instance number > > > > No instance numbering. This applies to your entire patchset. > > Then, I'll call of_alias_get_id() from the drivers to get > instance number instead. Ideally, no. > As i.MX8qm SoC embeds two Display Controllers, the alias > stem would contain the Display Controller instance > number, like "dc0-tcon" and "dc1-tcon". Is this ok? The format of aliases is fooN, so no. Aliases should also be generic rather than vendor specific. If you need to describe the connection of components in the display pipeline, then use the graph binding. Rob