From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 166D1C2BD09 for ; Tue, 9 Jul 2024 06:54:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jY8ql+lO7Zuuz/RXqNh0ifBIxcIodHpwM/3VOtFolmk=; b=fWRx1M9S/8hxUdR2NfynPwQ05B +wNPkqYkKrml0+8X1kpExz2bKGA0LoZtTjoFkRYHoe7+mukvg6oHXDdJNKzBM79ZZZUw4XnChK6AT sodu/u7PQmyaEvqshA+yycwJZiAozUQy3De+We8VN7MmiIHSZMMYAC0L1FKbOa8w66qKxvNT0mZcR LWI87pKHpBUn+qZSST0Bf4WtDtBkadiTWPix7qCDnBvTWhBRNJWl7w9Qf5oE7YG/aZAw2Z1vL5PoM JFCvOS8bFib2br92AaROvnH41H44OAefb8aOeQTGxbKRkFZRFmBfDrDu0qhlafv1alw0dQI+Zv9Gr pg4FZ0ww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sR4k5-000000069gc-2vg3; Tue, 09 Jul 2024 06:54:25 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sR4jp-000000069fU-3buL for linux-arm-kernel@lists.infradead.org; Tue, 09 Jul 2024 06:54:11 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 37ADDCE0685; Tue, 9 Jul 2024 06:54:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75ABBC3277B; Tue, 9 Jul 2024 06:54:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720508047; bh=DwiR9V/FvyjvsVGXOhEpXtv/N9C3I30/RD/LCnkwjQY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KgPG1DW89jrEeZEDqxOLvEqjwzFXb2hb4Ct1bXu5bLOMM8nKorJOMqC0xKj18ZR/7 IOwfJqVymtChZHPHsi3WWUVPHGISN/MH346Z4Re82Z+fBHsuFRXWE5mrEZyUK1aRQD m5xFyMEokdIk3VglXepOJBlmMQ9raJny0Cw+RoP0vCPXbdidjDwLOFAVFAmXGM/H1a BHuHiW87buMS3sgCbeR4g4dAwYlWQR6PB637d3cd+0jPyVoKAf+iKVT8rAIpbl+w5E Xb2bGIuzIZ9mnnNV3QBAMe/X/GFGlnLAgK1TVbwBzyxVKiUETdPYvQ/C2bBbnN+Rrr I30ju9I2Ugtsg== Date: Tue, 9 Jul 2024 08:54:02 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Ilpo =?UTF-8?B?SsOkcnZpbmVu?= Cc: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, arm@kernel.org, Andy Shevchenko , Hans de Goede Subject: Re: [PATCH v3 04/10] irqchip/armada-370-xp: Use BIT() and GENMASK() macros Message-ID: <20240709085402.48e90a7b@dellmb> In-Reply-To: <3ee4c786-6452-95cf-70ec-06359f1c7668@linux.intel.com> References: <20240708151801.11592-1-kabel@kernel.org> <20240708151801.11592-5-kabel@kernel.org> <3ee4c786-6452-95cf-70ec-06359f1c7668@linux.intel.com> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240708_235410_103491_C8391C62 X-CRM114-Status: GOOD ( 10.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 8 Jul 2024 19:27:52 +0300 (EEST) Ilpo J=C3=A4rvinen wrote: > On Mon, 8 Jul 2024, Marek Beh=C3=BAn wrote: >=20 > > Use the BIT() and GENMASK() macros where appropriate. > >=20 > > Signed-off-by: Marek Beh=C3=BAn > > Reviewed-by: Andrew Lunn =20 >=20 > Are #includes missing for GENMASK() and BIT()? (Or is this based on some= =20 > tree which already has them?) #include was added in another patch that was already accepted to tip.git irq/core branch (and merged into tip.git master branch): https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=3D= 986b6ad0c4c653940fab7e5decf0d847670bf407 Marek