From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB0A9C3271E for ; Tue, 9 Jul 2024 02:14:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tUJk5cdd3SYgBT6mXktVY0iylI5j6aUAHw71DNobdU8=; b=WiT5D4iKGf6pQc2rhJeBpN3Bma COYuxlBGa4fWgLX1rdFvyciUoSnZWt7YxN/Q7l1tmapQXc5B6Qh59aSgKzucyTldNn+i/WnjFEk2h Word+lk5IpttJKU91xnhI++wszeb6yrtt8tK+L7ZJ3li2W6nc1i2tx2/nOowLyvmkoy2UP8rGFazk KbkIC6HEpE/xOvQtNuSSrcNa/LuarZCgq0EJjjI7cAlynRd3AxxyQ2bVIhKeFBsngHsJmFc8JEDGI aAxogFHtt5isf8d47GO67bql9UtvX9dbrOj4ZpDNpYn4/cIdE6xzqp/Of6+V0Lg3MvBFMFsE0vQlC AgTChxGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sR0NJ-00000005cXq-0BFv; Tue, 09 Jul 2024 02:14:37 +0000 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sR0N2-00000005cSl-3ZgJ for linux-arm-kernel@lists.infradead.org; Tue, 09 Jul 2024 02:14:22 +0000 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1fb70169c23so13301055ad.1 for ; Mon, 08 Jul 2024 19:14:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720491260; x=1721096060; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=tUJk5cdd3SYgBT6mXktVY0iylI5j6aUAHw71DNobdU8=; b=CB+N6f0C2uYSmXidlNLy/OwjwhAcPlfcAcVmuX589kOZdXcWWCWh9awlOxaOcxgGK7 SzxAzVvmpxusreukjA3SCwC0KYUg80PWwdzkJeCpbRNwFUCmLZfcJh28DA7wSOR45oeo J999AT5J2Gy8+AcfONeVMXaKo51UkENPwcOXDtp1+G+NsJo3aD9qQk/Jh1NneiA92Ls7 +dm+xUZpvoeNwVM73guOAs95KrZlq3MfTIZHokskE3mRCNn9uORQfqEZdWRHGftTvpgA I3qYatkYTamcCVMOijrvGXQSgcNjGJJ6xrlC3HND9B/Og2uOh796qGTbocIdAOZSN0Pg 64HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720491260; x=1721096060; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tUJk5cdd3SYgBT6mXktVY0iylI5j6aUAHw71DNobdU8=; b=rg/oAtk/0gsQyqkpMm4L0eKUDYgdNLv1srKW9nZduwvJT+TXT59EQDYroc0UJ4zKOW dEOOpeDzZxZGEkJ6IBKMhLIMClnzGim+QZqmwWBtOLigVQ5nQqFqRjx8K6vNHSL+23vX gssbvZQtVuMwxVR2jtwBsS9OrSg2lPdTu8WMr9JpLfV3gIWwMhcQJdjOlJtuvn2V733q SNga5ZxLPxpma36+DhH8AcukCmio7u87tRxF8kmKwVU/3XKOU7wAcNl07OwmMnT8gO1c 1Ln0HoLWG9W7lDxlpkXtbPnol9UyIICkdiyjely372LLJX4ZHiehrEWkCQZn/9Xt64f3 zvvA== X-Forwarded-Encrypted: i=1; AJvYcCVmt6RsA+RWJhfVWwgv/bkTXEZ7obAh+afhPzw1aKU4YvAIP8GhiPaGomo/HUxwp6NCRK1bsAz0k+ZudSQ3uMEP1kpGWLooGyo5labHt3vQdbmr/XQ= X-Gm-Message-State: AOJu0YwOJOFIuGBBNsfHzQU3q+r8AQ3puna1KNNi+xsIfaxX5JF+Wb1J xYeszw8QJeoqus2FEA34Qm53TkujBvSxpiY5YmThAF3UUzIaP7kYoIFFng== X-Google-Smtp-Source: AGHT+IGifYCUjDlpdABP2FmVQ9Uu47bpzw+e6ONUof7UeA6cbyy75OUBvdWUMp43MfpzKyh1ULJeBQ== X-Received: by 2002:a17:903:2308:b0:1fb:8c35:6036 with SMTP id d9443c01a7336-1fbb6cda8e5mr9793955ad.5.1720491259723; Mon, 08 Jul 2024 19:14:19 -0700 (PDT) Received: from localhost ([129.146.253.192]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fbb6a28f8esm5179775ad.64.2024.07.08.19.14.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jul 2024 19:14:19 -0700 (PDT) Date: Tue, 9 Jul 2024 10:14:07 +0800 From: Furong Xu <0x1207@gmail.com> To: Andrew Lunn Cc: "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xfr@outlook.com, rock.xu@nio.com Subject: Re: [PATCH net-next v1] net: stmmac: Refactor Frame Preemption(FPE) implementation Message-ID: <20240709101407.00005199@gmail.com> In-Reply-To: <7cde7743-2a8c-4d12-aecb-d1e50d5099ea@lunn.ch> References: <20240708082220.877141-1-0x1207@gmail.com> <7cde7743-2a8c-4d12-aecb-d1e50d5099ea@lunn.ch> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.34; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240708_191420_931904_49EA007A X-CRM114-Status: GOOD ( 17.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 8 Jul 2024 20:44:31 +0200 Andrew Lunn wrote: > > +static void fpe_configure(struct stmmac_priv *priv, struct stmmac_fpe_cfg *cfg, > > + u32 num_txq, u32 num_rxq, bool enable) > > +{ > > + u32 value; > > + > > + if (enable) { > > + cfg->fpe_csr = FPE_CTRL_STS_EFPE; > > + if (priv->plat->has_xgmac) { > > + value = readl(priv->ioaddr + XGMAC_RXQ_CTRL1); > > + value &= ~XGMAC_FPRQ; > > + value |= (num_rxq - 1) << XGMAC_FPRQ_SHIFT; > > + writel(value, priv->ioaddr + XGMAC_RXQ_CTRL1); > > + } else if (priv->plat->has_gmac4) { > > + value = readl(priv->ioaddr + GMAC_RXQ_CTRL1); > > + value &= ~GMAC_RXQCTRL_FPRQ; > > + value |= (num_rxq - 1) << GMAC_RXQCTRL_FPRQ_SHIFT; > > + writel(value, priv->ioaddr + GMAC_RXQ_CTRL1); > > + } > > Since you are using a structure of function pointers, it would seem > more logical to have a fpe_xgmac_configure() and a > fpe_gmac4_configure(), and then xgmac_fpe_ops and gmac4_fpe_ops. > > > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > @@ -974,8 +974,7 @@ static void stmmac_fpe_link_state_handle(struct stmmac_priv *priv, bool is_up) > > bool *hs_enable = &fpe_cfg->hs_enable; > > > > if (is_up && *hs_enable) { > > - stmmac_fpe_send_mpacket(priv, priv->ioaddr, fpe_cfg, > > - MPACKET_VERIFY); > > + stmmac_fpe_send_mpacket(priv, priv, fpe_cfg, MPACKET_VERIFY); > > passing priv twice looks very odd! It makes me think the API is > designed wrong. This could be because of the refactoring changes you > made? Maybe add another patch cleaning this up? Hi Andrew Thanks for your comments. This patch is almost a clone of "net: stmmac: Refactor EST implementation" https://github.com/torvalds/linux/commit/c3f3b97238f6fd87b9d90b9a995ee5e69f751a74 Many decisions were made based on that patch. I will submit a new patchset with splited patches and make function callbacks more logical.