From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A410DC3DA41 for ; Tue, 9 Jul 2024 11:36:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jjf50ESvHnEK2z9lV8EITYgyBThg/spTlXOdeWwsvgw=; b=uRkdTfaUDl6clyzuTDfZpQN34E mPlOyDOcf/3fbOlfNdc6FvRGrfl06I+xxY1hELkMC2TF5UBud4zWhFJiI/dEDjO4WYjyiEChPQQoU VmvIt/UrNbsuwaNEv9y1reSx6ilnHRyyM4Z9JuKaSXiPnOGzUoWVOPAn2RiI1mnKOJunaC0M7vbfQ XSIPkgV27UV1gz/U4S9P/8B8J+nnsY0TjW5iqkc/r9MPW3ussufS0Fqs/MoUk6185vU/d9IwtjHBF Xj7rCib09SubntPC70pzv7yQ5FpzofRr7+ayDKZy4YZNN+3d+ojTUBbomnOqHIQ5D2owxE8eiCPR/ gOhPKn9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sR98h-00000006zzH-3SrX; Tue, 09 Jul 2024 11:36:07 +0000 Received: from mail.alien8.de ([2a01:4f9:3051:3f93::2]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sR98R-00000006zue-2BpB for linux-arm-kernel@lists.infradead.org; Tue, 09 Jul 2024 11:35:53 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 4028240E0192; Tue, 9 Jul 2024 11:35:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=pass (4096-bit key) header.d=alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id VQrDMEj5bBPf; Tue, 9 Jul 2024 11:35:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1720524944; bh=jjf50ESvHnEK2z9lV8EITYgyBThg/spTlXOdeWwsvgw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b1mg5cSmDHgOzafwvedRIl52gqf+ZMalALTTzwCALau9QDX1Mzla6UQiLoM//w9b+ Dg0Y2Es1cko0pUOUoTV+GJUxYwjVjv/JVm83w6f1byyDUkJxFofiNbKxUH2nwrI4sR ka5UANapE8wdXMb3wyHRLNHMd3TCOc0V4rroVcbWJvAj+C4L5KCO2H5iMFrFdFU6PG xGcvhB5LIYzJ9s29oQneU3d1RQbRZKInL+xq0xj9AGrdMaZNwDeX57c+8vq4owiN2+ tSo+lUU2r3IysPvihkuQv0JFTskKoWvwkWIm8OVjmeFzmByKIeDAk35xAKQ8konMM6 ocmWELzzHI2ndIwftSI0+L1f61hHnAqCnsPSvMIGzqg6sWpV10wFSX+QQEOQxC1P77 b9xHoxeHnV7UcRXI4Rgj2b08yYtl7PMOImvzjHlqRW7SR22WVwGnhCxRuMOK6JOwBa b3YaSenmHxdfWRyM4ImahrWDfNhxahVKHKNr0Ic6Bq6Ghjy40EV64bOGgY5SqXeI5+ vaHhxSpTka4fa+bzRZVsngXe8mObIX3PVQH/su/oxie4KmNBd4LMHbn4+5RGvxvbQL 1p1+j2/pXl50xhbYTdZvk4wvrVej3qRvZ4Ot5/lf7eL7idCbzxX5Ld4dZt+Sdr4sDk ZDaEUmEKdb3IyAhOBWpWkOEM= Received: from zn.tnic (p5de8ee85.dip0.t-ipconnect.de [93.232.238.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 7477440E0185; Tue, 9 Jul 2024 11:35:28 +0000 (UTC) Date: Tue, 9 Jul 2024 13:35:22 +0200 From: Borislav Petkov To: Serge Semin Cc: Michal Simek , Alexander Stein , Tony Luck , James Morse , Mauro Carvalho Chehab , Robert Richter , Punnaiah Choudary Kalluri , Dinh Nguyen , Shubhrajyoti Datta , Arnd Bergmann , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Borislav Petkov Subject: Re: [PATCH RESEND v6 02/18] EDAC/synopsys: Fix mci->scrub_cap field setting Message-ID: <20240709113522.GEZo0getHKGPD588S1@fat_crate.local> References: <20240627173251.25718-1-fancer.lancer@gmail.com> <20240627173251.25718-3-fancer.lancer@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240627173251.25718-3-fancer.lancer@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240709_043551_739489_71BAA777 X-CRM114-Status: GOOD ( 11.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 27, 2024 at 08:32:09PM +0300, Serge Semin wrote: > The mem_ctl_info.scrub_cap field is supposed to be set with the ECC > scrub-related flags. Instead the driver erroneously initializes it with > the SCRUB_HW_SRC flag ID. It's definitely wrong, but it hasn't caused any > problem so far since the structure field isn't used by the EDAC core. Fix > it anyway by using the SCRUB_FLAG_HW_SRC macro to initialize the field. This hasn't been used at least since it got added by commit da9bb1d27b21cb24cbb6a2efb5d3c464d357a01e Author: Alan Cox Date: Wed Jan 18 17:44:13 2006 -0800 [PATCH] EDAC: core EDAC support code AFAICT. Please remove ->scrub_cap along with enum scrub_type instead. We can always resurrect it if needed. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette