From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3B55C3DA41 for ; Tue, 9 Jul 2024 15:26:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sEP9HFUIvOyMzrlfw2zh4onk/mGWAtEnPNTkOS2BI8k=; b=3K/eNsiXk6s8heMib8aPY14m3K 4qB+fmMRnb0m3WDCGaU+UtSyiZidDqCW7SyTDmcUyCP7wPvh7K7VlLL18BDrKTb+4EhBQ4ahHhaGX zxWSV6iHkZs0Xltztw2uWp72IwqOINw1BvVfoHEfj8SkZGFiJLfLIGC4e3/ql/xumopqz8Dv/OClr ubpLY9vbmEz5KtW8VdYuGKNC92J4nzp9qRL/rRgMZoXGnH8zJJpgby4md9vmQFQ4FrXQFhovxHDys G4swpX5nDYrJpVRjYlUPj26OBke8P1dY0sLU2hWxRE3tZyEYAUeFkoCKmNOrfNXrEb+/CpJXL7y/M JmjhTHZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRCjK-00000007jKs-3o2I; Tue, 09 Jul 2024 15:26:10 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRCj4-00000007jHk-2bXd for linux-arm-kernel@lists.infradead.org; Tue, 09 Jul 2024 15:25:56 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-4266ea6a412so11472095e9.1 for ; Tue, 09 Jul 2024 08:25:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720538753; x=1721143553; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sEP9HFUIvOyMzrlfw2zh4onk/mGWAtEnPNTkOS2BI8k=; b=fbO5zGkcnwoBqgLSLnyi8ECHHQ6Ig7kqEgTIAyoqagEx1eiIs9J/o1odWY91vCIrj0 RKYiTlzeyXAYg8aT/daXudBd/ZkCEZUGr1Wzmgb568g2IVxlMSXP0WM2DIl+x8NESNrt wbKnxSLhHo5eWTs5U4PTuG2kZdID7K7hBvContDujLaHj5E800MAmffTb7JdU04z2ZDJ wSMyMojCezB+7enFsM73PTuJURdGrECk/F1TjNXiFIwHO+U9Vfafcdk3WRSSTq4oD/SX JC+XytX8LgJ+gf6gNasPi5QcxXLG6VMzS/zNHsfOH6SUXJB9X/AQCOYD4GQ2dF0PiFPq 28bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720538753; x=1721143553; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sEP9HFUIvOyMzrlfw2zh4onk/mGWAtEnPNTkOS2BI8k=; b=mVWTvCn3NyrxoMq+7I6Vo86Ro6kfZZSzZsmmpqYZsDsG8xTd0W/oMGNElUpz5jIs66 H5xXl0GbvzDowCnozqVamweiFgQWgLjlNkIfJSDgYBkNUiIyO1aqUvdiTwqv1FIsYOkh DdtsAOd6fxK6+bVVf1JETn0muxbq+T69urnfTAYsHDdLmfUqCBj7/Cm23REo9wDphf+t I/7OGBjqlDY1fzEwF0ZcXDtj3Hb4X4thgA9e8e3uPSlRGCq/3QoLAJpnBWuZpOym2qkO Z6itJAGW4rjCDFe8X3ydX35WykQZO2p1Lzdy1C2IdjzABQIeqzNBzl/+E0J9ddglgkFd drTw== X-Forwarded-Encrypted: i=1; AJvYcCUomYwgJnjpW6sukoQMJ9MnpZfxzi3R9pOd578J/W7vEI4u7B+Ak78C9VjAAGzAnbwCburTcN7gbA0X3kEaphOygXfxnjJbZq/w5sn/32YWtHPXlpo= X-Gm-Message-State: AOJu0YyeB0/tLDqelj3wzH09AIQOwL3q889ARbYKGRsS20KlD7hZqnSx 2TUoBNphoXY+zp6BJEzzmrweZOb9T1iexvuhNuXmu86sp9gZlL2M X-Google-Smtp-Source: AGHT+IGaU+IhfijAp8zflrrfJXXMbDU1JKbjE4Rpg8g3NjL5OvpVpNRl2dIMiWa8Bd6kfcsTT2jamg== X-Received: by 2002:a5d:58f1:0:b0:367:8900:c621 with SMTP id ffacd0b85a97d-367ceaca897mr1943578f8f.56.1720538752641; Tue, 09 Jul 2024 08:25:52 -0700 (PDT) Received: from skbuf ([188.25.110.57]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cdfab136sm2849553f8f.98.2024.07.09.08.25.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jul 2024 08:25:51 -0700 (PDT) Date: Tue, 9 Jul 2024 18:25:49 +0300 From: Vladimir Oltean To: Breno Leitao Cc: kernel test robot , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, kuba@kernel.org, horms@kernel.org, Roy.Pledge@nxp.com, open list Subject: Re: [PATCH 1/4] soc: fsl: qbman: FSL_DPAA depends on COMPILE_TEST Message-ID: <20240709152549.3yak6yeij7x5dlal@skbuf> References: <20240624162128.1665620-1-leitao@debian.org> <202406261920.l5pzM1rj-lkp@intel.com> <20240626140623.7ebsspddqwc24ne4@skbuf> <20240708133746.ea62kkeq2inzcos5@skbuf> <20240709135811.c7tqh3ocfumg6ctt@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240709_082554_681242_4C7E9D9B X-CRM114-Status: GOOD ( 26.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 09, 2024 at 08:15:23AM -0700, Breno Leitao wrote: > Hello Vladimir, > > On Tue, Jul 09, 2024 at 04:58:11PM +0300, Vladimir Oltean wrote: > > > On Mon, Jul 08, 2024 at 12:08:05PM -0700, Breno Leitao wrote: > > > I thought about a patch like the following (compile tested only). What > > > do you think? > > > > To be honest, there are several things I don't really like about this > > patch. > > > > - I really struggled with applying it in the current format. Could you > > please post the output of git format-patch in the future? > > This is the output of `git format-patch` shifted right by a tab. I don't want to insist too much on it, but this is not correct. In the process of shifting the patch to the right, something ate the leading space on each patch context line. The patch is ill-formatted even if the first tab is removed. Try to keep it simple and either attach it or post it without any change whatsoever. > > I have prepared and tested the attached alternative patch on a board and > > I am preparing to submit it myself, if you don't have any objection. > > Sure, not a problem. You just asked how that would be possible, and I > decided to craft patch to show what I had in mind. I am glad we have a > way moving forward. > > Thanks for solving it. I mean I did suggest dynamic allocation for the array since my first reply in this thread, which is essentially what the patch is.. Given that dynamic allocation was already mentioned and then you suggested to replace NR_CPUS with something dynamic, I took that as an alternative proposal and an invitation at using VLAs, which is what I was commenting on, and what I was saying I don't think would work. By VLAs I mean: - u16 channels[NR_CPUS]; + u16 channels[num_possible_cpus()]; Anyway...