[PATCH v2 0/2] net: stmmac: dwmac-qcom-ethqos: Add QCS9100 ethqos compatible

[PATCH v2 0/2] net: stmmac: dwmac-qcom-ethqos: Add QCS9100 ethqos compatible

[Tengfei Fan]

Introduce support for the QCS9100 SoC device tree (DTSI) and the
QCS9100 RIDE board DTS. The QCS9100 is a variant of the SA8775p.
While the QCS9100 platform is still in the early design stage, the
QCS9100 RIDE board is identical to the SA8775p RIDE board, except it
mounts the QCS9100 SoC instead of the SA8775p SoC.

The QCS9100 SoC DTSI is directly renamed from the SA8775p SoC DTSI, and
all the compatible strings will be updated from "SA8775p" to "QCS9100".
The QCS9100 device tree patches will be pushed after all the device tree
bindings and device driver patches are reviewed.

The final dtsi will like:
https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-3-quic_tengfan@quicinc.com/

The detailed cover letter reference:
https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
Changes in v2:
  - Split huge patch series into different patch series according to
    subsytems
  - Update patch commit message

prevous disscussion here:
[1] v1: https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/

---
Tengfei Fan (2):
      dt-bindings: net: qcom,ethqos: add description for qcs9100
      net: stmmac: dwmac-qcom-ethqos: add support for emac4 on qcs9100 platforms

 Documentation/devicetree/bindings/net/qcom,ethqos.yaml  | 1 +
 Documentation/devicetree/bindings/net/snps,dwmac.yaml   | 2 ++
 drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 1 +
 3 files changed, 4 insertions(+)
---
base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233
change-id: 20240709-add_qcs9100_ethqos_compatible-fb5bb898ff43

Best regards,
-- 
Tengfei Fan <quic_tengfan@quicinc.com>

[PATCH v2 1/2] dt-bindings: net: qcom,ethqos: add description for qcs9100

[Tengfei Fan]

Add the compatible for the MAC controller on qcs9100 platforms.
QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
platform use non-SCMI resource. In the future, the SA8775p platform will
move to use SCMI resources and it will have new sa8775p-related device
tree. Consequently, introduce "qcom,qcs9100-ethqos" to describe non-SCMI
based ethqos.

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
 Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 1 +
 Documentation/devicetree/bindings/net/snps,dwmac.yaml  | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
index 6672327358bc..8ab11e00668c 100644
--- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
@@ -20,6 +20,7 @@ properties:
   compatible:
     enum:
       - qcom,qcs404-ethqos
+      - qcom,qcs9100-ethqos
       - qcom,sa8775p-ethqos
       - qcom,sc8280xp-ethqos
       - qcom,sm8150-ethqos
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index 0ab124324eec..291252f2f30d 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
@@ -67,6 +67,7 @@ properties:
         - loongson,ls2k-dwmac
         - loongson,ls7a-dwmac
         - qcom,qcs404-ethqos
+        - qcom,qcs9100-ethqos
         - qcom,sa8775p-ethqos
         - qcom,sc8280xp-ethqos
         - qcom,sm8150-ethqos
@@ -611,6 +612,7 @@ allOf:
               - ingenic,x1830-mac
               - ingenic,x2000-mac
               - qcom,qcs404-ethqos
+              - qcom,qcs9100-ethqos
               - qcom,sa8775p-ethqos
               - qcom,sc8280xp-ethqos
               - qcom,sm8150-ethqos

-- 
2.25.1

[PATCH v2 2/2] net: stmmac: dwmac-qcom-ethqos: add support for emac4 on qcs9100 platforms

[Tengfei Fan]

QCS9100 uses EMAC version 4, add the relevant defines, rename the
has_emac3 switch to has_emac_ge_3 (has emac greater-or-equal than 3)
and add the new compatible.
QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
platform use non-SCMI resource. In the future, the SA8775p platform will
move to use SCMI resources and it will have new sa8775p-related device
tree. Consequently, introduce "qcom,qcs9100-ethqos" to the ethqos device
match table.

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
 drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
index e8a1701cdb7c..f3c5ae54bd5e 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
@@ -864,6 +864,7 @@ static int qcom_ethqos_probe(struct platform_device *pdev)
 
 static const struct of_device_id qcom_ethqos_match[] = {
 	{ .compatible = "qcom,qcs404-ethqos", .data = &emac_v2_3_0_data},
+	{ .compatible = "qcom,qcs9100-ethqos", .data = &emac_v4_0_0_data},
 	{ .compatible = "qcom,sa8775p-ethqos", .data = &emac_v4_0_0_data},
 	{ .compatible = "qcom,sc8280xp-ethqos", .data = &emac_v3_0_0_data},
 	{ .compatible = "qcom,sm8150-ethqos", .data = &emac_v2_1_0_data},

-- 
2.25.1

Re: [PATCH v2 2/2] net: stmmac: dwmac-qcom-ethqos: add support for emac4 on qcs9100 platforms

[Andrew Halaney]

These patches are for netdev, so you need to follow the netdev
rules, i.e. the subject should be have [PATCH net-next] in it, etc as
documented over here:

    https://docs.kernel.org/process/maintainer-netdev.html#tl-dr

On Tue, Jul 09, 2024 at 10:13:18PM GMT, Tengfei Fan wrote:
> QCS9100 uses EMAC version 4, add the relevant defines, rename the
> has_emac3 switch to has_emac_ge_3 (has emac greater-or-equal than 3)
> and add the new compatible.

This blurb isn't capturing what's done in this change, please make it
reflect the patch.

Thanks,
Andrew

Re: [PATCH v2 2/2] net: stmmac: dwmac-qcom-ethqos: add support for emac4 on qcs9100 platforms

[Andrew Lunn]

On Tue, Jul 09, 2024 at 09:40:55AM -0500, Andrew Halaney wrote:
> These patches are for netdev, so you need to follow the netdev
> rules, i.e. the subject should be have [PATCH net-next] in it, etc as
> documented over here:
> 
>     https://docs.kernel.org/process/maintainer-netdev.html#tl-dr
> 
> On Tue, Jul 09, 2024 at 10:13:18PM GMT, Tengfei Fan wrote:
> > QCS9100 uses EMAC version 4, add the relevant defines, rename the
> > has_emac3 switch to has_emac_ge_3 (has emac greater-or-equal than 3)
> > and add the new compatible.
> 
> This blurb isn't capturing what's done in this change, please make it
> reflect the patch.

Hi Tengfei

If i remember correctly, there was a similar comment made to one of
the patches in the huge v1 series.

The commit messages are very important, just as important as the code
itself. Please review them all and fixup issues like this before you
repost.

    Andrew

---
pw-bot: cr

Re: [PATCH v2 0/2] net: stmmac: dwmac-qcom-ethqos: Add QCS9100 ethqos compatible

[Simon Horman]

On Tue, Jul 09, 2024 at 10:13:16PM +0800, Tengfei Fan wrote:
> Introduce support for the QCS9100 SoC device tree (DTSI) and the
> QCS9100 RIDE board DTS. The QCS9100 is a variant of the SA8775p.
> While the QCS9100 platform is still in the early design stage, the
> QCS9100 RIDE board is identical to the SA8775p RIDE board, except it
> mounts the QCS9100 SoC instead of the SA8775p SoC.
> 
> The QCS9100 SoC DTSI is directly renamed from the SA8775p SoC DTSI, and
> all the compatible strings will be updated from "SA8775p" to "QCS9100".
> The QCS9100 device tree patches will be pushed after all the device tree
> bindings and device driver patches are reviewed.
> 
> The final dtsi will like:
> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-3-quic_tengfan@quicinc.com/
> 
> The detailed cover letter reference:
> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/
> 
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
> Changes in v2:
>   - Split huge patch series into different patch series according to
>     subsytems
>   - Update patch commit message
> 
> prevous disscussion here:
> [1] v1: https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/
> 
> ---
> Tengfei Fan (2):
>       dt-bindings: net: qcom,ethqos: add description for qcs9100
>       net: stmmac: dwmac-qcom-ethqos: add support for emac4 on qcs9100 platforms
> 
>  Documentation/devicetree/bindings/net/qcom,ethqos.yaml  | 1 +
>  Documentation/devicetree/bindings/net/snps,dwmac.yaml   | 2 ++
>  drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 1 +
>  3 files changed, 4 insertions(+)
> ---
> base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233

I'm assuming that this is a patch for net-next.
But the commit above is not present in net-next,
and this series doesn't apply to net-next.

Please rebase when preparing v3.
And please designate the target tree in the subject.

	Subject: [PATCH net-next v3] ...

Thanks!

Re: [PATCH v2 2/2] net: stmmac: dwmac-qcom-ethqos: add support for emac4 on qcs9100 platforms

[Aiqun Yu (Maria)]

On 7/9/2024 10:40 PM, Andrew Halaney wrote:
> These patches are for netdev, so you need to follow the netdev
> rules, i.e. the subject should be have [PATCH net-next] in it, etc as
> documented over here:
> 
>     https://docs.kernel.org/process/maintainer-netdev.html#tl-dr
> 

Thx very much for the detailed information.

> On Tue, Jul 09, 2024 at 10:13:18PM GMT, Tengfei Fan wrote:
>> QCS9100 uses EMAC version 4, add the relevant defines, rename the
>> has_emac3 switch to has_emac_ge_3 (has emac greater-or-equal than 3)
>> and add the new compatible.
> 
> This blurb isn't capturing what's done in this change, please make it
> reflect the patch.

There is a similar comments on [1] on another patch. Similar comments
should be taken care of next time.
https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-30-quic_tengfan@quicinc.com/
> 
> Thanks,
> Andrew
> 

-- 
Thx and BRs,
Aiqun(Maria) Yu

Re: [PATCH v2 2/2] net: stmmac: dwmac-qcom-ethqos: add support for emac4 on qcs9100 platforms

[Aiqun Yu (Maria)]

On 7/9/2024 11:33 PM, Andrew Lunn wrote:
> On Tue, Jul 09, 2024 at 09:40:55AM -0500, Andrew Halaney wrote:
>> These patches are for netdev, so you need to follow the netdev
>> rules, i.e. the subject should be have [PATCH net-next] in it, etc as
>> documented over here:
>>
>>     https://docs.kernel.org/process/maintainer-netdev.html#tl-dr
>>
>> On Tue, Jul 09, 2024 at 10:13:18PM GMT, Tengfei Fan wrote:
>>> QCS9100 uses EMAC version 4, add the relevant defines, rename the
>>> has_emac3 switch to has_emac_ge_3 (has emac greater-or-equal than 3)
>>> and add the new compatible.
>>
>> This blurb isn't capturing what's done in this change, please make it
>> reflect the patch.
> 
> Hi Tengfei
> 
> If i remember correctly, there was a similar comment made to one of
> the patches in the huge v1 series.
> 
> The commit messages are very important, just as important as the code
> itself. Please review them all and fixup issues like this before you
> repost.

Thx Andrew L for the info.
> 
>     Andrew
> 
> ---
> pw-bot: cr

-- 
Thx and BRs,
Aiqun(Maria) Yu

Re: [PATCH v2 0/2] net: stmmac: dwmac-qcom-ethqos: Add QCS9100 ethqos compatible

[Tengfei Fan]

On 7/10/2024 1:42 AM, Simon Horman wrote:
> On Tue, Jul 09, 2024 at 10:13:16PM +0800, Tengfei Fan wrote:
>> Introduce support for the QCS9100 SoC device tree (DTSI) and the
>> QCS9100 RIDE board DTS. The QCS9100 is a variant of the SA8775p.
>> While the QCS9100 platform is still in the early design stage, the
>> QCS9100 RIDE board is identical to the SA8775p RIDE board, except it
>> mounts the QCS9100 SoC instead of the SA8775p SoC.
>>
>> The QCS9100 SoC DTSI is directly renamed from the SA8775p SoC DTSI, and
>> all the compatible strings will be updated from "SA8775p" to "QCS9100".
>> The QCS9100 device tree patches will be pushed after all the device tree
>> bindings and device driver patches are reviewed.
>>
>> The final dtsi will like:
>> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-3-quic_tengfan@quicinc.com/
>>
>> The detailed cover letter reference:
>> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>> Changes in v2:
>>    - Split huge patch series into different patch series according to
>>      subsytems
>>    - Update patch commit message
>>
>> prevous disscussion here:
>> [1] v1: https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/
>>
>> ---
>> Tengfei Fan (2):
>>        dt-bindings: net: qcom,ethqos: add description for qcs9100
>>        net: stmmac: dwmac-qcom-ethqos: add support for emac4 on qcs9100 platforms
>>
>>   Documentation/devicetree/bindings/net/qcom,ethqos.yaml  | 1 +
>>   Documentation/devicetree/bindings/net/snps,dwmac.yaml   | 2 ++
>>   drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 1 +
>>   3 files changed, 4 insertions(+)
>> ---
>> base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233
> 
> I'm assuming that this is a patch for net-next.
> But the commit above is not present in net-next,
> and this series doesn't apply to net-next.
> 
> Please rebase when preparing v3.
> And please designate the target tree in the subject.
> 
> 	Subject: [PATCH net-next v3] ...
> 
> Thanks!

I willmake the correspinding modifications according to your suggestion 
in the V3 patch series.

-- 
Thx and BRs,
Tengfei Fan

Re: [PATCH v2 1/2] dt-bindings: net: qcom,ethqos: add description for qcs9100

[Tengfei Fan]

On 7/9/2024 10:13 PM, Tengfei Fan wrote:
> Add the compatible for the MAC controller on qcs9100 platforms.
> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
> platform use non-SCMI resource. In the future, the SA8775p platform will
> move to use SCMI resources and it will have new sa8775p-related device
> tree. Consequently, introduce "qcom,qcs9100-ethqos" to describe non-SCMI
> based ethqos.
> 
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
>   Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 1 +
>   Documentation/devicetree/bindings/net/snps,dwmac.yaml  | 2 ++
>   2 files changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> index 6672327358bc..8ab11e00668c 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> @@ -20,6 +20,7 @@ properties:
>     compatible:
>       enum:
>         - qcom,qcs404-ethqos
> +      - qcom,qcs9100-ethqos
>         - qcom,sa8775p-ethqos
>         - qcom,sc8280xp-ethqos
>         - qcom,sm8150-ethqos
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 0ab124324eec..291252f2f30d 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -67,6 +67,7 @@ properties:
>           - loongson,ls2k-dwmac
>           - loongson,ls7a-dwmac
>           - qcom,qcs404-ethqos
> +        - qcom,qcs9100-ethqos
>           - qcom,sa8775p-ethqos
>           - qcom,sc8280xp-ethqos
>           - qcom,sm8150-ethqos
> @@ -611,6 +612,7 @@ allOf:
>                 - ingenic,x1830-mac
>                 - ingenic,x2000-mac
>                 - qcom,qcs404-ethqos
> +              - qcom,qcs9100-ethqos
>                 - qcom,sa8775p-ethqos
>                 - qcom,sc8280xp-ethqos
>                 - qcom,sm8150-ethqos
> 

After considering the feedback provided on the subject, We have decided
to keep current SA8775p compatible and ABI compatibility in drivers.
Let's close this session and ignore all the current patches here.
Thank you for your input.

-- 
Thx and BRs,
Tengfei Fan

Re: [PATCH v2 0/2] net: stmmac: dwmac-qcom-ethqos: Add QCS9100 ethqos compatible

[Tengfei Fan]

On 7/10/2024 3:27 PM, Tengfei Fan wrote:
> 
> 
> On 7/10/2024 1:42 AM, Simon Horman wrote:
>> On Tue, Jul 09, 2024 at 10:13:16PM +0800, Tengfei Fan wrote:
>>> Introduce support for the QCS9100 SoC device tree (DTSI) and the
>>> QCS9100 RIDE board DTS. The QCS9100 is a variant of the SA8775p.
>>> While the QCS9100 platform is still in the early design stage, the
>>> QCS9100 RIDE board is identical to the SA8775p RIDE board, except it
>>> mounts the QCS9100 SoC instead of the SA8775p SoC.
>>>
>>> The QCS9100 SoC DTSI is directly renamed from the SA8775p SoC DTSI, and
>>> all the compatible strings will be updated from "SA8775p" to "QCS9100".
>>> The QCS9100 device tree patches will be pushed after all the device tree
>>> bindings and device driver patches are reviewed.
>>>
>>> The final dtsi will like:
>>> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-3-quic_tengfan@quicinc.com/
>>>
>>> The detailed cover letter reference:
>>> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/
>>>
>>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>>> ---
>>> Changes in v2:
>>>    - Split huge patch series into different patch series according to
>>>      subsytems
>>>    - Update patch commit message
>>>
>>> prevous disscussion here:
>>> [1] v1: 
>>> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/
>>>
>>> ---
>>> Tengfei Fan (2):
>>>        dt-bindings: net: qcom,ethqos: add description for qcs9100
>>>        net: stmmac: dwmac-qcom-ethqos: add support for emac4 on 
>>> qcs9100 platforms
>>>
>>>   Documentation/devicetree/bindings/net/qcom,ethqos.yaml  | 1 +
>>>   Documentation/devicetree/bindings/net/snps,dwmac.yaml   | 2 ++
>>>   drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 1 +
>>>   3 files changed, 4 insertions(+)
>>> ---
>>> base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233
>>
>> I'm assuming that this is a patch for net-next.
>> But the commit above is not present in net-next,
>> and this series doesn't apply to net-next.
>>
>> Please rebase when preparing v3.
>> And please designate the target tree in the subject.
>>
>>     Subject: [PATCH net-next v3] ...
>>
>> Thanks!
> 
> I willmake the correspinding modifications according to your suggestion 
> in the V3 patch series.

After considering the feedback provided on the subject, We have decided
to keep current SA8775p compatible and ABI compatibility in drivers.
Let's close this session and ignore all the current patches here.
Thank you for your input.

> 

-- 
Thx and BRs,
Tengfei Fan

Re: [PATCH v2 2/2] net: stmmac: dwmac-qcom-ethqos: add support for emac4 on qcs9100 platforms

[Tengfei Fan]

On 7/10/2024 11:02 AM, Aiqun Yu (Maria) wrote:
> 
> 
> On 7/9/2024 11:33 PM, Andrew Lunn wrote:
>> On Tue, Jul 09, 2024 at 09:40:55AM -0500, Andrew Halaney wrote:
>>> These patches are for netdev, so you need to follow the netdev
>>> rules, i.e. the subject should be have [PATCH net-next] in it, etc as
>>> documented over here:
>>>
>>>      https://docs.kernel.org/process/maintainer-netdev.html#tl-dr
>>>
>>> On Tue, Jul 09, 2024 at 10:13:18PM GMT, Tengfei Fan wrote:
>>>> QCS9100 uses EMAC version 4, add the relevant defines, rename the
>>>> has_emac3 switch to has_emac_ge_3 (has emac greater-or-equal than 3)
>>>> and add the new compatible.
>>>
>>> This blurb isn't capturing what's done in this change, please make it
>>> reflect the patch.
>>
>> Hi Tengfei
>>
>> If i remember correctly, there was a similar comment made to one of
>> the patches in the huge v1 series.
>>
>> The commit messages are very important, just as important as the code
>> itself. Please review them all and fixup issues like this before you
>> repost.
> 
> Thx Andrew L for the info.
>>
>>      Andrew
>>
>> ---
>> pw-bot: cr
> 

After considering the feedback provided on the subject, We have decided
to keep current SA8775p compatible and ABI compatibility in drivers.
Let's close this session and ignore all the current patches here.
Thank you for your input.

-- 
Thx and BRs,
Tengfei Fan