From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DFD0C38150 for ; Wed, 10 Jul 2024 07:58:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jL3xB5qZUeDvQW0Bt9eHIWR5Sgy7Fo6pxuuDb821234=; b=25L98jEFYvGe2Jj3dJr6TyME3H zq1P90VAWnjPFWuzE6gmlewDMaXD8UWCGF+mHcLLiay2Yc1jOor8bbOKnxRnZ+Y8foBAgrG7rUXm1 su3TYZSKHjBxK69B9/IlLSrgGMNeQ7ux0q3N/uqSbU+byXpG/iZ0gfqu3p4AdROjvz+xVIzVmMKz1 lX0mET655+yPYcXuVe0SHMzkXzaOe3Pw0vR8hCQ4i2S1UPBcuI1WpI9crgPTiIYIpL/aoaYf+pu9F agzEFonxuDlhoOqmeg+JsqgGDYwU/f1VdRJWrE3uAX0YzTKrYudOurmrHt27bhKwljAVx46zACIQS DoIOW/lQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRSCw-00000009oJA-1aa3; Wed, 10 Jul 2024 07:57:46 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRSCf-00000009oFQ-19ot for linux-arm-kernel@lists.infradead.org; Wed, 10 Jul 2024 07:57:30 +0000 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1fb72eb3143so4096275ad.1 for ; Wed, 10 Jul 2024 00:57:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720598248; x=1721203048; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=jL3xB5qZUeDvQW0Bt9eHIWR5Sgy7Fo6pxuuDb821234=; b=A/G0rjKo2gR5JXBOSg8CfuBsR+OAwgQ1mhHbWyqpjzP2wai2oUULatouGzx9SeuEJo Bcu+c2pyxONs1/FB2l/djpek4tn7yzeV6bo/XUxwBKKoPGNrPpzRLUx/qfooyyX1el4L ZRIuRzf4QHpvh1XFimkXByivOBel0cwdz/Ivbnfktv/P2Ks6CPaVjI+vEd/xQrdTcTxL cL4U7SJ2G5zVJaznG8cq9kCzLUXtq7lKlGHHIcWEZdYjclv0orqUvpXy+HiPO6KXtHbz +1v46+86GbcKztQh6pHPCFTbKSMUOKZFl4mvyYXaIpBY16KZgqKLC6Ra+P4I/aJOMyp4 IwbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720598248; x=1721203048; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jL3xB5qZUeDvQW0Bt9eHIWR5Sgy7Fo6pxuuDb821234=; b=IkWW00DG2zpi1uDwfE+NbhV5QfK8W2LYeVNvhNleMjSbVdvV/yGAEVHV9KkrnJYxey +gx3T0m2dDWJvEfHPFKNvZRouiaWteqfyMz/pWvPWNI3+wTKiR9X/8kWLjjUNUNriKES IWH5GmZBryWsYh6nFNdwXdqJSNhAprS8rZP+BLgxoDRnRHrUpPhfiuVoIJxdR9Vcy0qd k2G3Fmgg1BjqQlR3ac7cUYwi3QEMdNKtjcEep6BbpKXZVPQKe5AMU99PHK4GmMRzTp+L uTzEL4oXAbQ2gzRG96qXL9ylCRlDa+x2c2UjKHjapWKjOxA/Qx25OQQQBaUCat0Tw+hm 566w== X-Forwarded-Encrypted: i=1; AJvYcCVVnkKv9Yqf0gLH81xpYlUPSm2EKZAdGLAvJ0cBV29w3/J4S1EKl5iND4ljpwOswgwEYP+mNdr2croMCxkCt03oVokhtMe/4pLZCnHFXnUZLPwlEj4= X-Gm-Message-State: AOJu0YyFf8oqAVzZYxopH5i2foGvWVxYCLMJZWCioeljwZJWSzdeTKb2 cn9spwbWCEf2mc4VxK23db6SN3F02corthaox77f1LxmxTU2hIMu X-Google-Smtp-Source: AGHT+IEuKjHd15gR0P5vFk2U3b61+gsTLHqlQVreOnbUjVAf1fwZQtG7Ac4RBBngQ0FVGYThZcZ7bA== X-Received: by 2002:a17:902:f141:b0:1f7:1bf3:db10 with SMTP id d9443c01a7336-1fbb8015510mr44928735ad.20.1720598247862; Wed, 10 Jul 2024 00:57:27 -0700 (PDT) Received: from localhost ([129.146.253.192]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fbb6b31977sm27555975ad.287.2024.07.10.00.57.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 00:57:27 -0700 (PDT) Date: Wed, 10 Jul 2024 15:57:14 +0800 From: Furong Xu <0x1207@gmail.com> To: Vladimir Oltean Cc: Andrew Lunn , Jianheng Zhang , "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xfr@outlook.com, rock.xu@nio.com Subject: Re: [PATCH net-next v1 1/7] net: stmmac: xgmac: drop incomplete FPE implementation Message-ID: <20240710155714.000010cb@gmail.com> In-Reply-To: <20240709171018.7tifdirqjhq6cohy@skbuf> References: <20240709171018.7tifdirqjhq6cohy@skbuf> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.34; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240710_005729_354080_C7939933 X-CRM114-Status: GOOD ( 30.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Vladimir On Tue, 9 Jul 2024 20:10:18 +0300, Vladimir Oltean wrote: > Hi Andrew, Furong, > > On Tue, Jul 09, 2024 at 03:16:35PM +0200, Andrew Lunn wrote: > > On Tue, Jul 09, 2024 at 04:21:19PM +0800, Furong Xu wrote: > > > The FPE support for xgmac is incomplete, drop it temporarily. > > > Once FPE implementation is refactored, xgmac support will be added. > > > > This is a pretty unusual thing to do. What does the current > > implementation do? Is there enough for it to actually work? If i was > > doing a git bisect and landed on this patch, could i find my > > networking is broken? > > > > More normal is to build a new implementation by the side, and then > > swap to it. > > > > Andrew > > > > There were 2 earlier attempts from Jianheng Zhang @ Synopsys to add FPE > support to new hardware. > > I told him that the #1 priority should be to move the stmmac driver over > to the new standard API which uses ethtool + tc. > https://lore.kernel.org/netdev/CY5PR12MB63726FED738099761A9B81E7BF8FA@CY5PR12MB6372.namprd12.prod.outlook.com/ > https://lore.kernel.org/netdev/CY5PR12MB63727C24923AE855CFF0D425BF8EA@CY5PR12MB6372.namprd12.prod.outlook.com/ > > I'm not sure what happened in the meantime. Jianheng must have faced > some issue, because he never came back. > > I did comment this at the time: > > | Even this very patch is slightly strange - it is not brand new hardware > | support, but it fills in some more FPE ops in dwxlgmac2_ops - when > | dwxgmac3_fpe_configure() was already there. So this suggests the > | existing support was incomplete. How complete is it now? No way to tell. > | There is a selftest to tell, but we can't run it because the driver > | doesn't integrate with those kernel APIs. > > So it is relatively known that the support is incomplete. But I still > think we should push for more reviewer insight into this driver by > having access to a selftest to get a clearer picture of how it behaves. > For that, we need the compliance to the common API. > After some searching and learning about your commits for FPE using the generic framework, I think it is clear enough to me to implement the new standard driver interface which uses ethtool + tc, and then the refactor of low level FPE function can follow. Thanks.