From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05A88C3DA41 for ; Thu, 11 Jul 2024 09:59:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=f+rOWtcNHMakns+uXbqdKBVCS35CHPQfkmHF6+Zpjlk=; b=UVywZo6Xm6UBldTf764QDJcqGs ANjsV3e9XWhvPyZq5lWcKptoWX2astfZfzxQ+0IbuIbP56Ci5Yt9D9Rn1O0KYez4dd7hMJUnusXOo ZoZpdMW90fshxVEGKDYMtz+OzthCZipO7AfxT9AdIZn0d12Rm9G2bShs3SHH8QUIqE2KatXw4KEmH HIGtoObEBqIbz4e9dYz30K4hx/YAWNzf2xpRNyVqnjJkb02lriZJTvyuEy9sT5wuiFNKIhpCJHznz YasfS6blh0WzCicZPE7zwkeISSQq9CiS5bkXfv4B53NO2S9FqduroA/opXNANI3nXUT5kPSzn311Z 3ZupfLAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRqZo-0000000DQhe-2DqJ; Thu, 11 Jul 2024 09:59:00 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRqZX-0000000DQco-1IXt for linux-arm-kernel@lists.infradead.org; Thu, 11 Jul 2024 09:58:44 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id AB9FC603F7; Thu, 11 Jul 2024 09:58:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00B68C116B1; Thu, 11 Jul 2024 09:58:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720691922; bh=WuvcPyYCPZVdObRzkt1wRjrxvRBYyt8oPc8M1YvBhVY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fjUl7UzbTkgcD0Civgq2Uxe04S1u/b2s/CouNh2KieybTTl/KucwfS3DvVk/9bw6s rx26o1bt0Ua9bmgwSefq3HyJAPZkdTdd0vDQ053QjgqP2uz5juuvweRlmwtyaxS2Sl XoqaIkWf9Y4SPs4YL8+82EvPZyOJUscsGyEx1elWOlPohA5xqJMOc2y05BkbFtfs6S 72wgve9PkMUu/qF2QDn3QBJNOJfV25IQa9ktYi3U7+r0PDopXyfhTBms6Xgc3TKV42 MC8lowyAZwxe95VnPCIAyZm5gK/nOlXnaC3XfrghD/+y6Vys7qtIpJ6FLWHUP9bKIh JuFdcwI7la6HA== Date: Thu, 11 Jul 2024 10:58:34 +0100 From: Conor Dooley To: Krzysztof Kozlowski Subject: Re: [PATCH 2/4] drm/bridge: add Microchip DSI controller support for sam9x7 SoC series Message-ID: <20240711-freezing-decrease-4807d5d62f2a@spud> References: <20240704084837.168075-1-manikandan.m@microchip.com> <20240704084837.168075-3-manikandan.m@microchip.com> <9ef5a1ba-e404-46e0-8513-5fffbfb5618b@kernel.org> <4c1b7af7-e53c-492a-9c41-40cad78f7666@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EWu0S0GtGVx/Ra1x" Content-Disposition: inline In-Reply-To: <4c1b7af7-e53c-492a-9c41-40cad78f7666@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240711_025843_452502_4A85DB99 X-CRM114-Status: GOOD ( 20.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, Jason@zx2c4.com, palmer@rivosinc.com, claudiu.beznea@tuxon.dev, Laurent.pinchart@ideasonboard.com, andrzej.hajda@intel.com, Hari.PrasathGE@microchip.com, airlied@gmail.com, Manikandan.M@microchip.com, robh@kernel.org, rfoss@kernel.org, mpe@ellerman.id.au, linux@armlinux.org.uk, jernej.skrabec@gmail.com, devicetree@vger.kernel.org, conor+dt@kernel.org, tzimmermann@suse.de, arnd@arndb.de, jonas@kwiboo.se, maarten.lankhorst@linux.intel.com, mripard@kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, neil.armstrong@linaro.org, rdunlap@infradead.org, linux-kernel@vger.kernel.org, daniel@ffwll.ch, krzk+dt@kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --EWu0S0GtGVx/Ra1x Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 11, 2024 at 11:05:37AM +0200, Krzysztof Kozlowski wrote: > On 11/07/2024 10:30, Manikandan.M@microchip.com wrote: > > Hi Krzysztof, > >=20 > > On 04/07/24 4:27 pm, Krzysztof Kozlowski wrote: > >> EXTERNAL EMAIL: Do not click links or open attachments unless you know= the content is safe > >> > >> On 04/07/2024 10:48, Manikandan Muralidharan wrote: > >>> Add the Microchip's DSI controller wrapper driver that uses > >>> the Synopsys DesignWare MIPI DSI host controller bridge. > >>> > >>> Signed-off-by: Manikandan Muralidharan > >>> --- > >> > >> > >> ... > >> > >>> + > >>> +#define HSTT(_maxfreq, _c_lp2hs, _c_hs2lp, _d_lp2hs, _d_hs2lp) = \ > >>> +{ \ > >>> + .maxfreq =3D _maxfreq, \ > >>> + .timing =3D { \ > >>> + .clk_lp2hs =3D _c_lp2hs, \ > >>> + .clk_hs2lp =3D _c_hs2lp, \ > >>> + .data_lp2hs =3D _d_lp2hs, \ > >>> + .data_hs2lp =3D _d_hs2lp, \ > >>> + } \ > >>> +} > >>> + > >>> +struct hstt hstt_table[] =3D { > >> > >> So more globals? No. > >=20 > > In the sam9x7 datasheet, the high speed transition time for data and > > clock lane at different freq for the DSI controller ranges are tabulated > > with constant values. > > I referred other similar platforms for the functionality and found=20 > > similar way of implementation, only a few had equations to derive the= =20 > > low power and high speed timings.I am not able to come up with a more= =20 > > efficient method. If there is something I am missing, please suggest. > > TIA >=20 > Yeah, this should not be a global. Nothing above suggests it. I think what Krzysztof is suggesting here is use of the static keyword... >=20 > BTW, no W=3D1 clang warnings? Are you sure? >=20 > Best regards, > Krzysztof >=20 --EWu0S0GtGVx/Ra1x Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZo+sygAKCRB4tDGHoIJi 0gtxAQD5lJOy/q4aES6K9CjXBUSnOWaI63qOFMdQ616WHgo78wD9FOHchUgSltnR kDI6geXp0AJKzlBkFd7UwEarIdbUJAc= =Ikhe -----END PGP SIGNATURE----- --EWu0S0GtGVx/Ra1x--