From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7FDB8C3DA45 for ; Thu, 11 Jul 2024 15:41:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EEV07uUP6RUuuiB1O8HuQSMghmx2fzSNJLr/2unkGZI=; b=NyIRLyt5MBUPYxRdCoBzc+n3yl G/Kv8k8n4Ex+o8KfTQS6IFs0CdM7K8APl7JVeh+m4y3o8H1a4wFs/mzj8yPdXLjx3QKODCSU6OR4V 2t4K1ppBkGPMvFtBYYwYQW7kcDdxkFPmV/bsp7qCTJgApchy0QkC/SEjk1YYzfvF5a+Q9KE7YcHp4 4iTYUB7UUCTred66DDOamSNlzzSQrMldvaUuUfTpMNZr4ZpXYE+vhQw0JAA31btSe90MkFlj8Ujv8 sH26Y65Dy3jLJqZvsd4JUy4cFe7ta71ZryUsAhNetolD3FouKzOqxhum3cyc/oTkNvxQHrm6MTSug lP+CuJbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRvvB-0000000EXPn-1Bt2; Thu, 11 Jul 2024 15:41:25 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRvus-0000000EXKW-3f42 for linux-arm-kernel@lists.infradead.org; Thu, 11 Jul 2024 15:41:08 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 532ABCE18E3; Thu, 11 Jul 2024 15:41:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E65ACC116B1; Thu, 11 Jul 2024 15:41:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720712463; bh=MvnTZvYlvAJG+4eJfd/4pU9PjPA3LpeEu0NyvpIktlM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tedqk7W41opP+LCc6/iGXIb8iBb6poMiWyRHQfNmGHiDC5JE6sE4R+hFX0Inzlav9 FPmAbdCJ3zDU9xDuZtvObcQj55D/8ZXkNi92bc7wpDuNvMf8ak/hVsc1aOBky+vKrD dErKdJnFzdWoKJQzO829pV5WH/FxBIOR3HugSSHjlXW6+T0RXiJwV+sWXNwPR25ON/ Q+yiIxe23SD/zVZB6vuLiGSvQwyTJJRKwWafsfoFAfyR1T1g1DKmYsVhHsxIQAYIW2 IzeS/01teXFWubsoK203q2Uhv5qwSECzrIkVcFgEJcshVlwMe7Fa2lR2aspPTBsmr9 kT9MlQc36cwWQ== Date: Thu, 11 Jul 2024 16:40:58 +0100 From: Conor Dooley To: Nicolas Ferre Cc: Varshini.Rajendran@microchip.com, tglx@linutronix.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, alexandre.belloni@bootlin.com, claudiu.beznea@tuxon.dev, Dharma.B@microchip.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, maz@kernel.org Subject: Re: [PATCH v5 15/27] dt-bindings: interrupt-controller: Document the property microchip,nr-irqs Message-ID: <20240711-molasses-shut-1fc7d9fe6a0e@spud> References: <20240703102011.193343-1-varshini.rajendran@microchip.com> <20240703102814.196063-1-varshini.rajendran@microchip.com> <20240703-dentist-wired-bdb063522ef7@spud> <82ca4f3d-fa78-4617-823e-69f16a2c3319@microchip.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nDBBa4rtrpxCXD0u" Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240711_084107_295749_5B3737E4 X-CRM114-Status: GOOD ( 36.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --nDBBa4rtrpxCXD0u Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 11, 2024 at 02:42:01PM +0200, Nicolas Ferre wrote: > Answering to myself (again) and to Conor... >=20 > On 09/07/2024 at 16:06, Nicolas.Ferre@microchip.com wrote: > > On 09/07/2024 at 08:13, Varshini Rajendran - I67070 wrote: > > > On 03/07/24 9:11 pm, Conor Dooley wrote: > > > > On Wed, Jul 03, 2024 at 03:58:14PM +0530, Varshini Rajendran wrote: > > > > > Add the description and conditions to the device tree documentati= on > > > > > for the property microchip,nr-irqs. > > > > >=20 > > > > > Signed-off-by: Varshini Rajendran > > > > This needs to be part of patch 14. > > > >=20 > > > > > --- > > > > > .../bindings/interrupt-controller/atmel,aic.yaml | 12 +++= +++++++++ > > > > > 1 file changed, 12 insertions(+) > > > > >=20 > > > > > diff --git a/Documentation/devicetree/bindings/interrupt-controll= er/atmel,aic.yaml b/Documentation/devicetree/bindings/interrupt-controller/= atmel,aic.yaml > > > > > index 9c5af9dbcb6e..06e5f92e7d53 100644 > > > > > --- a/Documentation/devicetree/bindings/interrupt-controller/atme= l,aic.yaml > > > > > +++ b/Documentation/devicetree/bindings/interrupt-controller/atme= l,aic.yaml > > > > > @@ -54,6 +54,10 @@ properties: > > > > > $ref: /schemas/types.yaml#/definitions/uint32-array > > > > > description: u32 array of external irqs. > > > > > + microchip,nr-irqs: > > > > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > > > > + description: u32 array of nr_irqs. > > > > This makes no sense, did you just copy from above? Why would the nu= mber > > > > of irqs be an array? Why can't you determine this from the compatbl= e? > > > >=20 > > > Sorry for the bad description. I will correct it in the next version. > > >=20 > > > For the second part of the question, this change was done as a step to > > > resolve having a new compatible while having practically the same IP > > > pointed out in the v3 of the series [1]. It is kind of looping back to > > > the initial idea now. Even if this is added as a driver data, it > > > overrides the expectation from the comment in [1]. Please suggest. I > >=20 > > In your v3 patch, indeed you were extracting the number of IRQs from the > > compatibility string (aka, from device tree...). It's my preferred > > solution as well. > >=20 > > So, come back to v3 [1] and address what Conor said in v4 "...having > > specific $soc_aic5_of_init() functions for each SoC seems silly when > > usually only the number of interrupts changes. The number of IRQs could > > be in the match data and you could use aic5_of_init in your > > IRQCHIP_DECLARE directly" >=20 > Well, after a brief talk with Varshini and a review of the code, I'm not = so > sure it's worth re-writing this part anymore Conor... > It'll need changing 3-4 files (2 drivers and the "common" .h/.c files, > because of the type change of ".data"); handling the special case of sama= 5d2 > (smr_cache thing) and touching lot more code than what is done in v3 of t= his > patch series. >=20 > Original design was probably not optimal, but well, it's simple, > understandable and except if there is a big benefit in moving, I would > prefer to keep it like this. > If you agree, we can ask Varshini to re-post a separated IRQ-focused seri= es > for handling sam9x75 changes. I dunno, it's up to the folks that care about the driver whether they want to do restructuring, not me. The nr-irqs property stays NAKed though, since the information is determinable from the compatible. Thanks, Conor. --nDBBa4rtrpxCXD0u Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZo/9CgAKCRB4tDGHoIJi 0mx3AQCsqLkCivWDia6wN8hZKPu1StC5UsY51d1Rozwcn71YtgEArFLPqvA4ftRs hwFCmStS0rheTKUI+76oEvQMyLkXJw4= =Z7jH -----END PGP SIGNATURE----- --nDBBa4rtrpxCXD0u--