From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D3E8C3DA49 for ; Thu, 11 Jul 2024 16:45:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vybloJtqAMD3XBXViDgsQDiBzU52F1YzHw5VHYlk7nY=; b=pxESj6NHABkCFiX1ktvVdRXihV zG/J4CYqWOItAkXxsCc6/DLde4KkLFHejMHQYJEwFvIgc1kc0ZJsiBVNQriip7bog7uxQ0m8RG2XG tZYEevuCNDzsdWFtFRg5yuYPd4CTTXQpMl5jyS1AhGYmIKuTLhFiNzIcOZThx2h2jCMm9Jb7AzL2o sm0Wgv6q21+d3NL/aCb15gRFpcMpedhGn+sfobJbeWJAWrHCGb+vtHwELsZ33cM1eOvUDRGKbr15E BhgEBBjM1XrYlyEt9vPYL1D1EmvyafyLTPjjdzet9CkpOLvTAnpY3H7tdl38NHVdnwQuDANlRfnCY VGgcmkGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRwum-0000000Ejgh-2tLk; Thu, 11 Jul 2024 16:45:04 +0000 Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRwuU-0000000EjdL-0OqD for linux-arm-kernel@lists.infradead.org; Thu, 11 Jul 2024 16:44:47 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 668B7E0004; Thu, 11 Jul 2024 16:44:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1720716282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vybloJtqAMD3XBXViDgsQDiBzU52F1YzHw5VHYlk7nY=; b=P8v+jtd1ys5EiH6FMRVDPUMNPab4NRp9wkAGbEK57+f4iby7pSGs18DQ8P4Y4ZLvuK5WLj SQQ1kcxRfly3QwFY6kvql7ACeTUqF57HksCL4JJj4Fkf4v/J/gipIXtdkVgOEht7nCCpcH hEPaFCptezq+Derxp7uiXWiOq1+bGEkLmF5fpqbhzgrbwsAqNmlwhxYGjUTsZA9avOX4tH LwtljISqcHPjmdYuHF1pQYHr/9B1esqtLWTba+vvfMLxU/2lO970tOuj2sZRFMyqDBuGLK 9l0YwOfE2kna6alACHj/ngciu9N3lo4TKwV0QkCg2l8wMRw1lRswMsGlr3HVLw== Date: Thu, 11 Jul 2024 18:44:38 +0200 From: Herve Codina To: Lee Jones Cc: Andy Shevchenko , Simon Horman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Arnd Bergmann , UNGLinuxDriver@microchip.com, Saravana Kannan , Bjorn Helgaas , Philipp Zabel , Lars Povlsen , Steen Hegelund , Daniel Machon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Horatiu Vultur , Andrew Lunn , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Allan Nielsen , Luca Ceresoli , Thomas Petazzoni , Greg Kroah-Hartman Subject: Re: [PATCH v3 6/7] mfd: Add support for LAN966x PCI device Message-ID: <20240711184438.65446cc3@bootlin.com> In-Reply-To: <20240711152952.GL501857@google.com> References: <20240627091137.370572-1-herve.codina@bootlin.com> <20240627091137.370572-7-herve.codina@bootlin.com> <20240711152952.GL501857@google.com> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240711_094446_302986_E164CE69 X-CRM114-Status: GOOD ( 18.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Lee, On Thu, 11 Jul 2024 16:29:52 +0100 Lee Jones wrote: > On Thu, 27 Jun 2024, Herve Codina wrote: > > > Add a PCI driver that handles the LAN966x PCI device using a device-tree > > overlay. This overlay is applied to the PCI device DT node and allows to > > describe components that are present in the device. > > > > The memory from the device-tree is remapped to the BAR memory thanks to > > "ranges" properties computed at runtime by the PCI core during the PCI > > enumeration. > > > > The PCI device itself acts as an interrupt controller and is used as the > > parent of the internal LAN966x interrupt controller to route the > > interrupts to the assigned PCI INTx interrupt. > > Not entirely sure why this is in MFD. This PCI driver purpose is to instanciate many other drivers using a DT overlay. I think MFD is the right subsystem. It acts as an interrupt controller because we need to have a bridge between the device-tree interrupt world and the the PCI world. This bridge is needed and specific to the driver in order to have resources available from the device-tree world present in the applied overlay. > > Also I'm unsure of his current views, but Greg has voiced pretty big > feelings about representing PCI drivers as Platform ones in the past. PCI drivers as Plaform ones ? I probably missed something. Can you give me more details ? Best regards, Hervé