From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F41FC3DA4A for ; Thu, 11 Jul 2024 20:35:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IouwIgo+kP+HswbewtSJ8i0mZUqTEtq++kfOp3rA2cc=; b=MCGmBxq6LT/Hk+tzZYVpvVIFVn aS96smva2pUDdD+guxVoKUirx2EJZRZyFwUyh11qAREIZ9t/DJ4/CPoSCYCs+s95DsKZ8si+n0pXi PVP3KA7811rRpwSPBn75EK5HwF2qdxwt92b7GLi/Cu7iWvSmFFL9tG3nIl1F3nWDOeItNteLzY2Cl NKfNabiNdxv9Ue4ZIZ/c16SlsZibq1UMieWjPVL8CpuRM+gxHX05zv5kYL7pp2mCq1yY+Ubkhxoq1 x0yHGfDbd8h/CC85w7YvY6JAO39TEAcBir+6MSVNwFMfXQbDgSKkfBf+pirupWp2ZOILmjIWFeu14 6I33Gq7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sS0Vc-0000000FMXp-0F8y; Thu, 11 Jul 2024 20:35:20 +0000 Received: from relay8-d.mail.gandi.net ([2001:4b98:dc4:8::228]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sS0U1-0000000FMJr-1S3p for linux-arm-kernel@lists.infradead.org; Thu, 11 Jul 2024 20:35:03 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id ADB9E1BF204; Thu, 11 Jul 2024 20:33:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1720730018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IouwIgo+kP+HswbewtSJ8i0mZUqTEtq++kfOp3rA2cc=; b=pCY61RYf9XpU6OIywfEq/tnfP//rltf0nVP6mHpAIyZ9HRqzcuYkkUUEqws8i+jLDHWAdi Cx9TMIeayt/qDOsq0yfzsOzfmrWnvSQ/+80UE/7t+gGK3f+aBhk4tDwyJUUgLYdN9+1ow3 AzGh0WM37wucGQbgYBl9QNSK6VUjNONo4XrAhRDJrI6I49NquqUDu8KoWWmg1HX0nDkvbw 51umsal5Q9HuB3QqBZzWHYgTQsRU8HdfCug1Ys06Q0ZKwKoCUBL8wCuJK6N/qpHL3u8BV4 Y3WmyHRxSp2MzP1KS5tLPLXWUdoa1kkSVMPzVeNWyOxMSQoI6gi/az8Js3LLDQ== Date: Thu, 11 Jul 2024 22:33:37 +0200 From: Alexandre Belloni To: "Peng Fan (OSS)" Cc: Jonathan Corbet , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peng Fan , Dmitry Torokhov , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, arm-scmi@vger.kernel.org, linux-rtc@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH v5 6/7] rtc: support i.MX95 BBM RTC Message-ID: <202407112033378dbbea83@mail.local> References: <20240621-imx95-bbm-misc-v2-v5-0-b85a6bf778cb@nxp.com> <20240621-imx95-bbm-misc-v2-v5-6-b85a6bf778cb@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240621-imx95-bbm-misc-v2-v5-6-b85a6bf778cb@nxp.com> X-GND-Sasl: alexandre.belloni@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240711_133341_931903_78E5575A X-CRM114-Status: GOOD ( 15.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On 21/06/2024 15:04:41+0800, Peng Fan (OSS) wrote: > + ret = bbnsm->ops->rtc_time_get(ph, 0, &val); > + if (ret) { > + dev_err(dev, "%s: %d\n", __func__, ret); This is not super useful, you should drop the various dev_err or pr_err as there is no action the user can take to solve the erro apart from retrying. > + return ret; > + } > + > + rtc_time64_to_tm(val, tm); > + > + return 0; > +} > + > +static int scmi_imx_bbm_set_time(struct device *dev, struct rtc_time *tm) > +{ > + struct scmi_imx_bbm *bbnsm = dev_get_drvdata(dev); > + struct scmi_protocol_handle *ph = bbnsm->ph; > + u64 val; > + int ret; > + > + val = rtc_tm_to_time64(tm); > + > + ret = bbnsm->ops->rtc_time_set(ph, 0, val); > + if (ret) > + dev_err(dev, "%s: %d\n", __func__, ret); > + > + return ret; > +} > + > +static int scmi_imx_bbm_alarm_irq_enable(struct device *dev, unsigned int enable) > +{ How can userspace disable the alarm? > + return 0; > +} > + > +static int scmi_imx_bbm_set_alarm(struct device *dev, struct rtc_wkalrm *alrm) > +{ > + struct scmi_imx_bbm *bbnsm = dev_get_drvdata(dev); > + struct scmi_protocol_handle *ph = bbnsm->ph; > + struct rtc_time *alrm_tm = &alrm->time; > + u64 val; > + int ret; > + > + val = rtc_tm_to_time64(alrm_tm); > + > + ret = bbnsm->ops->rtc_alarm_set(ph, 0, val); > + if (ret) > + dev_err(dev, "%s: %d\n", __func__, ret); > + > + return ret; > +} > + > +static const struct rtc_class_ops smci_imx_bbm_rtc_ops = { > + .read_time = scmi_imx_bbm_read_time, > + .set_time = scmi_imx_bbm_set_time, > + .set_alarm = scmi_imx_bbm_set_alarm, > + .alarm_irq_enable = scmi_imx_bbm_alarm_irq_enable, > +}; > + > +static int scmi_imx_bbm_rtc_notifier(struct notifier_block *nb, unsigned long event, void *data) > +{ > + struct scmi_imx_bbm *bbnsm = container_of(nb, struct scmi_imx_bbm, nb); > + struct scmi_imx_bbm_notif_report *r = data; > + > + if (r->is_rtc) > + rtc_update_irq(bbnsm->rtc_dev, 1, RTC_AF | RTC_IRQF); > + else > + pr_err("Unexpected bbm event: %s\n", __func__); > + > + return 0; > +} > + > +static int scmi_imx_bbm_rtc_init(struct scmi_device *sdev) > +{ > + const struct scmi_handle *handle = sdev->handle; > + struct device *dev = &sdev->dev; > + struct scmi_imx_bbm *bbnsm = dev_get_drvdata(dev); > + int ret; > + > + bbnsm->rtc_dev = devm_rtc_allocate_device(dev); > + if (IS_ERR(bbnsm->rtc_dev)) > + return PTR_ERR(bbnsm->rtc_dev); > + > + bbnsm->rtc_dev->ops = &smci_imx_bbm_rtc_ops; > + bbnsm->rtc_dev->range_min = 0; range_min is set to 0 by default, this is not necessary > + bbnsm->rtc_dev->range_max = U32_MAX; > + > + ret = devm_rtc_register_device(bbnsm->rtc_dev); > + if (ret) > + return ret; > + > + bbnsm->nb.notifier_call = &scmi_imx_bbm_rtc_notifier; > + return handle->notify_ops->devm_event_notifier_register(sdev, SCMI_PROTOCOL_IMX_BBM, > + SCMI_EVENT_IMX_BBM_RTC, > + NULL, &bbnsm->nb); Note that failing after devm_rtc_register_device opens the driver to a race condition as the character device will exist at that time. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com