From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7C26C3DA4A for ; Thu, 11 Jul 2024 21:39:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FdPzk5pQxF0prSvFsjrIivsKi6sKlt0NjkmAVn/YfnA=; b=CvWImYXc8OZEz4FC+LJbcycz/k V2eN2fCn5Z7g2axx/Z9iKptaPggBmcknSagcz1oqv43T2nwFOJF3CY1Kv7mUtS+rIHPHrsH2WmWlx nRHC5iCITR7h8z5K9uHJt7+a5yOXunqsplbV2vuOwplumuafxFJB4EiZD3pWSZ7qKP8crDrceRx0K JsYEYWV+UXZM5vj3haSRv30XEeyJ6hCoNpyUV9rocuQkUdLReQ0wQNjcGvrQUAmwEiW/OxT5aXjFT 8PEOgaPbYOZaE91w6Md11tOoD7Ip+tgEDGsTPSY5xz5mOx2rdwQLHP/SMrzKVAWCj66x38w/defvt AEcjSJWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sS1VN-0000000FWdg-0R5b; Thu, 11 Jul 2024 21:39:09 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sS1V4-0000000FWYN-2UQT for linux-arm-kernel@lists.infradead.org; Thu, 11 Jul 2024 21:38:52 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id BA6ADCE19FD; Thu, 11 Jul 2024 21:38:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6A68C116B1; Thu, 11 Jul 2024 21:38:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720733928; bh=mSHQDPosDfKU1D8H0/EEVCf/SnYHDoua5Vn7yYsQoaI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Bt8wYhhRbsosxOUHAr4wDJBsjg3BaM5IZoZjxxYP8i0a4X2nFfm9xppaKEZGRXy3a yNpyUZb53OjU6IIlVGvz9LXD0F59CkCDsvVFl+7RNVwvx2/h9kFzSuXMYnfiaNJYpH lEcEJEzY9RiWHksrSEcs8TGrw5/DhkAYXBWlsPzW9KMIA4jdfm1kVvrO38FxKNkZvk oKiSPNucdCf31BR5MqSSV4+D0bqf/DYnDk9YPFKA7J7kvKO6mua7QM7MTOK/MDjUqN eDFG/jpcnVLMy7awKcKZQ1HdPrqqp2q9eJRjKZnIKqgGQhrA2b1ALt3URP78rCnlHi A3YHVLJ7jPfpQ== Date: Thu, 11 Jul 2024 15:38:46 -0600 From: Rob Herring To: Frank Li Cc: Greg Kroah-Hartman , Krzysztof Kozlowski , Conor Dooley , Thinh Nguyen , Shawn Guo , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev Subject: Re: [PATCH 3/3] arm64: dts: layerscape: move dwc3 usb under glue layer node Message-ID: <20240711213846.GA3049961-robh@kernel.org> References: <20240710-ls-dwc-v1-0-62f8cbed31d7@nxp.com> <20240710-ls-dwc-v1-3-62f8cbed31d7@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240710-ls-dwc-v1-3-62f8cbed31d7@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240711_143850_842148_5B1CA19A X-CRM114-Status: GOOD ( 14.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 10, 2024 at 07:02:24PM -0400, Frank Li wrote: > New usb glue layer driver support enable dma-coherent. So put dwc3 usb node > under glue layer node and enable dma-coherent. > > Signed-off-by: Frank Li > --- > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 43 ++++++++++++++++---------- > 1 file changed, 26 insertions(+), 17 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > index 70b8731029c4e..24b937032480f 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > @@ -615,24 +615,33 @@ gpio3: gpio@2320000 { > little-endian; > }; > > - usb0: usb@3100000 { > - compatible = "fsl,ls1028a-dwc3", "snps,dwc3"; > - reg = <0x0 0x3100000 0x0 0x10000>; > - interrupts = ; > - snps,dis_rxdet_inp3_quirk; > - snps,quirk-frame-length-adjustment = <0x20>; > - snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>; > - status = "disabled"; > - }; > + usb { > + compatible = "fsl,ls1028a-dwc3"; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; No, the existing way is preferred unless you have actual glue/wrapper registers. Plus this breaks compatibility. > + > + usb0: usb@3100000 { > + compatible = "snps,dwc3"; > + reg = <0x0 0x3100000 0x0 0x10000>; > + interrupts = ; > + dma-coherent; > + snps,dis_rxdet_inp3_quirk; > + snps,quirk-frame-length-adjustment = <0x20>; > + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>; > + status = "disabled"; > + };