From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89410C3DA45 for ; Thu, 11 Jul 2024 22:36:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bb+aoPbFzqJJotxFHf7X+USu/4Yogi3HTzYeooRgrE4=; b=SlCWEnfk63M2bFc8lWvIlAhWv4 4AEf6ugON8TvEnwILml4rtDa2ymXFMiikLyxUG0BilUJo78rRqfr15H6qKfEFxkNZ25dOTQvyyYST n6X/YJ/lvDEYjhyAnIB3mOE0x0OSrzPTplWxAYjk7KNY7v+g8cBVKzRlPDbxo9VZ031uijl2duZGF /Dt0mQUklGkhcDcQQpEJ7cccEqeeZDKmyHqcc0P1H6kuy8IBPAw+KTbGoKa+nQ2qiyuePLTyRfoH7 dtNswE2W7EqY7uEyZqe5iKsVr3NYYl+YZCGN3gKRI59Z0mTDQM0RW69HFPrASEmoPEALLwmV2KvGu 2Wy5KUHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sS2P1-0000000Fgj0-1X0k; Thu, 11 Jul 2024 22:36:39 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sS2Oi-0000000Fges-4AQj for linux-arm-kernel@lists.infradead.org; Thu, 11 Jul 2024 22:36:22 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C31BC61EEE; Thu, 11 Jul 2024 22:36:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B487C32782; Thu, 11 Jul 2024 22:36:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720737379; bh=pirreVvy4JZn8lrnWfmD1cwECwdJ1hvtT3Z1k6qiOwk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ks8ELnCmsBZ4ZxMYxC8SuWAARCYiWRJZth0Zyt2UkPp/K/lMnmocSf81YBl6SiiNT 9EmZM/rP13whx+pEGYHjq33WVwsaXcFI04u4h0Xdp3CHgQbxHRS5T/cwQSPlutGUPQ w/XSc9Y3yIO6s3CTlWHuiUuS72Xs1FDIT1kTTUyj+ex6Je0OVJTO3FRoYn2+haZdle H4A1enmwEcV7wAyyeTpVcElD1vWsHCgmL4cP6H8t/BSFhWxXaUhMPRbtpMFaPLNtZO sMs6hSmwYtuq5Fah4gfxcu5YiQFlKM6XDscniSMdF/dEBhjbQIOdx09ch5PTd3NBs/ /A5ym9rdYGSIA== Date: Thu, 11 Jul 2024 16:36:18 -0600 From: Rob Herring To: Sai Krishna Potthuri Cc: Linus Walleij , Michal Simek , Krzysztof Kozlowski , Conor Dooley , Jay Buddhabhatti , Dhaval Shah , Praveen Teja Kundanala , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, saikrishna12468@gmail.com, git@amd.com Subject: Re: [PATCH 1/3] dt-bindings: pinctrl: Add support for Xilinx Versal platform Message-ID: <20240711223618.GA3237343-robh@kernel.org> References: <20240711103317.891813-1-sai.krishna.potthuri@amd.com> <20240711103317.891813-2-sai.krishna.potthuri@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240711103317.891813-2-sai.krishna.potthuri@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240711_153621_186549_CFBC8681 X-CRM114-Status: GOOD ( 17.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 11, 2024 at 04:03:15PM +0530, Sai Krishna Potthuri wrote: > Add Xilinx Versal compatible string and corresponding groups, function and > pins properties to support pin controller features on Versal platform. > > Signed-off-by: Sai Krishna Potthuri > --- > .../bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml | 509 +++++++++++------- > 1 file changed, 329 insertions(+), 180 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml > index ce66fd15ff9c..68c378b17f49 100644 > --- a/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml > @@ -28,7 +28,9 @@ description: | > > properties: > compatible: > - const: xlnx,zynqmp-pinctrl > + enum: > + - xlnx,zynqmp-pinctrl > + - xlnx,versal-pinctrl > > patternProperties: > '^(.*-)?(default|gpio-grp)$': > @@ -46,196 +48,334 @@ patternProperties: > description: > List of pins to select (either this or "groups" must be specified) > items: > - pattern: '^MIO([0-9]|[1-6][0-9]|7[0-7])$' > + allOf: > + - if: > + properties: > + compatible: > + contains: > + const: xlnx,zynqmp-pinctrl > + then: > + pattern: '^MIO([0-9]|[1-6][0-9]|7[0-7])$' > + else: > + pattern: '^((LPD|PMC)_)?MIO([0-9]|[1-6][0-9]|7[0-7])$' Did you test whether this works? It doesn't because the schema is nonsense. The schema applies to a property's value, but the "if" schema applies to a node. And it's not even the node you are at, but the parent node. IOW, there is no "compatible" in this node. The 'else' schema covers both cases, so I'd just change the pattern and be done with it. However, based on the rest of the patch, you should just do a new schema doc. There's little overlap of the values. Rob