From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Richard Zhu <hongxing.zhu@nxp.com>
Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: [PATCH 3/6] remoteproc: imx_rproc: initialize workqueue earlier
Date: Fri, 12 Jul 2024 16:34:56 +0800 [thread overview]
Message-ID: <20240712-imx_rproc-v1-3-7bcf6732d328@nxp.com> (raw)
In-Reply-To: <20240712-imx_rproc-v1-0-7bcf6732d328@nxp.com>
From: Peng Fan <peng.fan@nxp.com>
Initialize workqueue before requesting mailbox channel, otherwise if
mailbox interrupt comes before workqueue ready, the imx_rproc_rx_callback
will trigger issue.
Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/remoteproc/imx_rproc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
index 48c48b53a3aa..9e99bb27c033 100644
--- a/drivers/remoteproc/imx_rproc.c
+++ b/drivers/remoteproc/imx_rproc.c
@@ -1087,6 +1087,8 @@ static int imx_rproc_probe(struct platform_device *pdev)
return -ENOMEM;
}
+ INIT_WORK(&priv->rproc_work, imx_rproc_vq_work);
+
ret = imx_rproc_xtr_mbox_init(rproc);
if (ret)
goto err_put_wkq;
@@ -1105,8 +1107,6 @@ static int imx_rproc_probe(struct platform_device *pdev)
if (ret)
goto err_put_scu;
- INIT_WORK(&priv->rproc_work, imx_rproc_vq_work);
-
if (rproc->state != RPROC_DETACHED)
rproc->auto_boot = of_property_read_bool(np, "fsl,auto-boot");
--
2.37.1
next prev parent reply other threads:[~2024-07-12 8:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 8:34 [PATCH 0/6] remoteproc: imx_rproc: various patches for misc Peng Fan (OSS)
2024-07-12 8:34 ` [PATCH 1/6] remoteproc: imx_rproc: correct ddr alias for i.MX8M Peng Fan (OSS)
2024-07-16 15:16 ` Mathieu Poirier
[not found] ` <4819651d-b9f7-4fa4-81b9-614b6d4d5a80@nxp.com>
2024-07-16 15:52 ` Mathieu Poirier
2024-07-19 5:46 ` Peng Fan
2024-07-12 8:34 ` [PATCH 2/6] remoteproc: imx_rproc: use imx specific hook for find_loaded_rsc_table Peng Fan (OSS)
2024-07-19 6:44 ` Iuliana Prodan
2024-07-12 8:34 ` Peng Fan (OSS) [this message]
2024-07-16 15:38 ` [PATCH 3/6] remoteproc: imx_rproc: initialize workqueue earlier Mathieu Poirier
2024-07-19 5:48 ` Peng Fan
2024-07-12 8:34 ` [PATCH 4/6] remoteproc: imx_rproc: merge TCML/U Peng Fan (OSS)
2024-07-16 15:42 ` Mathieu Poirier
2024-07-19 5:50 ` Peng Fan
2024-07-19 6:45 ` Iuliana Prodan
2024-07-12 8:34 ` [PATCH 5/6] remoteproc: imx_rproc: allow tx_block to be set Peng Fan (OSS)
2024-07-16 15:46 ` Mathieu Poirier
2024-07-19 5:51 ` Peng Fan
2024-07-12 8:34 ` [PATCH 6/6] remoteproc: imx_rproc: handle system off for i.MX7ULP Peng Fan (OSS)
2024-07-16 15:49 ` Mathieu Poirier
2024-08-05 20:38 ` Frank Li
2024-08-08 2:56 ` Peng Fan
2024-08-14 14:38 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240712-imx_rproc-v1-3-7bcf6732d328@nxp.com \
--to=peng.fan@oss.nxp.com \
--cc=andersson@kernel.org \
--cc=festevam@gmail.com \
--cc=hongxing.zhu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).