From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A144BC3DA45 for ; Fri, 12 Jul 2024 18:17:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:To:From:Subject :References:Mime-Version:Message-Id:In-Reply-To:Date:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dI8yaROyMxBgkl/C6HStDZ1DbB4Rpu7ZnQVumFggSVU=; b=JIv1GmrVuSeJ6m9ERU6n4jWWWk 9euJGCSOQMynoB86MTA9HFG/j9wJLgLU3EL0JbjD/FplAlLZiggDdu8II98UZSuLN7z6YLI7WaSn9 u8dc8KTTNqiFTk34pnykWik5D1lte+Kv3RD4rBdXdlp9skBUiliWioQonD0yFTgG3SVHxDtvrnypK /K4fMG1IH3O3E3D1oX+5dSKxznczpWBoH5AUIgfz3og3SDYUYBBkOkrXNzZevJPsAkS6M6rvglSGd X6AB+uNN3i6/ungOsefWiQLH+xOnodu9PC+Wro9/8VccfytK3OXwh9rQrU6nhzCZTNzPN8Qoq7uTI fX42kGhw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSKpv-00000000xby-39A2; Fri, 12 Jul 2024 18:17:39 +0000 Received: from mail-yb1-xb49.google.com ([2607:f8b0:4864:20::b49]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSKlJ-00000000vXB-36Zm for linux-arm-kernel@lists.infradead.org; Fri, 12 Jul 2024 18:12:55 +0000 Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-dfa7a8147c3so4181799276.3 for ; Fri, 12 Jul 2024 11:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1720807972; x=1721412772; darn=lists.infradead.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=dI8yaROyMxBgkl/C6HStDZ1DbB4Rpu7ZnQVumFggSVU=; b=CQmgPD04PdbBnYXOsKuJU8BABn1aUQu2FfBurhFrBYQzoPWFL3FWgS92QinwTgWsdb R3dXSBK7fRm/fd21MY4LLNA8xDcY6T9hS5HJRPWYpf/VoqWO78PHeeeuhCgOxwDKA5HF xkqcgE35a0pbJMEMPCE29P0EK4R32WbKtDfqN+3PZMlvlyWQ6vG27inGk4juojDlC16Q oXDgonxfFFj9B7IL/3YlFQhJJ3Gz2cjKRWjMPTI0RSOGqyGjw+9kjMhdQ7Hw27BVFG+D x2qK3409grAchV6gu5JPr8gYSh45UJAgzwUB/2fj0x8RavUPbfcIGelrLAh8eng052ep 0qJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720807972; x=1721412772; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dI8yaROyMxBgkl/C6HStDZ1DbB4Rpu7ZnQVumFggSVU=; b=X9EcafHfOo6DpxXOA63ultvzz3FeJHNhcs8oqznoBKSnBW5DK+HfNPCwiuIWqJVacU 3hbUwiR9mH5kRXyHBwvwytPO43fs1XwqNR9lOKs/27CzJ/bOey9esAnPJYhJmjH0dI2+ IgPRVyY8JA/WdgBZmqg0CEn923ogbqxYJvtZvLTgw8CxhtC3fvhTb5+QdVOPzvyOWHmW IBUEb9DD9qiuhmtzN3waNVDqbTOiWRly3lWpwmhwmFj1KoBB23dtyXwgo4PbzsTL7DMl 5/60jJCOmxGPWHM9bAtK8h4uLZDXUgl5WOnFMxOoKEpToRsZq18iD8RplVgYG3WTC1E8 npRQ== X-Forwarded-Encrypted: i=1; AJvYcCW2eXDv4xdXXYkSNwJQI5SJD62AwcaVY7kk9fABhxFKVH9DFXQHsDx0tiCUJJ8L8st/br96E9+GYHOBBo8E9t0rXSmGS821siB+mreK7xmyO67jgmA= X-Gm-Message-State: AOJu0YwBIM5D/ZTZgUuAv2G6+Ialm6ZOvXa7QTj3Mc3Ny21CjSCVZBrf SqUKltIOLPZ70q4+TTZv7HHogpV9nm8CdjeyHmtXWzAzoOAFty7xVRQqX/irl534C7zTyG5262D 1HrPOTg== X-Google-Smtp-Source: AGHT+IEdjKOWNbH6lHnQ3hQD9ZpV0aONsOjoRMeD9l9g2HUs1hV6yUVjuLwzYNk5GAitqb5lFTEdkOp686G6 X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:2e7d:d47a:a0c6:e3b1]) (user=irogers job=sendgmr) by 2002:a05:6902:1146:b0:e03:6556:9fa1 with SMTP id 3f1490d57ef6-e041b11d3demr762464276.8.1720807972320; Fri, 12 Jul 2024 11:12:52 -0700 (PDT) Date: Fri, 12 Jul 2024 11:11:00 -0700 In-Reply-To: <20240712181108.475336-1-irogers@google.com> Message-Id: <20240712181108.475336-20-irogers@google.com> Mime-Version: 1.0 References: <20240712181108.475336-1-irogers@google.com> X-Mailer: git-send-email 2.45.2.993.g49e7a77208-goog Subject: [PATCH v5 19/27] perf mem: Use perf_tool__init From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Suzuki K Poulose , Yicong Yang , Jonathan Cameron , Nick Terrell , Nick Desaulniers , Oliver Upton , Anshuman Khandual , Song Liu , Ilkka Koskinen , Athira Rajeev , Huacai Chen , Yanteng Si , Sun Haiyong , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240712_111253_792834_824077EE X-CRM114-Status: GOOD ( 13.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use perf_tool__init so that more uses of struct perf_tool can be const and not relying on perf_tool__fill_defaults. Signed-off-by: Ian Rogers --- tools/perf/builtin-mem.c | 33 +++++++++++++++++---------------- 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/tools/perf/builtin-mem.c b/tools/perf/builtin-mem.c index c2038a32543c..c12ca0ec1237 100644 --- a/tools/perf/builtin-mem.c +++ b/tools/perf/builtin-mem.c @@ -285,7 +285,23 @@ static int report_raw_events(struct perf_mem *mem) .force = mem->force, }; int ret; - struct perf_session *session = perf_session__new(&data, &mem->tool); + struct perf_session *session; + + perf_tool__init(&mem->tool, /*ordered_events=*/true); + mem->tool.sample = process_sample_event; + mem->tool.mmap = perf_event__process_mmap; + mem->tool.mmap2 = perf_event__process_mmap2; + mem->tool.comm = perf_event__process_comm; + mem->tool.lost = perf_event__process_lost; + mem->tool.fork = perf_event__process_fork; + mem->tool.attr = perf_event__process_attr; + mem->tool.build_id = perf_event__process_build_id; + mem->tool.namespaces = perf_event__process_namespaces; + mem->tool.auxtrace_info = perf_event__process_auxtrace_info; + mem->tool.auxtrace = perf_event__process_auxtrace; + mem->tool.auxtrace_error = perf_event__process_auxtrace_error; + + session = perf_session__new(&data, &mem->tool); if (IS_ERR(session)) return PTR_ERR(session); @@ -449,21 +465,6 @@ int cmd_mem(int argc, const char **argv) { struct stat st; struct perf_mem mem = { - .tool = { - .sample = process_sample_event, - .mmap = perf_event__process_mmap, - .mmap2 = perf_event__process_mmap2, - .comm = perf_event__process_comm, - .lost = perf_event__process_lost, - .fork = perf_event__process_fork, - .attr = perf_event__process_attr, - .build_id = perf_event__process_build_id, - .namespaces = perf_event__process_namespaces, - .auxtrace_info = perf_event__process_auxtrace_info, - .auxtrace = perf_event__process_auxtrace, - .auxtrace_error = perf_event__process_auxtrace_error, - .ordered_events = true, - }, .input_name = "perf.data", /* * default to both load an store sampling -- 2.45.2.993.g49e7a77208-goog