From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40DF7C3DA59 for ; Mon, 15 Jul 2024 13:39:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PSbNaRMTYtzre19uKeEiHmRJX5JW5ZJQsQbhlJpFEO4=; b=fkOpVQ5Q4F7ZQ1QW4mS3BcAuIT XKUP2Jlw8od8S47ENAcZFNK2qpIPWG0Z6YBkr34ZqlPdJPH3zOZYsQrBjKlu62Dpak/OGA1++nH8N uXBSnlb4qeXegxDQfdgcM+WLn9MEkHrLkGUqrvc373yEllHpKDjfDBppC3FOzppaH8+8hAlYIZ22/ vZKIHvWbCnY2uPCxIttkg9CRT+GH2No4cg4CFrDL0uh62cGO83OyDAAs1wqMksBL9yZlSYKLUCBjp v23gPh6gKJdJmwmEy4A7afzy9zQX7u/FPNdCV/PwlvLRMFrR+S2hkvrkFn28ubcn8dRB1qNZBhao+ EPJtCxmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTLvf-00000007FBU-0gdF; Mon, 15 Jul 2024 13:39:47 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTLuB-00000007Ec5-0yC4 for linux-arm-kernel@lists.infradead.org; Mon, 15 Jul 2024 13:38:17 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0DABCDA7; Mon, 15 Jul 2024 06:38:40 -0700 (PDT) Received: from thinkcentre-m93p.cambridge.arm.com (thinkcentre-m93p.cambridge.arm.com [10.1.197.43]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E2DBA3F73F; Mon, 15 Jul 2024 06:38:13 -0700 (PDT) From: Luke Parkin To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org Cc: sudeep.holla@arm.com, cristian.marussi@arm.com, Luke Parkin Subject: [PATCH v3 5/5] firmware: arm_scmi: Reset statistics Date: Mon, 15 Jul 2024 14:37:51 +0100 Message-Id: <20240715133751.2877197-6-luke.parkin@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240715133751.2877197-1-luke.parkin@arm.com> References: <20240715133751.2877197-1-luke.parkin@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240715_063815_377066_D8691CF6 X-CRM114-Status: GOOD ( 10.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Create write function to reset individual statistics on write Create reset_all stats debugfs file to reset all statistics Signed-off-by: Luke Parkin --- drivers/firmware/arm_scmi/driver.c | 104 +++++++++++++++++++++-------- 1 file changed, 78 insertions(+), 26 deletions(-) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index 9378e2d8af4f..6a90311f764d 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -2865,6 +2865,47 @@ static int scmi_device_request_notifier(struct notifier_block *nb, return NOTIFY_OK; } +static int read_atomic(void *atomic, u64 *val) +{ + atomic_t *atm = (atomic_t *)atomic; + + *val = atomic_read(atm); + return 0; +} + +static int reset_single(void *atomic, u64 val) +{ + atomic_t *atm = (atomic_t *)atomic; + + atomic_set(atm, 0); + return 0; +} + +static void reset_all_stats(struct scmi_info *info) +{ + for (int i = 0; i < LAST; i++) + atomic_set(&info->dbg_stats[i], 0); +} + +static ssize_t reset_all_on_write(struct file *filp, + const char __user *buf, + size_t count, loff_t *ppos) +{ + struct scmi_info *info = filp->private_data; + + reset_all_stats(info); + return count; +} + +DEFINE_DEBUGFS_ATTRIBUTE(fops_reset_on_write, read_atomic, reset_single, "%llu\n"); + +static const struct file_operations fops_reset_stats = { + .owner = THIS_MODULE, + .open = simple_open, + .llseek = no_llseek, + .write = reset_all_on_write, +}; + static void scmi_debugfs_stats_setup(struct scmi_info *info, struct dentry *trans) { @@ -2872,32 +2913,43 @@ static void scmi_debugfs_stats_setup(struct scmi_info *info, stats = debugfs_create_dir("stats", trans); - debugfs_create_atomic_t("sent_ok", 0400, stats, - &info->dbg_stats[SENT_OK]); - debugfs_create_atomic_t("sent_fail", 0400, stats, - &info->dbg_stats[SENT_FAIL]); - debugfs_create_atomic_t("sent_fail_polling_unsupported", 0400, stats, - &info->dbg_stats[SENT_FAIL_POLLING_UNSUPPORTED]); - debugfs_create_atomic_t("sent_fail_channel_not_found", 0400, stats, - &info->dbg_stats[SENT_FAIL_CHANNEL_NOT_FOUND]); - debugfs_create_atomic_t("response_ok", 0400, stats, - &info->dbg_stats[RESPONSE_OK]); - debugfs_create_atomic_t("notif_ok", 0400, stats, - &info->dbg_stats[NOTIF_OK]); - debugfs_create_atomic_t("dlyd_resp_ok", 0400, stats, - &info->dbg_stats[DLYD_RESPONSE_OK]); - debugfs_create_atomic_t("xfers_resp_timeout", 0400, stats, - &info->dbg_stats[XFERS_RESPONSE_TIMEOUT]); - debugfs_create_atomic_t("response_polled_ok", 0400, stats, - &info->dbg_stats[RESPONSE_POLLED_OK]); - debugfs_create_atomic_t("err_msg_unexpected", 0400, stats, - &info->dbg_stats[ERR_MSG_UNEXPECTED]); - debugfs_create_atomic_t("err_msg_invalid", 0400, stats, - &info->dbg_stats[ERR_MSG_INVALID]); - debugfs_create_atomic_t("err_msg_nomem", 0400, stats, - &info->dbg_stats[ERR_MSG_NOMEM]); - debugfs_create_atomic_t("err_protocol", 0400, stats, - &info->dbg_stats[ERR_PROTOCOL]); + debugfs_create_file("sent_ok", 0400, stats, &info->dbg_stats[SENT_OK], + &fops_reset_on_write); + debugfs_create_file("sent_fail", 0400, stats, + &info->dbg_stats[SENT_FAIL], &fops_reset_on_write); + debugfs_create_file("sent_fail_polling_unsupported", 0400, stats, + &info->dbg_stats[SENT_FAIL_POLLING_UNSUPPORTED], + &fops_reset_on_write); + debugfs_create_file("sent_fail_channel_not_found", 0400, stats, + &info->dbg_stats[SENT_FAIL_CHANNEL_NOT_FOUND], + &fops_reset_on_write); + debugfs_create_file("response_ok", 0400, stats, + &info->dbg_stats[RESPONSE_OK], + &fops_reset_on_write); + debugfs_create_file("notif_ok", 0400, stats, &info->dbg_stats[NOTIF_OK], + &fops_reset_on_write); + debugfs_create_file("dlyd_resp_ok", 0400, stats, + &info->dbg_stats[DLYD_RESPONSE_OK], + &fops_reset_on_write); + debugfs_create_file("xfers_resp_timeout", 0400, stats, + &info->dbg_stats[XFERS_RESPONSE_TIMEOUT], + &fops_reset_on_write); + debugfs_create_file("response_polled_ok", 0400, stats, + &info->dbg_stats[RESPONSE_POLLED_OK], + &fops_reset_on_write); + debugfs_create_file("err_msg_unexpected", 0400, stats, + &info->dbg_stats[ERR_MSG_UNEXPECTED], + &fops_reset_on_write); + debugfs_create_file("err_msg_invalid", 0400, stats, + &info->dbg_stats[ERR_MSG_INVALID], + &fops_reset_on_write); + debugfs_create_file("err_msg_nomem", 0400, stats, + &info->dbg_stats[ERR_MSG_NOMEM], + &fops_reset_on_write); + debugfs_create_file("err_protocol", 0400, stats, + &info->dbg_stats[ERR_PROTOCOL], + &fops_reset_on_write); + debugfs_create_file("reset", 0200, stats, info, &fops_reset_stats); } static void scmi_debugfs_common_cleanup(void *d) -- 2.34.1